Odoo Addons (MOVED TO GITHUB)

[6.1] purchase: changing a product uses wrong supplier info data

Bug #1048547 reported by Niels Huylebroeck on 2012-09-10

This bug affects 2 people

	Status	Importance	Assigned to
Odoo Addons (MOVED TO GITHUB)	Fix Committed	Low	OpenERP Publisher's Warranty Team
OpenERP Community Backports (Addons)	New	Undecided	Unassigned
6.1	Fix Released	Medium	Yann Papouin

Bug Description

Hi,

When entering purchase orders we get osv.except_osv raised because of some refactoring regression in the onchange_product_id function which mistakenly searches for the product_id in the table 'product.supplierinfo' which has a link to 'product.template' and NOT a 'product.product'. (See http://bazaar.launchpad.net/~openerp/openobject-addons/6.1/view/head:/purchase/purchase.py#L780 )

If you are not using product variants the error will not be easily spotted.

Note that this bug seemed to have fallen between test scenarios ?

Regression occurred in :
<email address hidden>

See original description

Tags:

Related branches

lp://staging/~openerp-dev/openobject-addons/6.1-opw-579011-rha

Ready for review for merging into lp://staging/openobject-addons/6.1

Naresh(OpenERP): Pending requested 2012-09-11

lp://staging/~yann-papouin/ocb-addons/6.1-bug-1048547-product-variant-supplierinfo-pricelist

Merged into lp://staging/ocb-addons/6.1 at revision 6833

Holger Brunn (Therp): Approve (code review) on 2014-02-10

Stefan Rijnhart (Opener): Approve on 2014-02-08

Pedro Manuel Baeza: Approve (code review) on 2014-02-06

Niels Huylebroeck (red15) on 2012-09-10

description:

updated

Revision history for this message

Niels Huylebroeck (red15) wrote on 2012-09-10:

fix-1048547.patch Edit (670 bytes, text/plain)

Attached is one way of solving the problem.

Vinay Rana (OpenERP) (vra-openerp) on 2012-09-10

Changed in openobject-addons:
assignee:	nobody → OpenERP Publisher's Warranty Team (openerp-opw)
tags:	added: maintenance

Rifakat Husen (OpenERP) (rha-openerp) on 2012-09-10

Changed in openobject-addons:
status:	New → Confirmed
importance:	Undecided → Low

Rifakat Husen (OpenERP) (rha-openerp) on 2012-09-11

Changed in openobject-addons:
status:	Confirmed → In Progress

Revision history for this message

Rifakat Husen (OpenERP) (rha-openerp) wrote on 2012-09-11:

Hello Niels,

Fixed in following branch,
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-579011-rha
r6984, Revision ID: <email address hidden>

Thanks for providing patch, appreciated!

Regards.

Changed in openobject-addons:
status:	In Progress → Fix Committed

Revision history for this message

Niels Huylebroeck (red15) wrote on 2012-10-22:

Not yet committed, updated status.

Changed in openobject-addons:
status:	Fix Committed → In Progress

Revision history for this message

Rifakat Husen (OpenERP) (rha-openerp) wrote on 2013-01-07:

Revision 6985, Revision ID: <email address hidden>

Changed in openobject-addons:
status:	In Progress → Fix Committed

Revision history for this message

Christophe Combelles (ccomb) wrote on 2013-01-30:

lp1048547.patch Edit (1.2 KiB, text/plain)

The provided patch is not enough to fix the bug.

- if you have a product_product whose id is different from the product_template
- you create a supplier info in the product's supplier tab
- you create a purchase order, select the product
=> the price is not correct.

the additional fix is to replace product_id with tmpl_id in product/pricelist.py:204

Attached is the full patch