OpenLP

Can't import webbible

Bug #1750447 reported by Simon Hanna
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Committed
Medium
Phill
OpenLP 2.9.1

Bug Description

Starting with on openlp configs or data, adding a couple of non-english bibles in FTW and then importing a new bible. I just downloaded the list and went with what was chosen.

Here's the trace
Traceback (most recent call last):
  File "/home/sim/dev/openlp/trunk/openlp/core/widgets/wizard.py", line 228, in on_current_id_changed
    self.perform_wizard()
  File "/home/sim/dev/openlp/trunk/openlp/plugins/bibles/forms/bibleimportform.py", line 794, in perform_wizard
    if importer.do_import(license_version) and not importer.stop_import_flag:
  File "/home/sim/dev/openlp/trunk/openlp/plugins/bibles/lib/importers/http.py", line 654, in do_import
    book_ref_id = self.get_book_ref_id_by_name(book, len(books), self.language_id)
  File "/home/sim/dev/openlp/trunk/openlp/core/common/mixins.py", line 67, in wrapped
    raise e
  File "/home/sim/dev/openlp/trunk/openlp/core/common/mixins.py", line 60, in wrapped
    return func(*args, **kwargs)
  File "/home/sim/dev/openlp/trunk/openlp/plugins/bibles/lib/bibleimport.py", line 77, in get_book_ref_id_by_name
    book_id = AlternativeBookNamesDB.get_book_reference_id(book)
  File "/home/sim/dev/openlp/trunk/openlp/plugins/bibles/lib/db.py", line 809, in get_book_reference_id
    'SELECT book_reference_id, name FROM alternative_book_names')
  File "/home/sim/dev/openlp/trunk/openlp/plugins/bibles/lib/db.py", line 790, in run_sql
    cursor.execute(query, parameters)
sqlite3.OperationalError: no such table: alternative_book_names

I'm attaching a log

Related branches

lp://staging/~phill-ridout/openlp/fixes-I
Tim Bentley: Pending requested
Diff: 1333 lines (+187/-208)
47 files modified
openlp/core/api/deploy.py (+2/-2)
openlp/core/app.py (+8/-4)
openlp/core/common/__init__.py (+2/-2)
openlp/core/common/path.py (+1/-1)
openlp/core/common/settings.py (+1/-1)
openlp/core/display/html/display.html (+1/-1)
openlp/core/display/html/display.js (+1/-1)
openlp/core/lib/__init__.py (+6/-8)
openlp/core/lib/db.py (+15/-11)
openlp/core/lib/mediamanageritem.py (+6/-6)
openlp/core/lib/serviceitem.py (+3/-3)
openlp/core/ui/advancedtab.py (+1/-1)
openlp/core/ui/exceptiondialog.py (+3/-3)
openlp/core/ui/exceptionform.py (+14/-7)
openlp/core/ui/generaltab.py (+0/-1)
openlp/core/ui/mainwindow.py (+1/-1)
openlp/core/ui/servicemanager.py (+13/-12)
openlp/core/ui/thememanager.py (+10/-10)
openlp/core/version.py (+1/-1)
openlp/core/widgets/edits.py (+1/-1)
openlp/core/widgets/wizard.py (+1/-41)
openlp/plugins/bibles/forms/bibleimportform.py (+2/-2)
openlp/plugins/bibles/lib/bibleimport.py (+2/-2)
openlp/plugins/bibles/lib/db.py (+6/-6)
openlp/plugins/bibles/lib/importers/wordproject.py (+1/-1)
openlp/plugins/bibles/lib/manager.py (+1/-1)
openlp/plugins/bibles/lib/mediaitem.py (+3/-3)
openlp/plugins/custom/lib/mediaitem.py (+3/-6)
openlp/plugins/images/lib/mediaitem.py (+3/-3)
openlp/plugins/media/lib/mediaitem.py (+7/-7)
openlp/plugins/presentations/lib/mediaitem.py (+3/-3)
openlp/plugins/presentations/lib/messagelistener.py (+2/-8)
openlp/plugins/songs/forms/songimportform.py (+7/-2)
openlp/plugins/songs/lib/importers/cclifile.py (+4/-3)
openlp/plugins/songs/lib/mediaitem.py (+2/-4)
openlp/plugins/songusage/forms/songusagedetailform.py (+2/-2)
run_openlp.py (+8/-2)
tests/functional/openlp_core/api/test_deploy.py (+2/-2)
tests/functional/openlp_core/common/test_init.py (+14/-8)
tests/functional/openlp_core/common/test_path.py (+3/-5)
tests/functional/openlp_core/lib/test_serviceitem.py (+4/-4)
tests/functional/openlp_core/ui/test_thememanager.py (+3/-3)
tests/functional/openlp_plugins/bibles/test_manager.py (+3/-2)
tests/interfaces/openlp_plugins/songs/forms/test_songmaintenanceform.py (+2/-2)
tests/openlp_core/common/test_network_interfaces.py (+1/-1)
tests/openlp_core/projectors/test_projector_pjlink_commands_01.py (+6/-6)
tests/openlp_core/projectors/test_projector_sourceform.py (+2/-2)
Revision history for this message
Simon Hanna (thelinuxguy) wrote :
Revision history for this message
Simon Hanna (thelinuxguy) wrote :

English bibles also result in an exception

It imports fine but then this happens
Traceback (most recent call last):
  File "/home/sim/dev/openlp/bible-improvements/openlp/plugins/bibles/lib/mediaitem.py", line 570, in on_version_combo_box_index_changed
    self.initialise_advanced_bible(self.select_book_combo_box.currentData())
  File "/home/sim/dev/openlp/bible-improvements/openlp/plugins/bibles/lib/mediaitem.py", line 390, in initialise_advanced_bible
    log.debug('initialise_advanced_bible {bible}, {ref}'.format(bible=self.bible.name, ref=last_book))
AttributeError: 'NoneType' object has no attribute 'name'

Phill (phill-ridout)
Changed in openlp:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Phill (phill-ridout)
Phill (phill-ridout)
Changed in openlp:
status: In Progress → Fix Committed
Tim Bentley (trb143)
Changed in openlp:
milestone: none → 2.9.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.