OpenLP

first time wizard crashes

Bug #1742910 reported by Simon Hanna on 2018-01-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenLP	Fix Committed	Critical	Raoul Snyman	OpenLP 2.9.1

Bug Description

Traceback (most recent call last):
  File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 307, in on_current_id_changed
    self._download_index()
  File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 260, in _download_index
    run_thread(worker, thread_name)
  File "/home/sim/dev/openlp/better-threading/openlp/core/threading.py", line 54, in run_thread
    if thread_name in main_window.threads:
AttributeError: 'NoneType' object has no attribute 'threads'

Using the better-threading branch, with no data or configs for OpenLP present in my home running on Archlinux.

Tags:

Related branches

lp://staging/~raoul-snyman/openlp/bug-1742910

Merged into lp://staging/openlp at revision 2808

Tim Bentley: Approve on 2018-01-13

Revision history for this message

Ken Roberts (alisonken1) wrote on 2018-01-12:

openlp.log from fedora 25 after deleting ~/.openlp ~/.config/OpenLP Edit (10.0 KiB, text/plain)

Confirmed on Fedora 25 as well.

tags:	added: threads
tags:	added: ftw
Changed in openlp:
importance:	Undecided → Critical

Revision history for this message

Simon Hanna (thelinuxguy) wrote on 2018-01-12:

The issue seems to be that the threads are all stored in the mainwindow which isn't always there.

If you run the first time wizard in the very beginning, no mainwindow exists.

So the threads should probably be attached to something that is created much earlier, before anything else is done, so it's guaranteed to be always there.

Raoul Snyman (raoul-snyman) on 2018-01-13