CSV bible import fails UnicodeDecodeError: '
Bug #1742390 reported by
Azaziah
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Low
|
Phill | ||
Bug Description
Traceback (most recent call last):
File "openlp\
File "openlp\
File "openlp\
File "C:\Python34-
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 1401: ordinal not in range(128)
Win 10, OLP 2.4.6, was trying to test this:
https:/
but the importer crashed, not sure if the same files were used...
Related branches
lp://staging/~phill-ridout/openlp/more-bible-refactors
- Raoul Snyman: Approve
- Tim Bentley: Approve
-
Diff: 2631 lines (+999/-1092)24 files modifiedopenlp/core/common/__init__.py (+22/-0)
openlp/core/lib/exceptions.py (+7/-1)
openlp/plugins/bibles/bibleplugin.py (+0/-42)
openlp/plugins/bibles/forms/__init__.py (+3/-21)
openlp/plugins/bibles/forms/bibleimportform.py (+1/-1)
openlp/plugins/bibles/forms/bibleupgradeform.py (+0/-575)
openlp/plugins/bibles/lib/bibleimport.py (+113/-0)
openlp/plugins/bibles/lib/db.py (+1/-136)
openlp/plugins/bibles/lib/importers/csvbible.py (+113/-100)
openlp/plugins/bibles/lib/importers/http.py (+5/-8)
openlp/plugins/bibles/lib/importers/opensong.py (+7/-26)
openlp/plugins/bibles/lib/importers/osis.py (+58/-79)
openlp/plugins/bibles/lib/importers/sword.py (+9/-10)
openlp/plugins/bibles/lib/importers/zefania.py (+19/-45)
openlp/plugins/bibles/lib/manager.py (+6/-7)
tests/functional/openlp_core_common/test_init.py (+64/-3)
tests/functional/openlp_plugins/bibles/test_bibleimport.py (+212/-0)
tests/functional/openlp_plugins/bibles/test_csvimport.py (+338/-17)
tests/functional/openlp_plugins/bibles/test_http.py (+6/-6)
tests/functional/openlp_plugins/bibles/test_opensongimport.py (+3/-3)
tests/functional/openlp_plugins/bibles/test_osisimport.py (+5/-5)
tests/functional/openlp_plugins/bibles/test_swordimport.py (+3/-3)
tests/functional/openlp_plugins/bibles/test_zefaniaimport.py (+3/-3)
tests/interfaces/openlp_plugins/bibles/test_lib_http.py (+1/-1)
Revision history for this message
| Azaziah (suutari-olli) wrote | #1 |
Revision history for this message
| Raoul Snyman (raoul-snyman) wrote | #2 |
Revision history for this message
| Phill (phill-ridout) wrote | #3 |
| Changed in openlp: | |
| status: | New → Fix Committed |
| importance: | Undecided → Low |
| assignee: | nobody → Phill (phill-ridout) |
| Changed in openlp: | |
| milestone: | none → 2.9.1 |
To post a comment you must log in.
It's not being told which encoding to decode from, so it presumes ascii. Even if we don't use chardet, we should at least ask it to decode from UTF-8.