OpenLP

Bibles plugin fails to load due to invalid "last search type" value

Bug #1695268 reported by Azaziah
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Committed
High
Azaziah
OpenLP 2.9.1

Bug Description

I just started 2.4.6 normally on win 10, but only "songs" were visible in Library. All of the plugins are activated in the plugin manager.

On closing the program, the following traceback appears:

Traceback (most recent call last):
  File "openlp\core\ui\mainwindow.py", line 1091, in closeEvent
  File "openlp\core\ui\mainwindow.py", line 1129, in clean_up
  File "openlp\core\lib\pluginmanager.py", line 189, in finalise_plugins
  File "C:\Program Files (x86)\OpenLP\plugins\bibles\bibleplugin.py", line 100, in finalise
    action_list.remove_action(self.import_bible_item, UiStrings().Import)
  File "openlp\core\utils\actions.py", line 300, in remove_action
  File "openlp\core\utils\actions.py", line 117, in remove
TypeError: 'QAction' object does not support indexing

The same traceback also appears when trying to de-activate the "Bible" plugin
(The status does not change, but combobox item does)

If trying to activate the plugin, the following traceback appears:

Traceback (most recent call last):
  File "openlp\core\ui\pluginform.py", line 136, in on_status_combo_box_changed
  File "openlp\core\lib\plugin.py", line 186, in toggle_status
  File "C:\Program Files (x86)\OpenLP\plugins\bibles\bibleplugin.py", line 84, in initialise
    super(BiblePlugin, self).initialise()
  File "openlp\core\lib\plugin.py", line 278, in initialise
  File "openlp\plugins\bibles\lib\mediaitem.py", line 319, in initialise
  File "openlp\core\common\settings.py", line 436, in value
TypeError: unable to convert a QVariant back to a Python object

Deleting the OpenLP data folder does not fix this issue.
The causes for this bug are still unclear, 2.4.6 used to work normally.

See original description

Related branches

lp://staging/~suutari-olli/openlp/azaziah-fixes-and-improvements
Tim Bentley: Approve
Raoul Snyman: Approve
Diff: 798 lines (+123/-66)
49 files modified
openlp/core/common/settings.py (+5/-1)
openlp/core/lib/searchedit.py (+2/-2)
openlp/core/lib/ui.py (+1/-0)
openlp/core/ui/__init__.py (+3/-3)
openlp/core/ui/aboutform.py (+2/-1)
openlp/core/ui/filerenameform.py (+2/-2)
openlp/core/ui/firsttimelanguageform.py (+2/-1)
openlp/core/ui/formattingtagform.py (+2/-1)
openlp/core/ui/lib/wizard.py (+5/-2)
openlp/core/ui/maindisplay.py (+1/-1)
openlp/core/ui/pluginform.py (+2/-1)
openlp/core/ui/printserviceform.py (+2/-2)
openlp/core/ui/projector/editform.py (+2/-1)
openlp/core/ui/projector/sourceselectform.py (+4/-2)
openlp/core/ui/serviceitemeditform.py (+2/-2)
openlp/core/ui/servicenoteform.py (+2/-2)
openlp/core/ui/settingsform.py (+2/-1)
openlp/core/ui/shortcutlistform.py (+2/-1)
openlp/core/ui/starttimeform.py (+2/-2)
openlp/plugins/alerts/forms/alertform.py (+2/-2)
openlp/plugins/bibles/bibleplugin.py (+1/-1)
openlp/plugins/bibles/forms/booknameform.py (+2/-1)
openlp/plugins/bibles/forms/editbibleform.py (+2/-1)
openlp/plugins/bibles/forms/languageform.py (+2/-1)
openlp/plugins/bibles/lib/__init__.py (+2/-2)
openlp/plugins/bibles/lib/mediaitem.py (+3/-1)
openlp/plugins/custom/customplugin.py (+1/-1)
openlp/plugins/custom/forms/editcustomform.py (+2/-1)
openlp/plugins/custom/forms/editcustomslideform.py (+2/-1)
openlp/plugins/images/forms/addgroupform.py (+2/-1)
openlp/plugins/images/forms/choosegroupform.py (+2/-1)
openlp/plugins/media/forms/mediaclipselectorform.py (+2/-1)
openlp/plugins/songs/forms/authorsform.py (+2/-1)
openlp/plugins/songs/forms/duplicatesongremovalform.py (+3/-0)
openlp/plugins/songs/forms/editsongform.py (+2/-1)
openlp/plugins/songs/forms/editverseform.py (+2/-1)
openlp/plugins/songs/forms/mediafilesform.py (+2/-1)
openlp/plugins/songs/forms/songbookform.py (+2/-1)
openlp/plugins/songs/forms/songmaintenancedialog.py (+1/-1)
openlp/plugins/songs/forms/songmaintenanceform.py (+2/-1)
openlp/plugins/songs/forms/songselectform.py (+2/-1)
openlp/plugins/songs/forms/topicsform.py (+2/-1)
openlp/plugins/songs/songsplugin.py (+1/-1)
openlp/plugins/songusage/forms/songusagedeleteform.py (+1/-1)
openlp/plugins/songusage/forms/songusagedetailform.py (+2/-1)
tests/functional/openlp_core_ui/test_maindisplay.py (+16/-1)
tests/functional/openlp_plugins/bibles/test_lib.py (+4/-1)
tests/functional/openlp_plugins/bibles/test_mediaitem.py (+7/-7)
tests/interfaces/openlp_core_lib/test_searchedit.py (+2/-2)
Revision history for this message
Azaziah (suutari-olli) wrote :
description: updated
Revision history for this message
Azaziah (suutari-olli) wrote :

Bibles data folder.

Revision history for this message
Azaziah (suutari-olli) wrote :

Log without any bibles in data folder

Azaziah (suutari-olli)
summary: - Bibles plugin fails to load and breaks the Library
+ Bibles plugin fails to load due to invalid "last search type" value
Revision history for this message
Azaziah (suutari-olli) wrote :

Note:

2.4.6 stores "last search type" as:
REG_DWORD (1/0) to registry.

Where as the problematic registry type was:
REG_BINARY instead of REG_DWORD.

Where did this invalid value come from?
Recent changes to trunk?

Revision history for this message
Phill (phill-ridout) wrote :

The value comes from line 250 of the diff at https://code.launchpad.net/~phill-ridout/openlp/saved_bible_verses/+merge/324674

This should only affect you if you go from a newer version of openlp to an older version, and as we don't support downgrading I'm going to set this as 'wont fix'

If you're downgrading for development purposes, its worth noting that you can use the -p argument when running openlp.py to run it in portable mode (on windows your settings will be stored in a ini file instead of the registry.

Changed in openlp:
status: New → Won't Fix
Azaziah (suutari-olli)
Changed in openlp:
status: Won't Fix → In Progress
assignee: nobody → Azaziah (suutari-olli)
Tim Bentley (trb143)
Changed in openlp:
status: In Progress → Fix Committed
milestone: none → 2.5.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.