OpenLP

Media Library duplicates on boot and when a new item is added

Bug #1672229 reported by Azaziah
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenLP
Fix Committed
Medium
Phill
OpenLP 2.9.1

Bug Description

In some cases OpenLP starts creating duplicates of all the items
in the Media Library on boot and when a new Media item is added.

This issue has been reported to be happening in 2.2 and 2.4.5
with Windows 10 (and 8?), but may not be limited to Windows.

https://forums.openlp.org/discussion/comment/9197/#Comment_9197
https://forums.openlp.org/discussion/3452/media-library-multiplies#latest

The causes of this bug are still unclear.

See original description

Related branches

lp://staging/~phill-ridout/openlp/fixes-mkII
Raoul Snyman: Pending requested
Tim Bentley: Pending requested
Diff: 1063 lines (+167/-143)
47 files modified
openlp/core/common/__init__.py (+21/-3)
openlp/core/common/applocation.py (+1/-1)
openlp/core/common/httputils.py (+4/-4)
openlp/core/common/i18n.py (+1/-1)
openlp/core/common/mixins.py (+14/-0)
openlp/core/common/path.py (+1/-1)
openlp/core/common/settings.py (+4/-1)
openlp/core/lib/__init__.py (+1/-1)
openlp/core/lib/mediamanageritem.py (+4/-2)
openlp/core/ui/exceptionform.py (+1/-1)
openlp/core/ui/formattingtagcontroller.py (+1/-1)
openlp/core/ui/mainwindow.py (+2/-2)
openlp/core/ui/servicemanager.py (+28/-28)
openlp/core/ui/thememanager.py (+3/-3)
openlp/core/version.py (+2/-2)
openlp/core/widgets/edits.py (+13/-3)
openlp/core/widgets/views.py (+1/-1)
openlp/plugins/bibles/forms/booknameform.py (+1/-2)
openlp/plugins/bibles/lib/__init__.py (+3/-3)
openlp/plugins/bibles/lib/db.py (+1/-2)
openlp/plugins/images/lib/mediaitem.py (+2/-1)
openlp/plugins/presentations/lib/pptviewcontroller.py (+1/-1)
openlp/plugins/songs/forms/editsongform.py (+3/-3)
openlp/plugins/songs/lib/__init__.py (+2/-3)
openlp/plugins/songs/lib/importers/easyslides.py (+2/-1)
openlp/plugins/songs/lib/importers/mediashout.py (+1/-1)
openlp/plugins/songs/lib/importers/openoffice.py (+2/-2)
openlp/plugins/songs/lib/importers/opensong.py (+2/-1)
openlp/plugins/songs/lib/importers/songimport.py (+2/-21)
openlp/plugins/songs/lib/importers/songsoffellowship.py (+0/-1)
openlp/plugins/songs/lib/importers/zionworx.py (+5/-15)
openlp/plugins/songs/lib/openlyricsxml.py (+1/-1)
openlp/plugins/songusage/forms/songusagedetailform.py (+8/-2)
openlp/plugins/songusage/songusageplugin.py (+6/-9)
tests/functional/openlp_core/common/test_actions.py (+1/-0)
tests/functional/openlp_core/common/test_httputils.py (+1/-1)
tests/functional/openlp_core/common/test_i18n.py (+1/-1)
tests/functional/openlp_core/common/test_path.py (+4/-4)
tests/functional/openlp_core/lib/test_lib.py (+1/-1)
tests/functional/openlp_core/ui/test_first_time.py (+1/-1)
tests/functional/openlp_core/widgets/test_views.py (+0/-1)
tests/functional/openlp_plugins/presentations/test_presentationcontroller.py (+1/-1)
tests/interfaces/openlp_core/ui/test_projectormanager.py (+1/-1)
tests/interfaces/openlp_core/ui/test_projectorsourceform.py (+1/-1)
tests/interfaces/openlp_core/ui/test_thememanager.py (+1/-1)
tests/utils/__init__.py (+1/-1)
tests/utils/test_pylint.py (+9/-5)
Azaziah (suutari-olli)
description: updated
description: updated
Azaziah (suutari-olli)
Changed in openlp:
importance: Undecided → Medium
Revision history for this message
Paul (penright) wrote :

Couple of notes.

Summary: I think it has to do with a certain number of medias stored or if there is more than will fit into a window and then you add one. I was able to reproduce the issue on 2.4.6.

Details: I downloaded 2.4.6 onto a new laptop. It only had a couple of video files and I added them one at a time while exiting, rerunning, then checking the media for duplicates. After repeating a few times and not seeing the issue, I notice it was 2.4.6 and my other laptop was 2.4.5 and I tried 2.4.2. So I thought oh, maybe it got fixed in 2.4.6, so I downloaded it to my "broke" laptop, ran it, when asked if I wanted to save database, I said yes, then I cleared out the duplicates. Exited and reran, no duplicates. Then I added one media, exited, reran, checked media. All existing duplicated, the new one did not. So now I thinking what is different between the two. Well number of media and where they are stored before I added them. So I copied them to a thumb drive and added to the "non-broke" laptop. Added a couple, everything ok. Added one at a time, till wham, it happen. I may be getting close to knowing how to replicate the bug. I need to spend more time but wanted to pass this along for the FYI.

Also, I am adding the media by selecting from the folder and dragging into the media window.

Revision history for this message
Paul (penright) wrote :

After posting the previous comment about dragging the slides, I went back and tested the same process only using the disk icon (Load new media). My first pass did NOT reproduce the issue.
So maybe it has to do with adding media by dragging from folder to media window and the number of entries when adding.

If this is a case then the workaround will be just to use the icon.

Curious, where is the entries stored? Is it a database or registry?

With this being Father's day weekend, it maybe Monday before I can do more testing.

Revision history for this message
Paul (penright) wrote :

Here is a log with the issue.
I had to rename it because you have to exit and re-run it to see the issue.
The name should help with the order. I just discovered I can only do one file, so I added them to a zip.

Revision history for this message
Paul (penright) wrote :

Here is a set of logs doing the same steps except with using icon (Load new media).
The issue was NOT reproduced.
Again this was successful.
I am sending this log so you can see the difference.

Phill (phill-ridout)
Changed in openlp:
assignee: nobody → Phill (phill-ridout)
status: New → In Progress
Phill (phill-ridout)
Changed in openlp:
status: In Progress → Fix Committed
Tim Bentley (trb143)
Changed in openlp:
milestone: none → 2.5.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.