OSZL is ignored on save (inconsistent gui)
Bug #1660473 reported by
Timothy Cooper
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Medium
|
Phill | ||
| 2.4 |
Fix Released
|
Medium
|
Tim Bentley | ||
Bug Description
Platform:
OS: Windows 10 Home
OpenLP: 2.4.4
Severity: Minor
What happened:
When a service file already designated as an .oszl file is saved using the File -> Save menu, it generates an .osz file (in size - the file is still named .oszl). This also happens when pressing Ctrl+S. This does NOT occur when clicking the "Save this service" button displayed under Service Manager. This does not cause any problems other than making the service file much larger than expected.
What I expected to happen:
I expected that a .oszl service file would continue to be saved as an .oszl file regardless of how I execute the Save File command.
Related branches
lp://staging/~trb143/openlp/fixes245
- Tomas Groth: Approve
- Raoul Snyman: Approve
-
Diff: 100 lines (+48/-31)2 files modifiedopenlp/core/ui/mainwindow.py (+1/-1)
tests/functional/openlp_core_ui/test_aboutform.py (+47/-30)
lp://staging/~phill-ridout/openlp/fixes-mkII
- Raoul Snyman: Pending requested
- Tim Bentley: Pending requested
-
Diff: 1063 lines (+167/-143)47 files modifiedopenlp/core/common/__init__.py (+21/-3)
openlp/core/common/applocation.py (+1/-1)
openlp/core/common/httputils.py (+4/-4)
openlp/core/common/i18n.py (+1/-1)
openlp/core/common/mixins.py (+14/-0)
openlp/core/common/path.py (+1/-1)
openlp/core/common/settings.py (+4/-1)
openlp/core/lib/__init__.py (+1/-1)
openlp/core/lib/mediamanageritem.py (+4/-2)
openlp/core/ui/exceptionform.py (+1/-1)
openlp/core/ui/formattingtagcontroller.py (+1/-1)
openlp/core/ui/mainwindow.py (+2/-2)
openlp/core/ui/servicemanager.py (+28/-28)
openlp/core/ui/thememanager.py (+3/-3)
openlp/core/version.py (+2/-2)
openlp/core/widgets/edits.py (+13/-3)
openlp/core/widgets/views.py (+1/-1)
openlp/plugins/bibles/forms/booknameform.py (+1/-2)
openlp/plugins/bibles/lib/__init__.py (+3/-3)
openlp/plugins/bibles/lib/db.py (+1/-2)
openlp/plugins/images/lib/mediaitem.py (+2/-1)
openlp/plugins/presentations/lib/pptviewcontroller.py (+1/-1)
openlp/plugins/songs/forms/editsongform.py (+3/-3)
openlp/plugins/songs/lib/__init__.py (+2/-3)
openlp/plugins/songs/lib/importers/easyslides.py (+2/-1)
openlp/plugins/songs/lib/importers/mediashout.py (+1/-1)
openlp/plugins/songs/lib/importers/openoffice.py (+2/-2)
openlp/plugins/songs/lib/importers/opensong.py (+2/-1)
openlp/plugins/songs/lib/importers/songimport.py (+2/-21)
openlp/plugins/songs/lib/importers/songsoffellowship.py (+0/-1)
openlp/plugins/songs/lib/importers/zionworx.py (+5/-15)
openlp/plugins/songs/lib/openlyricsxml.py (+1/-1)
openlp/plugins/songusage/forms/songusagedetailform.py (+8/-2)
openlp/plugins/songusage/songusageplugin.py (+6/-9)
tests/functional/openlp_core/common/test_actions.py (+1/-0)
tests/functional/openlp_core/common/test_httputils.py (+1/-1)
tests/functional/openlp_core/common/test_i18n.py (+1/-1)
tests/functional/openlp_core/common/test_path.py (+4/-4)
tests/functional/openlp_core/lib/test_lib.py (+1/-1)
tests/functional/openlp_core/ui/test_first_time.py (+1/-1)
tests/functional/openlp_core/widgets/test_views.py (+0/-1)
tests/functional/openlp_plugins/presentations/test_presentationcontroller.py (+1/-1)
tests/interfaces/openlp_core/ui/test_projectormanager.py (+1/-1)
tests/interfaces/openlp_core/ui/test_projectorsourceform.py (+1/-1)
tests/interfaces/openlp_core/ui/test_thememanager.py (+1/-1)
tests/utils/__init__.py (+1/-1)
tests/utils/test_pylint.py (+9/-5)
| Changed in openlp: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in openlp: | |
| assignee: | nobody → Phill (phill-ridout) |
| status: | Confirmed → In Progress |
| Changed in openlp: | |
| status: | In Progress → Fix Committed |
| Changed in openlp: | |
| milestone: | none → 2.5.1 |
To post a comment you must log in.
