OpenLP

Live media restarts when adding media to servicemanager

Bug #1463286 reported by Tomas Groth
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenLP
Fix Committed
Medium
Tim Bentley
OpenLP 2.9.1

Bug Description

Live media restarts when adding media to servicemanager.

Confirmed in OpenLP 2.1.5 on Windows 8.1 using VLC as media player, though it probably applies to other setups as well.

Related branches

lp://staging/~trb143/openlp/mediafixes22
lp://staging/~trb143/openlp/media_timer2
Raoul Snyman: Approve
Diff: 234 lines (+95/-25)
5 files modified
openlp/core/common/__init__.py (+30/-0)
openlp/core/ui/media/mediacontroller.py (+1/-1)
openlp/plugins/media/mediaplugin.py (+31/-1)
openlp/plugins/presentations/lib/pdfcontroller.py (+6/-22)
tests/functional/openlp_plugins/media/test_mediaplugin.py (+27/-1)
Revision history for this message
Tomas Groth (tomasgroth) wrote :

The problem is that in plugins/media/media_item.py:generate_slide_data we want to get the media length, and we do this by playing the media for a very short while to get the player to load the media, and then the length can be extracted. Unfortunately we only have one player instance, which means we use the same player instance for the length-detection and for playing the live-media. So this bug is kind of dependent on fixing bug #1022053 .

Revision history for this message
Tomas Groth (tomasgroth) wrote :

Reported in the forum: http://forums.openlp.org/discussion/2651/live-video-restarts-itself-when-adding-a-new-item-to-the-service-manager-v-2-1-5

This is not an issue in 2.0.5.

Revision history for this message
Tim Bentley (trb143) wrote :

Need to look at the code.
Refactored in 2.2 as there were many issues in 2.0.
Looks like the change to the Registry may have changed the original implementation as there were meant to be 3 media controller instances.

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Can we not just create a media player instance when we do this? Also, is there not some other way to get the media length, like looking at media file headers? It may mean adding another library to OpenLP, but I'd rather do that than our current hack, to be honest.

Revision history for this message
Tim Bentley (trb143) wrote :

The info is only available via API calls which are populated only when play is pressed.

Revision history for this message
Tomas Groth (tomasgroth) wrote :

We could have a look at hachoir3: https://bitbucket.org/haypo/hachoir3
It seems to be pure python

Tim Bentley (trb143)
Changed in openlp:
assignee: nobody → Tim Bentley (trb143)
status: Confirmed → In Progress
Tim Bentley (trb143)
Changed in openlp:
milestone: none → 2.5.2
milestone: 2.5.2 → 2.5.1
status: In Progress → Fix Committed
Revision history for this message
Aj (ajboy04-v) wrote :

Any new info on this bug fix?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.