Can't clear preview pane
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Committed
|
Wishlist
|
Tim Bentley |
Bug Description
Version 1.9.9 (Windows XP Home)
Basically, I miss a feature from the older 1.x versions wherein it was possible to clear the preview pane. I often accidentally preview something, and then to have it staying on the screen with no way to remove it easily can be distracting. Furthermore, some of our less experienced operators get confused by it, and try to change the verses there instead of in the live pane.
I realise it is possible to just hide the preview pane, but I'd rather just be able to clear it.
I also see a good argument for it clearing itself after either going live with it or adding it to the service. I think this is a natural thing that you preview something and then you take an action based on that.
1) Go live. If it's live, it doesn't need to be in the preview pane any longer, since it's now in the Live pane. It should basically just "hop across".
2) Add to service: The user has decided that they want this song, and so they add it to the service. They are probably finished previewing the song, so I think it's safe to clear the preview (and users will become accustomed to this).
3) Just clear the preview. It wasn't the song you wanted, you're done searching for songs, etc, you just want it out of the way.
4) Edit the item. You preview it and decide it needs some changes, you make the changes and then you'll want to preview those changes. After which you'll again probably want to do one of action 1/2/3/4.
Related branches
- Raoul Snyman: Approve
-
Diff: 709 lines (+161/-60)18 files modifiedopenlp/core/api/endpoint/controller.py (+3/-3)
openlp/core/common/__init__.py (+8/-8)
openlp/core/lib/serviceitem.py (+8/-1)
openlp/core/ui/firsttimewizard.py (+0/-14)
openlp/core/ui/media/mediacontroller.py (+0/-1)
openlp/core/ui/servicemanager.py (+4/-12)
openlp/core/ui/slidecontroller.py (+20/-6)
openlp/core/ui/thememanager.py (+2/-2)
openlp/core/widgets/toolbar.py (+11/-5)
openlp/core/widgets/views.py (+9/-2)
openlp/plugins/custom/lib/mediaitem.py (+24/-0)
openlp/plugins/songs/lib/db.py (+1/-1)
openlp/plugins/songs/lib/mediaitem.py (+29/-0)
openlp/plugins/songs/lib/songstab.py (+11/-0)
openlp/plugins/songs/songsplugin.py (+1/-0)
scripts/websocket_client.py (+1/-0)
tests/functional/openlp_core/api/endpoint/test_controller.py (+25/-3)
tests/functional/openlp_plugins/songs/test_mediaitem.py (+4/-2)
Changed in openlp: | |
importance: | Undecided → Wishlist |
status: | New → Confirmed |
Changed in openlp: | |
milestone: | none → 2.1.0 |
Changed in openlp: | |
milestone: | 2.0 → none |
Changed in openlp: | |
status: | Confirmed → In Progress |
assignee: | nobody → Tim Bentley (trb143) |
Changed in openlp: | |
status: | In Progress → Fix Committed |
milestone: | none → 2.9.1 |