OpenContrail

[Windows docker] common/ package useless

Bug #1790655 reported by Michał Kostrzewa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Undecided
Unassigned
Juniper Openstack r5.1.0
OpenContrail
Fix Committed
Undecided
Unassigned

Bug Description

common/ package in windows docker driver is useless and needs to be refactored.

Tags: windows
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/45962
Submitter: Michal Kostrzewa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45962
Committed: http://github.com/Juniper/contrail-windows-docker-driver/commit/236d7ab6a9cb9027cef156b962eaedc26f1895ba
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 236d7ab6a9cb9027cef156b962eaedc26f1895ba
Author: Michal Kostrzewa <email address hidden>
Date: Tue Sep 4 16:25:26 2018 +0200

Get rid of package common.

This package originally contained code shared between different
packages. Turns out, the code wasn't really that common.

All the constants and functions were moved to better-suited packages.

Changes:
* get rid of type AdapterName string. It was useless and wasn't used
consistently.
* move CNM API handler functions to separate file in cnm package. This
differentiates them from named pipe, docker plugin and listener setup.
* distribute constants and functions from common/ package to different
packages.

Change-Id: I4f2262b723f1e23a66fdd2b242ccb40516a28532
Closes-Bug: #1790655

Michał Kostrzewa (mkostrzewa)
Changed in opencontrail:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.