no check for outstanding non-approved revisions in MP

Bug #1699842 reported by Samuele Pedroni
This bug affects 2 people
Affects Status Importance Assigned to Milestone

Bug Description

A MP* was mistakenly landed without the last revision that was pushed to it, this might have been because of a stale page in the browser or unclear LP slowness. Either way it seems our old tool had checks to prevent this. From IRC:

<nessita> pedronis, I've got that many times. If you approve at an older version, with tarmac there were 2 scenarios: 1- the were new revnos already push, tarmac would bail saying "there are more revnos than those approved"
<nessita> with the new lander, I'm not 100% sure
<sparkiegeek> a quick perusal of the code suggests it will not complain


originally only 138 was landed

description: updated
Revision history for this message
Facundo Batista (facundo) wrote :

Set importance to high as when this happens code is dropped inadvertently.

Changed in ols-jenkaas:
importance: Undecided → High
Revision history for this message
Colin Watson (cjwatson) wrote :

It's not a full fix for this, but I proposed to at least log the approved revision, to make it slightly less utterly opaque what's going on.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.