dell_wmi: Unknown key codes

This change was made by a bot.

Would it be possible for you to test the latest upstream kernel? Refer to https://wiki.ubuntu.com/KernelMainlineBuilds . Please test the latest v4.16 kernel[0].

If this bug is fixed in the mainline kernel, please add the following tag 'kernel-fixed-upstream'.

If the mainline kernel does not fix this bug, please add the tag: 'kernel-bug-exists-upstream'.

Once testing of the upstream kernel is complete, please mark this bug as "Confirmed".

Thanks in advance.

[0] http://kernel.ubuntu.com/~kernel-ppa/mainline/v4.16

According to https://github.com/torvalds/linux/blob/master/drivers/platform/x86/dell-wmi.c this key isn't supported by kernel.
To add support record { KE_IGNORE, 0xe008, { KEY_RFKILL } } must be added to array dell_wmi_keymap_type_0010. Right now it exists only in dell_wmi_keymap_type_0000.

Here is a piece of kern.log on mainline kernel 4.16.2:
Apr 13 12:35:07 dmig-Inspiron-5379 kernel: [ 1597.752396]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:07 dmig-Inspiron-5379 kernel: [ 1598.160367]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:08 dmig-Inspiron-5379 kernel: [ 1598.461929]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:08 dmig-Inspiron-5379 kernel: [ 1598.731117]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:08 dmig-Inspiron-5379 kernel: [ 1598.990486]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:09 dmig-Inspiron-5379 kernel: [ 1599.287094]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:09 dmig-Inspiron-5379 kernel: [ 1599.556158]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:09 dmig-Inspiron-5379 kernel: [ 1599.812597]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:09 dmig-Inspiron-5379 kernel: [ 1600.109678]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:10 dmig-Inspiron-5379 kernel: [ 1600.373923]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:10 dmig-Inspiron-5379 kernel: [ 1600.650719]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:10 dmig-Inspiron-5379 kernel: [ 1600.900744]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed Apr 13 12:35:10 dmig-Inspiron-5379 kernel: [ 1601.149327]dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed

Did you see this after you pressed the wireless hotkey? Or did it just happen out of nowhere?

Ok it actually happens to all Dell machines I tested.
Also I can see your systemd's hwdb commit to fix the issue. I'll update your change to make it apply to all dell machines.

I found one more missing key definition: FN-Lock key - Lock icon with 'Fn' on it, it toggles Fn row behavior between F1-F12 and media keys. I'm not sure with keycode it should have assigned, so I set it to IGNORE in patch.

I can observe the same issue on several Dell systems with Linux kernel v4.4. I didn't test older kernel though.

It should be handled by the kernel instead of udevd's hwdb.

Does !wlan in hwdb necessary to make the wireless hotkey to work?
Anyway this is not the correct solution, the "!" is to send a release key for buggy keyboard, but 0xe008 we see here is just a "notification" instead of a real key press.

Rfkill key produces 2 events: keyboard and one, that should be handled by dell-wmi.

Hwdb record is for keyboard event. Release emulation is required, at least for my model. Otherwise evtest shows only 1 EV_KEY event.

There are actually two different bugs:

- Wireless hotkey doesn't work:
It's a bug in GNOME. You can try KDE and you'll see it works just fine.
So the udevd hwdb is not necessary.

- Annoying "unknown keycodes"
Both wireless hotkey and Fn/Multimedia hotkey "key codes" are for notification.
We need to add these two keys to the table.

It should be this bug:
https://bugzilla.gnome.org/show_bug.cgi?id=788683

I can observe the same behavior, wireless hotkey works under GDM but not after login.

I can confirm the "!" release is required.

Enough guessing. Gnome bug is a different one. And it has no connection to this bug.

In my case rfkill didn't work because keycode 88 was set to UNKNOWN by this generic dell rule: https://github.com/systemd/systemd/blob/c5896b6a8cfcfd1b94f25450a96a1411384f1108/hwdb/60-keyboard.hwdb#L267

My rule https://github.com/systemd/systemd/blob/c5896b6a8cfcfd1b94f25450a96a1411384f1108/hwdb/60-keyboard.hwdb#L303-L305 was accepted and it is a correct solution, because it refines key code for exact model.

This is the same one as the Gnome bug.

Please check the commit message in https://github.com/systemd/systemd/pull/8762.

The attachment "This is a patch to dell-wmi.c kernel module adding 2 new key definitions" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

Attached deb patch for bionic

Hello Dmitriy, or anyone else affected,

Accepted systemd into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/237-3ubuntu10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

I verified the udev -proposed on Dell Inspiron 5767 machine and it works fine. Change tag to verification-done-bionic. Thanks.

Hello Dmitriy, or anyone else affected,

Accepted systemd into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/237-3ubuntu10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

This patch set is still present, and is operating as expected in 237-3ubuntu10.2

This bug was fixed in the package systemd - 237-3ubuntu10.2

---------------
systemd (237-3ubuntu10.2) bionic; urgency=medium

  * logind: backport v238/v239 fixes for handling DRM devices.
    These changes introduce all the fixes that correct handling of open fd's
    related to the DRM devices, as used by for example NVIDIA GPUs. This backport
    includes some refactoring, corrections, and comment updates. This to insure
    that correct history is preserved, code comments match reality, and to ease
    backporting logind fixes in the future SRUs. (LP: #1777099)
  * Disable dh_installinit generation of tmpfiles for the systemd package.
    Replace with a manual safe call to systemd-tmpfiles which will process any
    updates to the tmpfiles shipped by systemd package, taking into account any
    overrides shipped by other packages, sysadmin, or specified in the runtime
    directories. (LP: #1748147)

systemd (237-3ubuntu10.1) bionic; urgency=medium

  [ Dimitri John Ledkov ]
  * hwdb: Fix wlan/rfkill keycode on Dell systems. (LP: #1762385)
  * Cherrypick upstream fix for corrected detection of Virtualbox & Xen.
    (LP: #1768104)
  * Further improve captive portal workarounds.
    Retry any NXDOMAIN results with lower feature levels, instead of just those
    with 'secure' in the domain name. (LP: #1766969)

  [ Michael Biebl ]
  * Add dependencies of libsystemd-shared to Pre-Depends.
    This is necessary so systemctl is functional at all times during a
    dist-upgrade. (Closes: #897986) (LP: #1771791)

  [ Mario Limonciello ]
  * Fix hibernate disk offsets.
    Configure resume offset via sysfs, to enable resume from a swapfile.
    (LP: #1760106)

 -- Dimitri John Ledkov 🌈 <email address hidden> Fri, 22 Jun 2018 13:55:09 +0100

The verification of the Stable Release Update for systemd has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package systemd - 239-7ubuntu4

---------------
systemd (239-7ubuntu4) cosmic; urgency=medium

  * Workaround broken meson copying symlinked data files, as dangling symlinks.

 -- Dimitri John Ledkov <email address hidden> Wed, 22 Aug 2018 14:11:35 +0100

This bug was fixed in the package linux - 4.15.0-36.39

---------------
linux (4.15.0-36.39) bionic; urgency=medium

  * CVE-2018-14633
    - iscsi target: Use hex2bin instead of a re-implementation

  * CVE-2018-17182
    - mm: get rid of vmacache_flush_all() entirely

linux (4.15.0-35.38) bionic; urgency=medium

  * linux: 4.15.0-35.38 -proposed tracker (LP: #1791719)

  * device hotplug of vfio devices can lead to deadlock in vfio_pci_release
    (LP: #1792099)
    - SAUCE: vfio -- release device lock before userspace requests

  * L1TF mitigation not effective in some CPU and RAM combinations
    (LP: #1788563)
    - x86/speculation/l1tf: Fix overflow in l1tf_pfn_limit() on 32bit
    - x86/speculation/l1tf: Fix off-by-one error when warning that system has too
      much RAM
    - x86/speculation/l1tf: Increase l1tf memory limit for Nehalem+

  * CVE-2018-15594
    - x86/paravirt: Fix spectre-v2 mitigations for paravirt guests

  * CVE-2017-5715 (Spectre v2 s390x)
    - KVM: s390: implement CPU model only facilities
    - s390: detect etoken facility
    - KVM: s390: add etoken support for guests
    - s390/lib: use expoline for all bcr instructions
    - s390: fix br_r1_trampoline for machines without exrl
    - SAUCE: s390: use expoline thunks for all branches generated by the BPF JIT

  * Ubuntu18.04.1: cpuidle: powernv: Fix promotion from snooze if next state
    disabled (performance) (LP: #1790602)
    - cpuidle: powernv: Fix promotion from snooze if next state disabled

  * Watchdog CPU:19 Hard LOCKUP when kernel crash was triggered (LP: #1790636)
    - powerpc: hard disable irqs in smp_send_stop loop
    - powerpc: Fix deadlock with multiple calls to smp_send_stop
    - powerpc: smp_send_stop do not offline stopped CPUs
    - powerpc/powernv: Fix opal_event_shutdown() called with interrupts disabled

  * Security fix: check if IOMMU page is contained in the pinned physical page
    (LP: #1785675)
    - vfio/spapr: Use IOMMU pageshift rather than pagesize
    - KVM: PPC: Check if IOMMU page is contained in the pinned physical page

  * Missing Intel GPU pci-id's (LP: #1789924)
    - drm/i915/kbl: Add KBL GT2 sku
    - drm/i915/whl: Introducing Whiskey Lake platform
    - drm/i915/aml: Introducing Amber Lake platform
    - drm/i915/cfl: Add a new CFL PCI ID.

  * CVE-2018-15572
    - x86/speculation: Protect against userspace-userspace spectreRSB

  * Support Power Management for Thunderbolt Controller (LP: #1789358)
    - thunderbolt: Handle NULL boot ACL entries properly
    - thunderbolt: Notify userspace when boot_acl is changed
    - thunderbolt: Use 64-bit DMA mask if supported by the platform
    - thunderbolt: Do not unnecessarily call ICM get route
    - thunderbolt: No need to take tb->lock in domain suspend/complete
    - thunderbolt: Use correct ICM commands in system suspend
    - thunderbolt: Add support for runtime PM

  * random oopses on s390 systems using NVMe devices (LP: #1790480)
    - s390/pci: fix out of bounds access during irq setup

  * [Bionic] Spectre v4 mitigation (Speculative Store Bypass Disable) support
    for arm64 using SMC firmware call to set a hardware chicken bit
    (LP: #1787993) // CVE-2018...

Hello Dmitriy, or anyone else affected,

Accepted systemd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/229-4ubuntu21.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Tested xenial live session with stock systemd/udev and upgraded one from proposed. My dell laptop is not affected by this issue. But at least rfkill keys still work for me with both old and new systemd/udevd and there are no error messages in dmesg.

Thank you for checking that this doesn't introduce a regression on unaffected hardware.

Note that we don't currently have a verification for the actual reason this is being SRU'd, which is "rfkill keyboard shortcuts not working as intended on some Dell machines".

Either this change will make the rfkill button work (good), or not (current behaviour). Given the code paths, validating similar SKUs for non-regression is a good enough confidence level that this change doesn't regress other/unrelated machines. It's a low risk to accept this change as is, because the worst case scenario is a no-change in behaviour. The upside is that it may have fixed rfkill button.

Also if this change doesn't fix the rfkill buttons on these laptops, it would imply that later releases and upstream master are also still broken and unfixed.

Thanks. I think that's sufficient justification.

This bug was fixed in the package systemd - 229-4ubuntu21.5

---------------
systemd (229-4ubuntu21.5) xenial; urgency=medium

  [ Dimitri John Ledkov ]
  * systemctl: correctly proceed to immediate shutdown if scheduling fails
    (LP: #1670291)
  * hwdb: update micmute on Dell laptops. (LP: #1738153)
  * hwdb: Use wlan keycode for all Dell systems. (LP: #1762385)
  * units: Disable journald Watchdog (LP: #1773148)

  [ Mauricio Faria de Oliveira ]
  * core: Fix for service to enter the 'failed' state (rather than 'inactive') after it repeatedly fails restart.
    (LP: #1795658)

  [ Dimitri John Ledkov ]
  * Disable dh_installinit generation of tmpfiles for the systemd package.
    (LP: #1748147)

 -- Dimitri John Ledkov <email address hidden> Mon, 08 Oct 2018 16:10:42 +0100

I still get this error in Cosmic on a Dell M6500.

The M6500 does not have a keyboard RFKILL shortcut - in only has a physical switch. That switch correctly enables/disables WiFi.

Is this the same bug?

Dec 18 09:04:28 localhost kernel: [ 2706.037523] dell_wmi: Unknown key with type 0x0011 and code 0xffd0 pressed
Dec 18 09:04:28 localhost kernel: [ 2706.037526] dell_wmi: Unknown key with type 0x0011 and code 0xffd1 pressed
Dec 18 09:04:28 localhost kernel: [ 2706.037527] dell_wmi: Unknown key with type 0x0011 and code 0xffd0 pressed

Note that I never use the Fn-keys, so I have no idea which key(s) it would be complaining about.

$ uname -a
Linux DellLaptop 4.18.0-12-generic #13-Ubuntu SMP Wed Nov 14 15:17:05 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

$ cat os-release
NAME="Ubuntu"
VERSION="18.10 (Cosmic Cuttlefish)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.10"
VERSION_ID="18.10"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=cosmic
UBUNTU_CODENAME=cosmic

Here is the output from using the physical switch:

Dec 18 11:24:13 localhost kernel: [11090.779775] atkbd serio0: Unknown key pressed (translated set 2, code 0x88 on isa0060/serio0).
Dec 18 11:24:13 localhost kernel: [11090.779781] atkbd serio0: Use 'setkeycodes e008 <keycode>' to make it known.
Dec 18 11:24:13 localhost kernel: [11090.779888] iwlwifi 0000:0c:00.0: RF_KILL bit toggled to disable radio.
Dec 18 11:24:13 localhost kernel: [11090.779899] iwlwifi 0000:0c:00.0: reporting RF_KILL (radio disabled)
Dec 18 11:24:13 localhost kernel: [11090.780076] wlp12s0: deauthenticating from 24:b6:57:f9:c6:9e by local choice (Reason: 3=DEAUTH_LEAVING)
Dec 18 11:24:13 localhost kernel: [11090.780986] iwlwifi 0000:0c:00.0: Not sending command - RF KILL
Dec 18 11:24:13 localhost kernel: [11090.780991] wlp12s0: HW problem - can not stop rx aggregation for 24:b6:57:f9:c6:9e tid 0
Dec 18 11:24:13 localhost kernel: [11090.781003] iwlwifi 0000:0c:00.0: Not sending command - RF KILL
Dec 18 11:24:13 localhost kernel: [11090.781011] wlp12s0: HW problem - can not stop rx aggregation for 24:b6:57:f9:c6:9e tid 1
Dec 18 11:24:13 localhost kernel: [11090.781019] iwlwifi 0000:0c:00.0: Not sending command - RF KILL
Dec 18 11:24:13 localhost kernel: [11090.781023] wlp12s0: HW problem - can not stop rx aggregation for 24:b6:57:f9:c6:9e tid 2
Dec 18 11:24:13 localhost kernel: [11090.781028] iwlwifi 0000:0c:00.0: Not sending command - RF KILL
Dec 18 11:24:13 localhost kernel: [11090.781031] wlp12s0: HW problem - can not stop rx aggregation for 24:b6:57:f9:c6:9e tid 3
Dec 18 11:24:13 localhost kernel: [11090.781197] iwlwifi 0000:0c:00.0: Not sending command - RF KILL
Dec 18 11:24:13 localhost kernel: [11090.781202] wlp12s0: failed to remove key (0, 24:b6:57:f9:c6:9e) from hardware (-5)
Dec 18 11:24:13 localhost kernel: [11090.781359] iwlwifi 0000:0c:00.0: Not sending command - RF KILL
Dec 18 11:24:13 localhost kernel: [11090.781366] iwlwifi 0000:0c:00.0: Not sending command - RF KILL
Dec 18 11:24:13 localhost kernel: [11090.781378] iwl...