l10n_be_invoice_bba : structured communication checked on all invoiced

Bug #1206852 reported by Houssine
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Committed
Low
OpenERP Publisher's Warranty Team
OpenERP Community Backports (Addons)
Status tracked in 7.0
7.0
Fix Committed
Low
Unassigned

Bug Description

Hi,

I'm facing a bug with the l10n_be_invoice_bba module.

The problem is that the uniq constaint on structered communication is checked on the whole set of invoices without distinction on the type of invoice : Customer or Supplier invoice... In fact, the structured communication uniq constraint of an invoice should only be check on the same type of invoice. For example, the structured communication should only be checked on customer invoices if I'm filling in a Customer invoice and on supplier invoices if i'm filling in a supplier invoice.

In addition of that, for a supplier invoice, the structured communication uniq constraint should only be check on the supplier invoice of the same supplier as two different suppliers could possibly give an invoice with the same structured communication. This probability should not happen anyway this is the good way to check this constraint.

You can go from a empty database and install this module create a customer invoice with struct comm and create a supplier invoice with the same struct comm.

Thanks for your help,
Houssine

Tags: maintenance

Related branches

Changed in openobject-addons:
assignee: nobody → OpenERP Publisher's Warranty Team (openerp-opw)
tags: added: maintenance
Revision history for this message
Peter Langenberg (peter-langenberg) wrote : Re: [Bug 1206852] Re: l10n_be_invoice_bba : structured communication checked on all invoiced

Keep also in mind the multicompany aspect !

2013/7/31 Vinay Rana (OpenERP) <email address hidden>

> ** Changed in: openobject-addons
> Assignee: (unassigned) => OpenERP Publisher's Warranty Team
> (openerp-opw)
>
> ** Tags added: maintenance
>
> --
> You received this bug notification because you are subscribed to OpenERP
> Addons.
> https://bugs.launchpad.net/bugs/1206852
>
> Title:
> l10n_be_invoice_bba : structured communication checked on all
> invoiced
>
> Status in OpenERP Addons (modules):
> New
>
> Bug description:
> Hi,
>
> I'm facing a bug with the l10n_be_invoice_bba module.
>
> The problem is that the uniq constaint on structered communication is
> checked on the whole set of invoices without distinction on the type
> of invoice : Customer or Supplier invoice... In fact, the structured
> communication uniq constraint of an invoice should only be check on
> the same type of invoice. For example, the structured communication
> should only be checked on customer invoices if I'm filling in a
> Customer invoice and on supplier invoices if i'm filling in a supplier
> invoice.
>
> In addition of that, for a supplier invoice, the structured
> communication uniq constraint should only be check on the supplier
> invoice of the same supplier as two different suppliers could possibly
> give an invoice with the same structured communication. This
> probability should not happen anyway this is the good way to check
> this constraint.
>
> You can go from a empty database and install this module create a
> customer invoice with struct comm and create a supplier invoice with
> the same struct comm.
>
> Thanks for your help,
> Houssine
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1206852/+subscriptions
>

Revision history for this message
Houssine (houssine-bakkali) wrote :

thanks again for your good job Pinakin!

Changed in ocb-addons:
status: New → Fix Committed
importance: Undecided → Low
Changed in openobject-addons:
assignee: OpenERP Publisher's Warranty Team (openerp-opw) → nobody
assignee: nobody → OpenERP Publisher's Warranty Team (openerp-opw)
status: New → Fix Committed
importance: Undecided → Low
Revision history for this message
Houssine (houssine-bakkali) wrote :

Hi Guys,

could we have some progress getting this merged please? Anything blocking somewhere?

We need this to be merged for releasing at customer site!

Thanks
Houssine

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.