OpenERP Community Backports (Addons)

[6.0][6.1][7.0][trunk][sale] Sale exception: Recreate Packing duplicates confirmed moves

Series 6.1
Bug #947838

Bug #947838 reported by Numérigraphe on 2012-03-06

This bug affects 3 people

	Status	Importance	Assigned to
Odoo Addons (MOVED TO GITHUB)	Confirmed	Medium	OpenERP R&D Addons Team 3
OpenERP Community Backports (Addons)	Status tracked in 7.0
6.1	Fix Committed	Low	Yann Papouin
7.0	Confirmed	Low	Unassigned

Bug Description

When delivering a sale order:
- confirm the picking
- cancel a single stock move
=> the sale order eventually goes into "exception" state (normal: 1 move canceled = 1 procurement canceled = sale exception).
But when you click "recreate packing", a new picking will be created with :
- a new version of the canceled move
- AND a new version of the confirmed moves
The confirmed moves and the related procurements get duplicated, resulting in goods being purchased/manufactured twice, and sent twice to the customer.
Lionel Sausin.

See original description

Tags:

Related branches

lp://staging/~numerigraphe/openobject-addons/6.1-sale-exception-duplicate-moves

Ready for review for merging into lp://staging/openobject-addons/6.1

OpenERP Core Team: Pending requested 2012-11-13

lp://staging/~numerigraphe/openobject-addons/6.0-sale-exception-duplicate-moves

Ready for review for merging into lp://staging/openobject-addons/6.0

OpenERP Core Team: Pending requested 2012-11-13

lp://staging/~yann-papouin/ocb-addons/6.1-bug-947838-sale-recreate-packing-duplicates

Ready for review for merging into lp://staging/ocb-addons/6.1

Holger Brunn (Therp): Approve (code review) on 2014-01-27

Numérigraphe (numerigraphe) on 2012-03-06

description:	updated
summary:	- Sale exception: recreate packing ignores confirmed moves + Sale exception: recreate packing duplicates confirmed moves

Revision history for this message

Amit Bhavsar (Open ERP) (amb-openerp) wrote on 2012-03-06: Re: Sale exception: recreate packing duplicates confirmed moves

Hello,

Would you please check this also lp : 897082

Thanks!

Changed in openobject-addons:
status:	New → Confirmed
importance:	Undecided → Medium
assignee:	nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)

Numérigraphe (numerigraphe) on 2012-03-06

tags:

added: shipping-exception

Naresh(OpenERP) (nch-openerp) on 2012-03-20

Changed in openobject-addons:
assignee:	OpenERP R&D Addons Team 3 (openerp-dev-addons3) → OpenERP Publisher's Warranty Team (openerp-opw)
tags:	added: maintenance removed: shipping-exception

Numérigraphe (numerigraphe) on 2012-03-20

tags:

added: shipping-exception

Revision history for this message

Numérigraphe (numerigraphe) wrote on 2012-10-23:

Removing assignment because the maintenance team refused to get in charge of this bug.
Lionel.

Changed in openobject-addons:
assignee:	OpenERP Publisher's Warranty Team (openerp-opw) → nobody

Amit Parik (amit-parik) on 2012-10-23

tags:

removed: maintenance

Revision history for this message

Amit Parik (amit-parik) wrote on 2012-10-23:

Hello,

"Shipping Exception" not available on trunk anymore, So this issue doesn't affect on trunk.

So I am closing this issue.

Thank you!

Changed in openobject-addons:
status:	Confirmed → Invalid
importance:	Medium → Undecided

Revision history for this message

Anil Kesariya(SerpentCS) (a-kesariya-serpentcs) wrote on 2012-10-23:

Hello Lionel,

I have analysed your bug and here is my conclusion.

This seems like more a generic business process where you can only see the 'remaining' moves to be created IF and Only IF the ancestor Delivery/picking is 'Done'. Making it easy, if the previous order's move is not done, recreation of picking is going to create new move!

In our case, what we do is, we cancel a move (out of 2). Now the Original picking has one move cancelled, and another in any state other than cancel or done.

When you "recreate packing" your sale order it checks the state of all line's procurements one by one. In our case, system does have an older picking which is not yet done, so system tries to recreate the picking with same moves(2).

So, if you have completed(set done) your original picking, you would get only one move in the new picking getting generated from recreation.

Hope this clears some view.

Kindly correct my analysis if I have gone wrong.

Regards,
Anil,
Serpent Consulting Services.

Revision history for this message

Anil Kesariya(SerpentCS) (a-kesariya-serpentcs) wrote on 2012-10-23:

ship_recreate.patch Edit (651 bytes, text/plain)

Lionel,

If you wish to get it corrected, here we present a solution attached.

Will await a Feedback.

Thanks.

Revision history for this message

Serpent Consulting Services (serpent-consulting-services) wrote on 2012-11-01:

Lionel,

Would you mind looking at the patch please?

Thanks.

Revision history for this message

Numérigraphe (numerigraphe) wrote on 2012-11-05:

More explicit patch Edit (582 bytes, text/plain)

Dear Anil Kesariya,
Thanks for your patch.
I find it a bit hard to read with all the double-negations. Do you intend to skip all Sale Order Lines that have Stock Moves unless one was canceled?
If so, what about the attached patch?
Lionel

Revision history for this message

Serpent Consulting Services (serpent-consulting-services) wrote on 2012-11-09:

Lionel,

Absolutely yes, you caught it right.

Your patch seem better!

Thanks.

Revision history for this message

Numérigraphe (numerigraphe) wrote on 2012-11-12:

Re-opening as Opinion. don't know what more we can do about this.
Serpent Consulting Services, will you make a merge proposal?
Lionel.

Changed in openobject-addons:
status:	Invalid → Opinion

Revision history for this message

Serpent Consulting Services (serpent-consulting-services) wrote on 2012-11-12:

#10

Lionel,

Your patch is final, so we propose you do it.

Thanks.

Yann Papouin (yann-papouin) on 2013-11-12

Changed in ocb-addons:
status:	New → Confirmed
summary:	- Sale exception: recreate packing duplicates confirmed moves + [NEW] [6.1][7.0][trunk][sale] Sale exception: Recreate Packing + duplicates confirmed moves
summary:	- [NEW] [6.1][7.0][trunk][sale] Sale exception: Recreate Packing - duplicates confirmed moves + [6.1][7.0][trunk][sale] Sale exception: Recreate Packing duplicates + confirmed moves
summary:	- [6.1][7.0][trunk][sale] Sale exception: Recreate Packing duplicates + [6.0][6.1][7.0][trunk][sale] Sale exception: Recreate Packing duplicates confirmed moves
Changed in openobject-addons:
status:	Opinion → Confirmed