Dash - Behaviour of the 'All' button in the Dash filters broken in several ways
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
High
|
John Lea | ||
Nux |
Fix Released
|
Undecided
|
Unassigned | ||
Unity |
Fix Released
|
High
|
Andrea Azzarone | ||
nux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
High
|
Andrea Azzarone |
Bug Description
This doesn't qualitfy for a SRU
-------
A bunch of issues here:
- When opening the "Filter results" for the first time after booting the computer, "All" should be selected by default in every filter category. Currently it is not selected.
- Deselecting all the filters in a filter category should automatically toggle the "All" button to the selected state. E.g. select "Office" in the App Lense 'type' filter category, then deselect "Office". When all the filters in the filter category are deselected the "All" button should automatically become selected.
- "All" should never be selected if any other item in the filter category is selected. For example, select "All" in the App Lens 'type' filter category, then select "Games". As soon as you select "Games", the "All" button should change to the de-selected state.
- It should never be possible to deselect the "All" filter if no other filters in the filter category are selected. For example, in the App Lens 'type' filter category select "All". Clicking on "All" again should do nothing.
Related branches
- Jay Taoko (community): Approve
-
Diff: 80 lines (+21/-5)3 files modifiedNux/AbstractButton.cpp (+9/-0)
Nux/View.cpp (+10/-5)
Nux/View.h (+2/-0)
- Tim Penhey (community): Approve
- Michal Hruby (community): Approve (lens-integration)
- Mirco Müller: Pending requested
-
Diff: 3803 lines (+1760/-1614)29 files modifiedUnityCore/RatingsFilter.cpp (+6/-4)
UnityCore/RatingsFilter.h (+1/-1)
manual-tests/AllButton.txt (+40/-0)
manual-tests/Filters.txt (+26/-0)
plugins/unityshell/resources/dash-widgets.json (+5/-5)
plugins/unityshell/src/FilterAllButton.cpp (+71/-0)
plugins/unityshell/src/FilterAllButton.h (+55/-0)
plugins/unityshell/src/FilterBar.cpp (+78/-67)
plugins/unityshell/src/FilterBar.h (+36/-31)
plugins/unityshell/src/FilterBasicButton.cpp (+116/-137)
plugins/unityshell/src/FilterBasicButton.h (+38/-34)
plugins/unityshell/src/FilterExpanderLabel.cpp (+124/-106)
plugins/unityshell/src/FilterExpanderLabel.h (+45/-38)
plugins/unityshell/src/FilterFactory.cpp (+44/-48)
plugins/unityshell/src/FilterFactory.h (+21/-15)
plugins/unityshell/src/FilterGenreButton.cpp (+49/-56)
plugins/unityshell/src/FilterGenreButton.h (+24/-24)
plugins/unityshell/src/FilterGenreWidget.cpp (+100/-131)
plugins/unityshell/src/FilterGenreWidget.h (+42/-44)
plugins/unityshell/src/FilterMultiRangeButton.cpp (+178/-184)
plugins/unityshell/src/FilterMultiRangeButton.h (+63/-58)
plugins/unityshell/src/FilterMultiRangeWidget.cpp (+145/-166)
plugins/unityshell/src/FilterMultiRangeWidget.h (+43/-43)
plugins/unityshell/src/FilterRatingsButton.cpp (+212/-233)
plugins/unityshell/src/FilterRatingsButton.h (+53/-51)
plugins/unityshell/src/FilterRatingsWidget.cpp (+58/-88)
plugins/unityshell/src/FilterRatingsWidget.h (+34/-41)
plugins/unityshell/src/FilterWidget.cpp (+38/-0)
plugins/unityshell/src/FilterWidget.h (+15/-9)
description: | updated |
tags: | added: onew udo |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Critical |
status: | New → Fix Committed |
Changed in unity: | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in unity (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in unity: | |
assignee: | nobody → Neil J. Patel (njpatel) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Neil J. Patel (njpatel) |
Changed in unity: | |
assignee: | Neil J. Patel (njpatel) → Gord Allott (gordallott) |
Changed in unity (Ubuntu): | |
assignee: | Neil J. Patel (njpatel) → Gord Allott (gordallott) |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
Changed in unity (Ubuntu): | |
assignee: | Gord Allott (gordallott) → Zaid Yeganeh (yeganeh) |
Changed in unity: | |
assignee: | Gord Allott (gordallott) → Zaid Yeganeh (yeganeh) |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
assignee: | Zaid Yeganeh (yeganeh) → nobody |
Changed in unity: | |
milestone: | none → 4.24.0 |
Changed in nux (Ubuntu): | |
status: | New → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
status: | Fix Committed → In Progress |
Changed in nux: | |
status: | New → Fix Committed |
Changed in unity: | |
milestone: | 4.24.0 → 4.26.0 |
Changed in nux: | |
status: | Fix Committed → Fix Released |
Changed in nux (Ubuntu): | |
status: | Fix Committed → Fix Released |
Changed in nux (Ubuntu): | |
status: | Fix Released → Fix Committed |
Changed in unity: | |
milestone: | 4.26.0 → backlog |
description: | updated |
Changed in nux (Ubuntu): | |
status: | Fix Committed → Fix Released |
tags: | added: udp |
Changed in ayatana-design: | |
status: | Fix Released → Fix Committed |
Changed in unity: | |
assignee: | Zaid Yeganeh (yeganeh) → Andrea Azzarone (andyrock) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Andrea Azzarone (andyrock) |
Changed in unity: | |
milestone: | backlog → 5.0.0 |
Changed in unity: | |
milestone: | 5.0.0 → 5.2.0 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in ayatana-design: | |
importance: | Critical → High |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: |
added: reviewedbydesignp removed: onew udo udp |
This bug was fixed in the package unity - 5.2.0-0ubuntu1
---------------
unity (5.2.0-0ubuntu1) precise; urgency=low
* New upstream release. n::NameForWindo w()
- Unity needs a way to switch (tab) between windows on current workspace
(LP: #863399)
- compiz crashed with SIGSEGV in BamfLauncherIco
(LP: #865840)
- Gradual degradation in desktop performance. (LP: #888039)
- compiz (unity) crashes with SIGSEGV when a window is minimized.
(LP: #918329)
- FavoriteStore external change support (LP: #681503)
- Launcher - Make Launcher left of screen reveal more responsive and less
prone to false positives (LP: #765819)
- Window auto-maximise functionality should be disabled on monitors with a
resolution above 1024 x 600 (LP: #797808)
- Dash: very high latency responding to input (LP: #828582)
- Dash - Behaviour of the 'All' button in the Dash filters broken in
several ways (LP: #841864)
- alt-tab - The app title in the top left of the top bar should change as
the alt-tab focus changes (LP: #855516)
- Keyboard shortcut - Add keyboard shortcut hint overlay that is displayed
when a user presses and holds the Super key (LP: #855532)
- Unity crashes when started in an environment without utouch support
(LP: #860707)
- Dash - Remove Dash Home shortcut icons (LP: #885738)
- Dash - Most Frequently Used apps change to Recently Used, without
Launcher favorites (LP: #893214)
- Should have a launcher on every monitor (LP: #915944)
- Launcher autohide behaviour on multi-monitor (LP: #915946)
- the unity wrapper should kill compiz before restarting it (LP: #919132)
- Launcher - Implement workspace/launcher cross interactions (LP: #690143)
- Application icons should only display windows from the current workspace
in the window spread (LP: #689733)
- Notification area ("system tray") missing when using dual monitors of
different sizes, with their bottoms aligned (LP: #778256)
- Clicking Nautilus launcher icon fails to open a Nautilus file explorer
window when copying a file and all other Nautilus windows are closed /
bamf should skip the taskbar (LP: #784804)
- Dash - the search box is not aligned correctly relative to the Launcher
BFB button (LP: #838904)
- Dash - A expand/collapse arrow is missing from all the filter category
headers (LP: #841870)
- Dash - the filter buttons should not have a mouse over state
(LP: #838901)
- Dash - the "Filter results" text is the wrong size, wrong font weight,
and aligned incorrectly in both the vertical and horizontal axis
(LP: #863240)
- Add SUPER+TAB switching mode that enables the user to switch
applications via the Launcher (LP: #891620)
- Software Centre - automatically add app icon to launcher (LP: #761851)
- Compiz add transparency to titlebar along with the panel (LP: #912682)
- The search box is too opaque and dark (LP: #913717)
- Dash - Make statefulness of Dash Home and Dash Lenses consistent
(LP: #914759)
- Unity 5.0: "All" button for filters render as "..." (LP: #91...