novajoin

fix error message from ipa-client-install - error: Too many arguments provided

Bug #1836529 reported by Grzegorz Grasza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
novajoin
Fix Released
Undecided
Unassigned

Bug Description

This ipa-client-install error could be more clear, it means that the -w option misses the OTP token.

The one time password is only used once to provision a host, after it is added to IDM/FreeIPA. The absence of this token (when other variables are present) usually means that the host was already provisioned in a previous deployment, then the overcloud deployment was cleared, deleting the hosts, but not removing them from IDM. Running the provisioning script in this state tries to provision the same host again, but it can't do that more than once.

The error message should probably say, that when the hosts are physically erased, they should also be removed from IDM.

Grzegorz Grasza (xek)
Changed in novajoin:
status: New → Confirmed
Revision history for this message
Grzegorz Grasza (xek) wrote :

Relevant code in novajoin server:
https://github.com/openstack/novajoin/blob/master/novajoin/join.py#L192-L200

Revision history for this message
Grzegorz Grasza (xek) wrote :

TODO:
* fix cloud-init + ipaclient.yaml
* add logging to novajoin-server here: https://github.com/openstack/novajoin/blob/master/novajoin/ipa.py#L327

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to novajoin (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/677455

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to novajoin (master)

Reviewed: https://review.opendev.org/673836
Committed: https://git.openstack.org/cgit/x/novajoin/commit/?id=6506855623fa6d2a4ea13131d153b7477b8a8be2
Submitter: Zuul
Branch: master

commit 6506855623fa6d2a4ea13131d153b7477b8a8be2
Author: Grzegorz Grasza <email address hidden>
Date: Wed Jul 31 16:34:28 2019 +0200

    Helper scripts for modifying cloud-config-novajoin.json

    Adding two helper scripts to unpack cloud-config-novajoin.json to a more
    readable form. After editing cloud-config-novajoin.yaml, it still has to
    be packed into cloud-config-novajoin.json with tools/cloud-config-pack.py.

    Related-Bug: 1836529
    Change-Id: I3d6a3e5f97608f7f8a0070f40ddeb8a7113c33b3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/677455
Committed: https://git.openstack.org/cgit/x/novajoin/commit/?id=956cc87cc1e8bbff44107fba2164c3066f7c46f2
Submitter: Zuul
Branch: master

commit 956cc87cc1e8bbff44107fba2164c3066f7c46f2
Author: Grzegorz Grasza <email address hidden>
Date: Tue Aug 20 14:10:43 2019 +0200

    Fix error message when OTP is missing, add logging

    * Fix cloud-init error message when OTP is missing
    * Add a log message in novajoin-server

    Change-Id: Ib299269c564744af6a5fcded9195d27be1c14ce7
    Related-Bug: 1836529

Grzegorz Grasza (xek)
Changed in novajoin:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.