OpenStack Compute (nova)

nova blocks vdpa move operations that work correctly.

  1. Series yoga
  2. Bug #1970467
Bug #1970467 reported by sean mooney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
sean mooney
Wallaby
In Progress
Medium
sean mooney
Xena
Fix Released
Medium
sean mooney
Yoga
Fix Released
Medium
sean mooney
Zed
Fix Released
Medium
sean mooney

Bug Description

during the implementation of the initall VDPA feature support i only had one server with vdpa capable nics.

as a result no move operations were actually tested so we choose out of an abundance of cation
to block them at the API level until we had a chance to test them.
They have now been tested and work without code change once the API block is removed
during the zed ptg we agreed to treat this as a bug and remove the API block.

once this is complete cold migration, resize, evacuate and shelve/unshelve will be available when using interfaces with vnic-type vdpa.

Revision history for this message
sean mooney (sean-k-mooney) wrote :

setting to medium as supporting move operations like evacuate and cold migrate is essitaly for most operators to reasonably deploy vdpa but for those that did not require that its just a nice to have that simlifys day too operations.

so medium feels about right as those that don't use vdpa are not impacted and does that doo presumable knew the limitations when the decided to deploy it.

tags: added: libvirt pci vdpa
Changed in nova:
assignee: nobody → sean mooney (sean-k-mooney)
importance: Undecided → Medium
status: New → Triaged
OpenStack Infra (hudson-openstack)
Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/841017

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/c/openstack/nova/+/832330
Committed: https://opendev.org/openstack/nova/commit/95f96ed3aa201bc5b90e589b288fa4039bc9c0d2
Submitter: "Zuul (22348)"
Branch: master

commit 95f96ed3aa201bc5b90e589b288fa4039bc9c0d2
Author: Sean Mooney <email address hidden>
Date: Mon Mar 7 20:37:57 2022 +0000

    enable blocked VDPA move operations

    This change adds functional test for operations on servers with VDPA
    devices that are expected to work but currently blocked due to lack
    of testing or qemu bugs.

    cold-migrate, resize, evacuate,and shelve are enabled
    and tested by this patch

    Closes-Bug: #1970467
    Change-Id: I6e220cf3231670d156632e075fcf7701df744773

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.opendev.org/c/openstack/nova/+/841017
Committed: https://opendev.org/openstack/nova/commit/51a970af37094f84b7f2ae321b8f74a570609eb4
Submitter: "Zuul (22348)"
Branch: master

commit 51a970af37094f84b7f2ae321b8f74a570609eb4
Author: Sean Mooney <email address hidden>
Date: Sat May 7 21:36:17 2022 +0300

    Fix suspend for non hostdev sriov ports

    change I3a45b1fb41e8e446d1f25d7a1d77991c8bf2a1ed
    tried to fix bug #1563874 by using _detach_pci_device
    to remove hostdev pci devices however that breaks
    other usecase so we attempt to fix that by only
    calling _detach_pci_device for devices it can
    handle and use detach_interface for the rest.

    Related-bug: #1563874
    Related-bug: #1970467
    Change-Id: I351d58d6922ca169b641500c12ffd6f91829df90

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/nova/+/855035

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 26.0.0.0rc1

This issue was fixed in the openstack/nova 26.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/nova/+/864937

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/865572

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/nova/+/855035
Committed: https://opendev.org/openstack/nova/commit/041939361e393b808724b8590eb76b3aa075814e
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 041939361e393b808724b8590eb76b3aa075814e
Author: Sean Mooney <email address hidden>
Date: Mon Mar 7 20:37:57 2022 +0000

    enable blocked VDPA move operations

    This change adds functional test for operations on servers with VDPA
    devices that are expected to work but currently blocked due to lack
    of testing or qemu bugs.

    cold-migrate, resize, evacuate,and shelve are enabled
    and tested by this patch

    Conflicts:
        nova/tests/functional/libvirt/test_pci_sriov_servers.py

    Closes-Bug: #1970467
    Change-Id: I6e220cf3231670d156632e075fcf7701df744773
    (cherry picked from commit 95f96ed3aa201bc5b90e589b288fa4039bc9c0d2)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/nova/+/864937
Committed: https://opendev.org/openstack/nova/commit/c3092e3ee791d9e291f829cc3eaa8123560a13ef
Submitter: "Zuul (22348)"
Branch: stable/xena

commit c3092e3ee791d9e291f829cc3eaa8123560a13ef
Author: Sean Mooney <email address hidden>
Date: Mon Mar 7 20:37:57 2022 +0000

    enable blocked VDPA move operations

    This change adds functional test for operations on servers with VDPA
    devices that are expected to work but currently blocked due to lack
    of testing or qemu bugs.

    cold-migrate, resize, evacuate,and shelve are enabled
    and tested by this patch

    Conflicts:
        nova/tests/functional/libvirt/test_pci_sriov_servers.py

    Closes-Bug: #1970467
    Change-Id: I6e220cf3231670d156632e075fcf7701df744773
    (cherry picked from commit 95f96ed3aa201bc5b90e589b288fa4039bc9c0d2)
    (cherry picked from commit 041939361e393b808724b8590eb76b3aa075814e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 24.2.0

This issue was fixed in the openstack/nova 24.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 25.1.0

This issue was fixed in the openstack/nova 25.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.