Remaining ports are not unbound if one port is missing
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Medium
|
Stephen Finucane | ||
| Train |
New
|
Undecided
|
Unassigned | ||
| Ussuri |
New
|
Undecided
|
Unassigned | ||
| Victoria |
New
|
Undecided
|
Unassigned | ||
| Wallaby |
New
|
Undecided
|
Unassigned | ||
| Xena |
Fix Released
|
Undecided
|
Unassigned | ||
| Yoga |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
As part of the instance deletion process, we must unbind ports associated with said instance. To do this, we loop over all ports currently attached to an instance. However, if neutron returns HTTP 404 (Not Found) for any of these ports, we will return early and fail to unbind the remaining ports. We've seen the problem in the context of Kubernetes on OpenStack. Our deinstaller is brute-force, so it deletes ports and servers at the same time, so a race means the port can get deleted early. This normally wouldn't be an issue as we'd just "untrunk" it and proceed to delete it. But that won't work for SR-IOV ports as in that case you cannot "untrunk" bound ports.
The solution here is obvious: if we fail to find a port, we should simply skip that and continue unbinding everything else.
| tags: | added: neutron |
| Changed in nova: | |
| assignee: | nobody → Stephen Finucane (stephenfinucane) |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Changed in nova: | |
| status: | Confirmed → In Progress |
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (master) | #1 |
| Changed in nova: | |
| status: | In Progress → Fix Released |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to nova (stable/yoga) | #2 |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to nova (stable/xena) | #3 |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to nova (stable/wallaby) | #4 |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to nova (stable/victoria) | #5 |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to nova (stable/ussuri) | #6 |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to nova (stable/train) | #7 |
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (stable/yoga) | #8 |
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/nova 26.0.0.0rc1 | #9 |
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (stable/xena) | #10 |
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/nova 24.2.0 | #11 |
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/nova 25.1.0 | #12 |
| OpenStack Infra (hudson-openstack) wrote Change abandoned on nova (stable/train) | #13 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 9e0dcb52ab308a6
Author: Stephen Finucane <email address hidden>
Date: Thu May 19 12:04:08 2022 +0100
neutron: Unbind remaining ports after PortNotFound
Just because we encountered a PortNotFound error when unbinding a port
doesn't mean we should stop unbinding the remaining ports. If this error
is encountered, simply continue with the other ports.
While we're here, we clean up some other tests related to '_unbind_port'
since they're clearly duplicates.
Change-Id: Id04e0df12829df
Signed-off-by: Stephen Finucane <email address hidden>
Closes-Bug: #1974173