Bug 1845146 was caused by the update available resources periodic task
running during a small window in which the migration was in 'accepted'
but resource claims had been done. 'accepted' migrations were not
considered in progress before the fix for 1845146 merged as commit
6ec686c26b, which caused the periodic task to incorrectly free the
migration's resources from the destination. This patch adds a test
that triggers this race by wrapping around the compute manager's
live_migration() (which sets the 'queued' migration status - this was
actually wrong in 6ec686c26b, as it talks about 'preparing') and
running the update available resources periodic task while the
migration is still in 'accepted'.
Reviewed: https:/ /review. opendev. org/687404 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=32713a4fe88 5ee55ef0fefc8ce 6c78877f2f03e7
Committed: https:/
Submitter: Zuul
Branch: master
commit 32713a4fe885ee5 5ef0fefc8ce6c78 877f2f03e7
Author: Artom Lifshitz <email address hidden>
Date: Tue Oct 8 15:23:47 2019 -0400
NUMA LM: Add func test for bug 1845146
Bug 1845146 was caused by the update available resources periodic task migration( ) (which sets the 'queued' migration status - this was
running during a small window in which the migration was in 'accepted'
but resource claims had been done. 'accepted' migrations were not
considered in progress before the fix for 1845146 merged as commit
6ec686c26b, which caused the periodic task to incorrectly free the
migration's resources from the destination. This patch adds a test
that triggers this race by wrapping around the compute manager's
live_
actually wrong in 6ec686c26b, as it talks about 'preparing') and
running the update available resources periodic task while the
migration is still in 'accepted'.
Related bug: 1845146
Change-Id: I78e79112a9c803 fb45d828cfb4641 456da66364a