OpenStack Compute (nova)

[neutron]http_retries config option not used when calling the port binding API

  1. Series stein
  2. Bug #1929886
Bug #1929886 reported by melanie witt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
melanie witt
Queens
New
Undecided
Unassigned
Rocky
New
Undecided
Unassigned
Stein
In Progress
Undecided
Unassigned
Train
In Progress
Undecided
Unassigned
Ussuri
Fix Released
Undecided
Unassigned
Victoria
Fix Released
Undecided
Unassigned
Wallaby
Fix Released
Undecided
Unassigned

Bug Description

Discovered downstream [1] that the [neutron]http_retries config option has no effect on calls to the port binding API, so calls to it are not resilient like our other calls to the neutron API.

The neutronclient didn't have support for the port binding API at the time when nova needed to call it, so a manual ksa client was created in the interim.

When the [neutron]http_retries config option was added [2], this manual client was missed and thus never does any retries.

The backportable fix for this will pass the CONF.neutron.http_retries option to the ksa client and the following proposed change to use the now existing neutronclient support should be reviewed and merged to prevent future similar bugs:

https://review.opendev.org/c/openstack/nova/+/706295

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1955031
[2] https://review.opendev.org/c/openstack/nova/+/712226

Tags: neutron
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/793512

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/c/openstack/nova/+/793512
Committed: https://opendev.org/openstack/nova/commit/56eb253e9febccf721df6bca4eb851ad26cb70a6
Submitter: "Zuul (22348)"
Branch: master

commit 56eb253e9febccf721df6bca4eb851ad26cb70a6
Author: melanie witt <email address hidden>
Date: Fri May 28 00:26:04 2021 +0000

    Honor [neutron]http_retries in the manual client

    Change Ifb3afb13aff7e103c2e80ade817d0e63b624604a added a nova side
    config option for specifying neutron client retries that maps to the
    ksa connect_retries config option to provide parity with the cinder and
    glance clients that have nova side config options.

    That change missed passing CONF.neutron.http_retries to the manual
    client used for calling the port binding API. This sets the
    connect_retries attribute on the manual ksa client so http_retries
    will be honored.

    Closes-Bug: #1929886
    Related-Bug: #1866937

    Change-Id: I8296e4be9f0706fab043451b856efadbb7bd41f6

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/794186

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/795175

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/nova/+/795176

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/nova/+/795177

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/c/openstack/nova/+/795138

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/nova/+/794186
Committed: https://opendev.org/openstack/nova/commit/46aa3f4ec769e948d9eb73604bf9b66f4b0230b0
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 46aa3f4ec769e948d9eb73604bf9b66f4b0230b0
Author: melanie witt <email address hidden>
Date: Fri May 28 00:26:04 2021 +0000

    Honor [neutron]http_retries in the manual client

    Change Ifb3afb13aff7e103c2e80ade817d0e63b624604a added a nova side
    config option for specifying neutron client retries that maps to the
    ksa connect_retries config option to provide parity with the cinder and
    glance clients that have nova side config options.

    That change missed passing CONF.neutron.http_retries to the manual
    client used for calling the port binding API. This sets the
    connect_retries attribute on the manual ksa client so http_retries
    will be honored.

    Closes-Bug: #1929886
    Related-Bug: #1866937

    Change-Id: I8296e4be9f0706fab043451b856efadbb7bd41f6
    (cherry picked from commit 56eb253e9febccf721df6bca4eb851ad26cb70a6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/nova/+/795175
Committed: https://opendev.org/openstack/nova/commit/f20346bc00a30c914cbefb48009db776f8e00b09
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit f20346bc00a30c914cbefb48009db776f8e00b09
Author: melanie witt <email address hidden>
Date: Fri May 28 00:26:04 2021 +0000

    Honor [neutron]http_retries in the manual client

    Change Ifb3afb13aff7e103c2e80ade817d0e63b624604a added a nova side
    config option for specifying neutron client retries that maps to the
    ksa connect_retries config option to provide parity with the cinder and
    glance clients that have nova side config options.

    That change missed passing CONF.neutron.http_retries to the manual
    client used for calling the port binding API. This sets the
    connect_retries attribute on the manual ksa client so http_retries
    will be honored.

    Closes-Bug: #1929886
    Related-Bug: #1866937

    Change-Id: I8296e4be9f0706fab043451b856efadbb7bd41f6
    (cherry picked from commit 56eb253e9febccf721df6bca4eb851ad26cb70a6)
    (cherry picked from commit 46aa3f4ec769e948d9eb73604bf9b66f4b0230b0)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 23.0.2

This issue was fixed in the openstack/nova 23.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 22.2.2

This issue was fixed in the openstack/nova 22.2.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/nova/+/795176
Committed: https://opendev.org/openstack/nova/commit/b96f93ed8633d6fd0725c4a11366ffbf38056e65
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit b96f93ed8633d6fd0725c4a11366ffbf38056e65
Author: melanie witt <email address hidden>
Date: Fri May 28 00:26:04 2021 +0000

    Honor [neutron]http_retries in the manual client

    Change Ifb3afb13aff7e103c2e80ade817d0e63b624604a added a nova side
    config option for specifying neutron client retries that maps to the
    ksa connect_retries config option to provide parity with the cinder and
    glance clients that have nova side config options.

    That change missed passing CONF.neutron.http_retries to the manual
    client used for calling the port binding API. This sets the
    connect_retries attribute on the manual ksa client so http_retries
    will be honored.

    Closes-Bug: #1929886
    Related-Bug: #1866937

    Change-Id: I8296e4be9f0706fab043451b856efadbb7bd41f6
    (cherry picked from commit 56eb253e9febccf721df6bca4eb851ad26cb70a6)
    (cherry picked from commit 46aa3f4ec769e948d9eb73604bf9b66f4b0230b0)
    (cherry picked from commit f20346bc00a30c914cbefb48009db776f8e00b09)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 24.0.0.0rc1

This issue was fixed in the openstack/nova 24.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 21.2.3

This issue was fixed in the openstack/nova 21.2.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/stein)

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/stein
Review: https://review.opendev.org/c/openstack/nova/+/795138
Reason: This branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/train)

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/nova/+/795177
Reason: stable/train branch of nova projects' have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.