OpenStack Compute (nova)

lxml 4.4.0 causes failed tests in nova

  1. Series stein
  2. Bug #1838666
Bug #1838666 reported by Matthew Thode
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
sean mooney
Stein
Confirmed
Medium
Unassigned

Bug Description

It looks like it's just a ordering issue for the elements that are returned.

See https://review.opendev.org/673848 for details on the failure (you can depend on it for testing fixes as well).

Takashi Natsume (natsume-takashi)
tags: added: libvirt testing
Changed in nova:
status: New → Confirmed
Revision history for this message
Matthew Thode (prometheanfire) wrote :

might be fixed in 4.4.1

https://github.com/lxml/lxml/compare/lxml-4.4.0...lxml-4.4.1

Revision history for this message
Matthew Thode (prometheanfire) wrote :

doesn't look like it.

Revision history for this message
Matt Riedemann (mriedem) wrote :

Bug 1841667 has an example of the failed tests as well.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/678964

Changed in nova:
assignee: nobody → sean mooney (sean-k-mooney)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/678964
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=58ffff49ac716772b8d67ab487938215f5a0a658
Submitter: Zuul
Branch: master

commit 58ffff49ac716772b8d67ab487938215f5a0a658
Author: Sean Mooney <email address hidden>
Date: Tue Aug 27 23:16:38 2019 +0100

    fix lxml compatibility issues

    Some unit tests were performing string matches on xml data
    with inputs that were generated using lxml. This is problematic
    as while white space between element tags is important in xml
    ordering of attributes within a tag is not. In the latest version
    of lxml the ordering asserted in the test no longer matches the
    order returned by lxml on python 3.6+.

    This change updates the failing test to use the XMLMatcher
    class to compare xml strings instead.

    Closes-Bug: #1838666
    Related-Bug: #1841667
    Change-Id: I1649a850ccb9ac85d7a962936ffef51d573b6f78

Changed in nova:
status: In Progress → Fix Released
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 20.0.0.0rc1

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.