Incorrect results for tenant usage

Fix proposed to branch: master
Review: https://review.openstack.org/608685

Reviewed: https://review.openstack.org/608685
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=afc3a16ce3364c233e6e1cffc9f38987d1d65318
Submitter: Zuul
Branch: master

commit afc3a16ce3364c233e6e1cffc9f38987d1d65318
Author: Lucian Petrut <email address hidden>
Date: Mon Oct 8 17:13:55 2018 +0300

    Fix os-simple-tenant-usage result order

    nova usage-list can return incorrect results, having resources counted
    twice. This only occurs when using the 2.40 microversion or later.

    This microversion introduced pagination, which doesn't work properly.
    Nova API will sort the instances using the tenant id and instance uuid,
    but 'os-simple-tenant-usage' will not preserve the order when returning
    the results.

    For this reason, subsequent API calls made by the client will use the
    wrong marker (which is supposed to be the last instance id), ending
    up counting the same instances twice.

    Change-Id: I6c7a67b23ec49aa207c33c38580acd834bb27e3c
    Closes-Bug: #1796689

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/613853

Reviewed: https://review.openstack.org/613853
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=133b194ba079abe84900d09a5c3c74ef9f464bab
Submitter: Zuul
Branch: stable/rocky

commit 133b194ba079abe84900d09a5c3c74ef9f464bab
Author: Lucian Petrut <email address hidden>
Date: Mon Oct 8 17:13:55 2018 +0300

    Fix os-simple-tenant-usage result order

    nova usage-list can return incorrect results, having resources counted
    twice. This only occurs when using the 2.40 microversion or later.

    This microversion introduced pagination, which doesn't work properly.
    Nova API will sort the instances using the tenant id and instance uuid,
    but 'os-simple-tenant-usage' will not preserve the order when returning
    the results.

    For this reason, subsequent API calls made by the client will use the
    wrong marker (which is supposed to be the last instance id), ending
    up counting the same instances twice.

    Change-Id: I6c7a67b23ec49aa207c33c38580acd834bb27e3c
    Closes-Bug: #1796689
    (cherry picked from commit afc3a16ce3364c233e6e1cffc9f38987d1d65318)

This issue was fixed in the openstack/nova 18.1.0 release.

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/632516

Reviewed: https://review.openstack.org/632516
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=70b4cdce68f9b1543c032aa700e4f0f4289d90a6
Submitter: Zuul
Branch: stable/queens

commit 70b4cdce68f9b1543c032aa700e4f0f4289d90a6
Author: Lucian Petrut <email address hidden>
Date: Mon Oct 8 17:13:55 2018 +0300

    Fix os-simple-tenant-usage result order

    nova usage-list can return incorrect results, having resources counted
    twice. This only occurs when using the 2.40 microversion or later.

    This microversion introduced pagination, which doesn't work properly.
    Nova API will sort the instances using the tenant id and instance uuid,
    but 'os-simple-tenant-usage' will not preserve the order when returning
    the results.

    For this reason, subsequent API calls made by the client will use the
    wrong marker (which is supposed to be the last instance id), ending
    up counting the same instances twice.

    Change-Id: I6c7a67b23ec49aa207c33c38580acd834bb27e3c
    Closes-Bug: #1796689
    (cherry picked from commit afc3a16ce3364c233e6e1cffc9f38987d1d65318)
    (cherry picked from commit 133b194ba079abe84900d09a5c3c74ef9f464bab)

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

This issue was fixed in the openstack/nova 17.0.10 release.

Fix proposed to branch: stable/pike
Review: https://review.opendev.org/709600

Fix proposed to branch: stable/ocata
Review: https://review.opendev.org/709603

Reviewed: https://review.opendev.org/709600
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f8a721ae85cab44754b8e64434e90f4c2afa89aa
Submitter: Zuul
Branch: stable/pike

commit f8a721ae85cab44754b8e64434e90f4c2afa89aa
Author: Lucian Petrut <email address hidden>
Date: Mon Oct 8 17:13:55 2018 +0300

    Fix os-simple-tenant-usage result order

    nova usage-list can return incorrect results, having resources counted
    twice. This only occurs when using the 2.40 microversion or later.

    This microversion introduced pagination, which doesn't work properly.
    Nova API will sort the instances using the tenant id and instance uuid,
    but 'os-simple-tenant-usage' will not preserve the order when returning
    the results.

    For this reason, subsequent API calls made by the client will use the
    wrong marker (which is supposed to be the last instance id), ending
    up counting the same instances twice.

    NOTE(melwitt): The differences from the Queens change in the sample
    .tpl and .json files are because change
    I3b25debb0bcfd4e211734307c8d363f2b5dbc655 is not in Pike, so there
    are only two generated UUIDs per server (instance UUID and vif UUID)
    instead of three (instance UUID, vif UUID, and bdm UUID).

    Change-Id: I6c7a67b23ec49aa207c33c38580acd834bb27e3c
    Closes-Bug: #1796689
    (cherry picked from commit afc3a16ce3364c233e6e1cffc9f38987d1d65318)
    (cherry picked from commit 133b194ba079abe84900d09a5c3c74ef9f464bab)
    (cherry picked from commit 70b4cdce68f9b1543c032aa700e4f0f4289d90a6)

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/ocata
Review: https://review.opendev.org/c/openstack/nova/+/709603
Reason: stable/ocata of openstack/nova transitioned to End of Life ( https://review.opendev.org/c/openstack/releases/+/795664 ), to be able to delete the branch we need to abandon all open patches on the branch.

This issue was fixed in the openstack/nova pike-eol release.