OpenStack Compute (nova)

Report client associations include non-sharing providers

Series queens
Bug #1750084

Bug #1750084 reported by Eric Fried on 2018-02-17

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	High	Eric Fried
	Queens	Fix Committed	Undecided	Eric Fried

Bug Description

It was discussed and decided [1] that we only want to be pulling down, caching, and passing to update_provider_tree providers associated via aggregate with the compute node's provider tree if they are sharing providers. Otherwise we'll get e.g. all the *other* compute nodes which are also associated with a sharing provider.

[1] https://review.openstack.org/#/c/540111/4/specs/rocky/approved/update-provider-tree.rst@48

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-17: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/545494

Changed in nova:
assignee:	nobody → Eric Fried (efried)
status:	New → In Progress

Eric Fried (efried) on 2018-02-17

tags:

added: queens-rc-potential

melanie witt (melwitt) on 2018-02-21

Changed in nova:
importance:	Undecided → High

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-21: Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/546740

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-21: Fix merged to nova (master)

Reviewed: https://review.openstack.org/545494
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d2152f309439a9d9b054a481826242ca15f5c93e
Submitter: Zuul
Branch: master

commit d2152f309439a9d9b054a481826242ca15f5c93e
Author: Eric Fried <email address hidden>
Date: Fri Feb 16 18:18:32 2018 -0600

Only pull associated *sharing* providers

    It was discussed and decided [1] that we only want to be pulling down,
    caching, and passing to update_provider_tree providers associated via
    aggregate with the compute node's provider tree if they are sharing
    providers. Otherwise we'll get e.g. all the *other* compute nodes which
    are also associated with a sharing provider.

[1] https://review.openstack.org/#/c/540111/4/specs/rocky/approved/update-provider-tree.rst@48

Change-Id: Iab366da7623e5e31b8416e89fee7d418f7bf9b30
Closes-Bug: #1750084

Changed in nova:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-02-22: Fix merged to nova (stable/queens)

Reviewed: https://review.openstack.org/546740
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f0a722d1efd9bb92e2ec5120a3b2091425222393
Submitter: Zuul
Branch: stable/queens

commit f0a722d1efd9bb92e2ec5120a3b2091425222393
Author: Eric Fried <email address hidden>
Date: Fri Feb 16 18:18:32 2018 -0600

Only pull associated *sharing* providers

    It was discussed and decided [1] that we only want to be pulling down,
    caching, and passing to update_provider_tree providers associated via
    aggregate with the compute node's provider tree if they are sharing
    providers. Otherwise we'll get e.g. all the *other* compute nodes which
    are also associated with a sharing provider.

[1] https://review.openstack.org/#/c/540111/4/specs/rocky/approved/update-provider-tree.rst@48

Closes-Bug: #1750084
(cherry picked from commit d2152f309439a9d9b054a481826242ca15f5c93e)

    Conflicts:
     nova/scheduler/client/report.py
     nova/tests/functional/api/openstack/placement/test_report_client.py
     nova/tests/unit/scheduler/client/test_report.py