OpenStack Compute (nova)

Make service all-cells min version helper use scatter-gather

  1. Series queens
  2. Bug #1746558
Bug #1746558 reported by Surya Seetharaman
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Dan Smith
Pike
Confirmed
Medium
Unassigned
Queens
Fix Committed
Medium
Elod Illes

Bug Description

Currently the "get_minimum_version_all_cells" function in service runs sequentially and this affects the performance in case of large deployments (running a lot of cells) : https://github.com/openstack/nova/blob/stable/pike/nova/objects/service.py#L440

So it would be nice to use the scatter_gather_all_cells function to do this operation in parallel.

Also apart from the performance scaling point of view, in case connection to a particular cell fails, it would be nice to have sentinels returned which is done by the scatter_gather_all_cells. This helps when a cell is down.

See original description
Tags: cells
Surya Seetharaman (tssurya)
description: updated
description: updated
description: updated
Surya Seetharaman (tssurya)
description: updated
OpenStack Infra (hudson-openstack)
Changed in nova:
status: New → In Progress
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Medium
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Dan Smith (danms) → Matt Riedemann (mriedem)
Matt Riedemann (mriedem)
Changed in nova:
assignee: Matt Riedemann (mriedem) → Dan Smith (danms)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/539590
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5fe3a01b604c29b0961d19b44a873cca78891381
Submitter: Zuul
Branch: master

commit 5fe3a01b604c29b0961d19b44a873cca78891381
Author: Dan Smith <email address hidden>
Date: Wed Jan 31 08:13:36 2018 -0800

    Make service all-cells min version helper use scatter-gather

    This makes the Service get_minimum_version_all_cells() helper use the parallel
    scatter-gather utilities to make the determination. It also adds fault handling
    for cases where a cell fails to respond, and an option to ignore or raise in
    that situation.

    Closes-Bug: #1746558
    Change-Id: I62dc1033437f91bded28a9fd58759d2dbd7e55fb

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.0.0.0b2

This issue was fixed in the openstack/nova 18.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/637594

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/queens)

Reviewed: https://review.openstack.org/637594
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b7237a9e6c9567f2f2b8753be1cdc274951a9451
Submitter: Zuul
Branch: stable/queens

commit b7237a9e6c9567f2f2b8753be1cdc274951a9451
Author: Dan Smith <email address hidden>
Date: Wed Jan 31 08:13:36 2018 -0800

    Make service all-cells min version helper use scatter-gather

    This makes the Service get_minimum_version_all_cells() helper use the parallel
    scatter-gather utilities to make the determination. It also adds fault handling
    for cases where a cell fails to respond, and an option to ignore or raise in
    that situation.

    Closes-Bug: #1746558
    Change-Id: I62dc1033437f91bded28a9fd58759d2dbd7e55fb
    (cherry picked from commit 5fe3a01b604c29b0961d19b44a873cca78891381)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.10

This issue was fixed in the openstack/nova 17.0.10 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.