Activity log for bug #1744079

Date Who What changed Old value New value Message
2018-01-18 14:20:48 Matthew Booth bug added bug
2018-01-22 10:58:28 int32bit nova: assignee int32bit (int32bit)
2018-01-22 12:33:22 OpenStack Infra nova: status New In Progress
2018-02-05 17:04:32 Matt Riedemann tags libvirt
2018-07-03 08:35:10 Dominique Poulain bug added subscriber Dominique Poulain
2018-08-29 11:42:13 OpenStack Infra nova: status In Progress Fix Released
2018-10-24 02:40:18 Hua Zhang summary disk over-commit still not correctly calculated during live migration [SRU] disk over-commit still not correctly calculated during live migration
2018-10-24 02:40:28 Hua Zhang description Change I8a705114d47384fcd00955d4a4f204072fed57c2 (written by me... sigh) addressed a bug which prevented live migration to a target host with overcommitted disk when made with microversion <2.25. It achieved this, but the fix is still not correct. We now do: if disk_over_commit: disk_available_gb = dst_compute_info['local_gb'] Unfortunately local_gb is *total* disk, not available disk. We actually want free_disk_gb. Fun fact: due to the way we calculate this for filesystems, without taking into account reserved space, this can also be negative. The test we're currently running is: could we fit this guest's allocated disks on the target if the target disk was empty. This is at least better than it was before, as we don't spuriously fail early. In fact, we're effectively disabling a test which is disabled for microversion >=2.25 anyway. IOW we should fix it, but it's probably not a high priority. [Impact] nova compares disk space with disk_available_least field, which is possible to be negative, due to overcommit. So the migration may fail because of a "Migration pre-check error: Unable to migrate dfcd087a-5dff-439d-8875-2f702f081539: Disk of instance is too large(available on destination host:-3221225472 < need:22806528)" when trying a migration to another compute that has plenty of free space in his disk. [Test Case] Deploy openstack environment. Make sure there is a negative disk_available_least and a adequate free_disk_gb in one test compute node, then migrate a VM to it with disk-overcommit (openstack server migrate --live <TEST-COMPUTE-NODE> --block-migration --disk-overcommit <VM-NAME>). You will see above migration pre-check error. This is the formula to compute disk_available_least and free_disk_gb. disk_free_gb = disk_info_dict['free'] disk_over_committed = self._get_disk_over_committed_size_total() available_least = disk_free_gb * units.Gi - disk_over_committed data['disk_available_least'] = available_least / units.Gi The following command can be used to query the value of disk_available_least nova hypervisor-show <ID> |grep disk Steps to Reproduce: 1. set disk_allocation_ratio config option > 1.0 2. qemu-img resize cirros-0.3.0-x86_64-disk.img +40G 3. glance image-create --disk-format qcow2 ... 4. boot VMs based on resized image 5. we see disk_available_least becomes negative [Regression Potential] Minimal - we're just changing from the following line: disk_available_gb = dst_compute_info['disk_available_least'] to the following codes: if disk_over_commit: disk_available_gb = dst_compute_info['free_disk_gb'] else: disk_available_gb = dst_compute_info['disk_available_least'] When enabling overcommit, disk_available_least is possible to be negative, so we should use free_disk_gb instead of it by backporting the following two fixes. https://git.openstack.org/cgit/openstack/nova/commit/?id=e097c001c8e11110efe8879da57264fcb7bdfdf2 https://git.openstack.org/cgit/openstack/nova/commit/?id=e2cc275063658b23ed88824100919a6dfccb760d This is the code path for check_can_live_migrate_destination: _migrate_live(os-migrateLive API, migrate_server.py) -> migrate_server -> _live_migrate -> _build_live_migrate_task -> _call_livem_checks_on_host -> check_can_live_migrate_destination BTW, redhat also has a same bug - https://bugzilla.redhat.com/show_bug.cgi?id=1477706 [Original Bug Report] Change I8a705114d47384fcd00955d4a4f204072fed57c2 (written by me... sigh) addressed a bug which prevented live migration to a target host with overcommitted disk when made with microversion <2.25. It achieved this, but the fix is still not correct. We now do: if disk_over_commit: disk_available_gb = dst_compute_info['local_gb'] Unfortunately local_gb is *total* disk, not available disk. We actually want free_disk_gb. Fun fact: due to the way we calculate this for filesystems, without taking into account reserved space, this can also be negative. The test we're currently running is: could we fit this guest's allocated disks on the target if the target disk was empty. This is at least better than it was before, as we don't spuriously fail early. In fact, we're effectively disabling a test which is disabled for microversion >=2.25 anyway. IOW we should fix it, but it's probably not a high priority.
2018-10-24 02:53:04 Hua Zhang tags libvirt libvirt sts
2018-10-24 03:09:53 Hua Zhang tags libvirt sts libvirt sts-sru
2018-10-24 03:14:26 Hua Zhang bug added subscriber STS Sponsors
2018-10-24 03:25:55 Hua Zhang attachment added lp1744079_xenial.debdiff https://bugs.launchpad.net/nova/+bug/1744079/+attachment/5204743/+files/lp1744079_xenial.debdiff
2018-10-24 04:23:29 Hua Zhang tags libvirt sts-sru libvirt sts-sru-needed
2018-10-24 04:24:18 Hua Zhang bug added subscriber Hua Zhang
2018-10-24 04:30:24 Hua Zhang tags libvirt sts-sru-needed libvirt sts-sponsor sts-sru-needed
2018-10-24 04:31:46 Hua Zhang bug task added cloud-archive
2018-10-24 07:13:31 Hua Zhang bug task added nova (Ubuntu)
2018-10-24 07:13:58 Hua Zhang bug task deleted nova (Ubuntu)
2018-10-25 07:07:21 Hua Zhang tags libvirt sts-sponsor sts-sru-needed libvirt sts sts-sponsor sts-sru-needed
2018-10-31 15:03:01 Matt Riedemann nominated for series nova/rocky
2018-10-31 15:03:01 Matt Riedemann bug task added nova/rocky
2018-10-31 15:03:01 Matt Riedemann nominated for series nova/queens
2018-10-31 15:03:01 Matt Riedemann bug task added nova/queens
2018-10-31 15:03:19 Matt Riedemann nova/queens: importance Undecided Low
2018-10-31 15:03:22 Matt Riedemann nova/rocky: importance Undecided Low
2018-10-31 15:03:29 Matt Riedemann nova/rocky: status New In Progress
2018-10-31 15:03:35 Matt Riedemann nova/queens: status New In Progress
2018-10-31 15:03:39 Matt Riedemann nova/queens: assignee Lee Yarwood (lyarwood)
2018-10-31 15:03:41 Matt Riedemann nova/rocky: assignee Lee Yarwood (lyarwood)
2018-10-31 15:03:44 Matt Riedemann nova: importance Undecided Low
2018-11-01 00:03:56 Eric Desrochers removed subscriber STS Sponsors
2018-11-05 14:09:50 Corey Bryant bug task added nova (Ubuntu)
2018-11-05 14:10:03 Corey Bryant nominated for series Ubuntu Cosmic
2018-11-05 14:10:03 Corey Bryant bug task added nova (Ubuntu Cosmic)
2018-11-05 14:10:03 Corey Bryant nominated for series Ubuntu Bionic
2018-11-05 14:10:03 Corey Bryant bug task added nova (Ubuntu Bionic)
2018-11-05 14:10:14 Corey Bryant nominated for series Ubuntu Disco
2018-11-05 14:10:14 Corey Bryant bug task added nova (Ubuntu Disco)
2018-11-05 14:10:28 Corey Bryant nova (Ubuntu Bionic): status New Triaged
2018-11-05 14:10:32 Corey Bryant nova (Ubuntu Cosmic): status New Triaged
2018-11-05 14:10:37 Corey Bryant nova (Ubuntu Disco): status New Triaged
2018-11-05 14:10:52 Corey Bryant nova (Ubuntu Disco): importance Undecided High
2018-11-05 14:10:57 Corey Bryant nova (Ubuntu Cosmic): importance Undecided High
2018-11-05 14:11:00 Corey Bryant nova (Ubuntu Bionic): importance Undecided High
2018-11-05 14:11:50 Corey Bryant nominated for series cloud-archive/queens
2018-11-05 14:11:50 Corey Bryant bug task added cloud-archive/queens
2018-11-05 14:11:50 Corey Bryant nominated for series cloud-archive/rocky
2018-11-05 14:11:50 Corey Bryant bug task added cloud-archive/rocky
2018-11-05 14:12:01 Corey Bryant cloud-archive/queens: importance Undecided High
2018-11-05 14:12:01 Corey Bryant cloud-archive/queens: status New Triaged
2018-11-05 14:12:13 Corey Bryant cloud-archive/rocky: importance Undecided High
2018-11-05 14:12:13 Corey Bryant cloud-archive/rocky: status New Triaged
2018-11-05 16:20:26 Ubuntu Foundations Team Bug Bot tags libvirt sts sts-sponsor sts-sru-needed libvirt patch sts sts-sponsor sts-sru-needed
2018-11-05 16:20:38 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Sponsors Team
2018-11-05 16:58:07 Corey Bryant bug added subscriber Ubuntu Stable Release Updates Team
2018-11-07 23:35:01 Launchpad Janitor nova (Ubuntu Disco): status Triaged Fix Released
2018-11-13 17:58:36 Brian Murray nova (Ubuntu Cosmic): status Triaged Fix Committed
2018-11-13 17:58:42 Brian Murray bug added subscriber SRU Verification
2018-11-13 17:58:48 Brian Murray tags libvirt patch sts sts-sponsor sts-sru-needed libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-cosmic
2018-11-13 18:00:58 Brian Murray nova (Ubuntu Bionic): status Triaged Fix Committed
2018-11-13 18:01:05 Brian Murray tags libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-cosmic libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-bionic verification-needed-cosmic
2018-11-13 18:01:19 Brian Murray removed subscriber Ubuntu Sponsors Team
2018-11-16 17:13:17 Corey Bryant cloud-archive: status Triaged Fix Committed
2018-11-16 17:13:22 Corey Bryant cloud-archive/rocky: status Triaged Fix Committed
2018-11-19 14:41:17 Corey Bryant cloud-archive/queens: status Triaged Fix Committed
2018-11-19 14:41:20 Corey Bryant tags libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-bionic verification-needed-cosmic libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-bionic verification-needed-cosmic verification-queens-needed
2018-11-27 10:16:00 Hua Zhang tags libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-bionic verification-needed-cosmic verification-queens-needed libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-bionic verification-needed-cosmic verification-queens-done
2018-12-07 11:20:02 James Page tags libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-bionic verification-needed-cosmic verification-queens-done libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-bionic verification-needed-cosmic verification-queens-done verification-rocky-needed
2018-12-12 01:09:30 Corey Bryant tags libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-bionic verification-needed-cosmic verification-queens-done verification-rocky-needed libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-bionic verification-needed-cosmic verification-queens-needed verification-rocky-needed
2018-12-13 07:29:58 Hua Zhang tags libvirt patch sts sts-sponsor sts-sru-needed verification-needed verification-needed-bionic verification-needed-cosmic verification-queens-needed verification-rocky-needed libvirt patch sts sts-sponsor sts-sru-needed verification-done-cosmic verification-needed verification-needed-bionic verification-queens-needed verification-rocky-needed
2018-12-13 08:04:24 Hua Zhang tags libvirt patch sts sts-sponsor sts-sru-needed verification-done-cosmic verification-needed verification-needed-bionic verification-queens-needed verification-rocky-needed libvirt patch sts sts-sponsor sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-queens-needed verification-rocky-needed
2018-12-13 09:37:16 Hua Zhang tags libvirt patch sts sts-sponsor sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-queens-needed verification-rocky-needed libvirt patch sts sts-sponsor sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-queens-done verification-rocky-needed
2018-12-13 11:41:34 Hua Zhang tags libvirt patch sts sts-sponsor sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-queens-done verification-rocky-needed libvirt patch sts sts-sponsor sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-queens-done verification-rocky-done
2018-12-17 19:20:32 Corey Bryant nominated for series Ubuntu Xenial
2018-12-17 19:20:32 Corey Bryant bug task added nova (Ubuntu Xenial)
2018-12-17 19:24:27 Corey Bryant nova (Ubuntu Xenial): importance Undecided High
2018-12-17 19:24:27 Corey Bryant nova (Ubuntu Xenial): status New Triaged
2018-12-17 19:53:12 Corey Bryant nominated for series cloud-archive/ocata
2018-12-17 19:53:12 Corey Bryant bug task added cloud-archive/ocata
2018-12-17 19:53:12 Corey Bryant nominated for series cloud-archive/pike
2018-12-17 19:53:12 Corey Bryant bug task added cloud-archive/pike
2018-12-17 19:53:32 Corey Bryant cloud-archive/pike: importance Undecided High
2018-12-17 19:53:32 Corey Bryant cloud-archive/pike: status New Triaged
2018-12-17 19:53:48 Corey Bryant cloud-archive/ocata: importance Undecided High
2018-12-17 19:53:48 Corey Bryant cloud-archive/ocata: status New Triaged
2018-12-18 19:32:35 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2018-12-18 19:42:39 Launchpad Janitor nova (Ubuntu Cosmic): status Fix Committed Fix Released
2018-12-18 21:43:07 Launchpad Janitor nova (Ubuntu Bionic): status Fix Committed Fix Released
2018-12-24 09:53:01 Hua Zhang attachment added lp1744079_pike.debdiff https://bugs.launchpad.net/nova/+bug/1744079/+attachment/5224619/+files/lp1744079_pike.debdiff
2018-12-24 09:53:25 Hua Zhang attachment added lp1744079_ocata.debdiff https://bugs.launchpad.net/nova/+bug/1744079/+attachment/5224620/+files/lp1744079_ocata.debdiff
2019-01-07 10:58:27 James Page cloud-archive/queens: status Fix Committed Fix Released
2019-01-07 12:05:09 James Page cloud-archive/rocky: status Fix Committed Fix Released
2019-03-20 13:23:53 Dan Streetman tags libvirt patch sts sts-sponsor sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-queens-done verification-rocky-done libvirt patch sts verification-done-bionic verification-done-cosmic verification-needed verification-queens-done verification-rocky-done
2019-03-20 13:25:48 Dan Streetman tags libvirt patch sts verification-done-bionic verification-done-cosmic verification-needed verification-queens-done verification-rocky-done libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-queens-done verification-rocky-done
2019-03-26 04:18:44 OpenStack Infra cloud-archive/pike: status Triaged Fix Committed
2019-04-03 02:27:13 Hua Zhang attachment removed lp1744079_xenial.debdiff https://bugs.launchpad.net/nova/+bug/1744079/+attachment/5204743/+files/lp1744079_xenial.debdiff
2019-04-03 02:27:26 Hua Zhang attachment removed lp1744079_pike.debdiff https://bugs.launchpad.net/nova/+bug/1744079/+attachment/5224619/+files/lp1744079_pike.debdiff
2019-04-03 02:27:38 Hua Zhang attachment removed lp1744079_ocata.debdiff https://bugs.launchpad.net/nova/+bug/1744079/+attachment/5224620/+files/lp1744079_ocata.debdiff
2019-04-03 02:28:54 Hua Zhang attachment added lp1744079_xenail.debdiff https://bugs.launchpad.net/nova/+bug/1744079/+attachment/5252332/+files/lp1744079_xenail.debdiff
2019-04-03 10:06:59 Sahid Orentino cloud-archive/ocata: assignee Sahid Orentino (sahid-ferdjaoui)
2019-04-03 12:42:26 Corey Bryant tags libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-queens-done verification-rocky-done libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-pike-needed verification-queens-done verification-rocky-done
2019-04-03 12:43:11 Corey Bryant cloud-archive/ocata: status Triaged Fix Committed
2019-04-03 12:43:13 Corey Bryant tags libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-pike-needed verification-queens-done verification-rocky-done libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-ocata-needed verification-pike-needed verification-queens-done verification-rocky-done
2019-04-03 14:33:41 Corey Bryant bug added subscriber Ubuntu Stable Release Updates Team
2019-04-10 22:27:19 Hua Zhang tags libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-ocata-needed verification-pike-needed verification-queens-done verification-rocky-done libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done
2019-04-16 07:28:20 James Page tags libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done libvirt patch sts sts-sru-needed verification-done verification-done-bionic verification-done-cosmic verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done
2019-04-16 08:29:10 Edward Hope-Morley nominated for series cloud-archive/mitaka
2019-04-16 08:29:10 Edward Hope-Morley bug task added cloud-archive/mitaka
2019-04-16 15:16:59 James Page cloud-archive/ocata: status Fix Committed Fix Released
2019-04-16 15:17:40 James Page cloud-archive/pike: status Fix Committed Fix Released
2019-04-17 07:11:07 Hua Zhang attachment added trusty-mitaka.debdiff https://bugs.launchpad.net/nova/+bug/1744079/+attachment/5256475/+files/trusty-mitaka.debdiff
2019-04-18 00:54:46 Hua Zhang attachment removed trusty-mitaka.debdiff https://bugs.launchpad.net/nova/+bug/1744079/+attachment/5256475/+files/trusty-mitaka.debdiff
2019-04-29 19:52:02 Corey Bryant cloud-archive/mitaka: importance Undecided High
2019-04-29 19:52:02 Corey Bryant cloud-archive/mitaka: status New Triaged
2019-04-30 20:28:21 Brian Murray nova (Ubuntu Xenial): status Triaged Fix Committed
2019-04-30 20:28:31 Brian Murray tags libvirt patch sts sts-sru-needed verification-done verification-done-bionic verification-done-cosmic verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-needed-xenial verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done
2019-05-02 17:31:02 Corey Bryant cloud-archive/mitaka: status Triaged Fix Committed
2019-05-02 17:31:04 Corey Bryant tags libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-needed verification-needed-xenial verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-mitaka-needed verification-needed verification-needed-xenial verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done
2019-05-06 09:53:12 Hua Zhang tags libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-mitaka-needed verification-needed verification-needed-xenial verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-done-xenial verification-mitaka-needed verification-needed verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done
2019-05-06 10:46:37 Hua Zhang tags libvirt patch sts sts-sru-needed verification-done-bionic verification-done-cosmic verification-done-xenial verification-mitaka-needed verification-needed verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done libvirt patch sts sts-sru-done verification-done-bionic verification-done-cosmic verification-done-xenial verification-mitaka-done verification-needed verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done
2019-05-06 10:48:19 Hua Zhang tags libvirt patch sts sts-sru-done verification-done-bionic verification-done-cosmic verification-done-xenial verification-mitaka-done verification-needed verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done libvirt patch sts sts-sru-needed verification-done verification-done-bionic verification-done-cosmic verification-done-xenial verification-mitaka-done verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done
2019-05-15 11:52:34 Launchpad Janitor nova (Ubuntu Xenial): status Fix Committed Fix Released
2019-05-15 14:33:59 Corey Bryant cloud-archive/mitaka: status Fix Committed Fix Released
2019-05-23 07:55:39 Edward Hope-Morley cloud-archive: status Fix Committed Fix Released
2019-05-23 07:56:13 Edward Hope-Morley tags libvirt patch sts sts-sru-needed verification-done verification-done-bionic verification-done-cosmic verification-done-xenial verification-mitaka-done verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done libvirt patch sts sts-sru-done verification-done verification-done-bionic verification-done-cosmic verification-done-xenial verification-mitaka-done verification-ocata-done verification-pike-done verification-queens-done verification-rocky-done