OpenStack Compute (nova)

After deleting (abort) a live migration the allocations are not deleted from the destination host

  1. Series pike
  2. Bug #1714237
Bug #1714237 reported by Lajos Katona
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Matt Riedemann
Pike
Fix Committed
Medium
Matt Riedemann

Bug Description

After deleting a live migration there are allocations on both the source and the destination hosts.
Reproduction:
- Boot a VM, on host1
- Start live migrating it to host2
- Delete the migration
- The allocations are both on host1 & host2.
This situation doesn't change after running the periodics.

Lajos Katona (lajos-katona)
tags: added: live-migration
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/499583

Revision history for this message
Lajos Katona (lajos-katona) wrote : Re: After deleting a migration the allocations are not ceased from the destination host

Functional test for reproduction (the good assertions commented out, and replaced with the currently working ones):
https://review.openstack.org/499583

Sean Dague (sdague)
Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Matt Riedemann (mriedem) wrote :

By "delete" I assume you mean the REST API delete action, which is really canceling an in-progress live migration which should stop things on the destination node.

Revision history for this message
Lajos Katona (lajos-katona) wrote :

Yes I meant this operation:
https://developer.openstack.org/api-ref/compute/#delete-abort-migration

Matt Riedemann (mriedem)
summary: - After deleting a migration the allocations are not ceased from the
- destination host
+ After deleting (abort) a live migration the allocations are not deleted
+ from the destination host
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/499583
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=143fe79c9e4daf9ab0b10402caea444080d3bf1f
Submitter: Jenkins
Branch: master

commit 143fe79c9e4daf9ab0b10402caea444080d3bf1f
Author: Lajos Katona <email address hidden>
Date: Mon Aug 28 14:10:46 2017 +0200

    Add functional for live migrate delete

    Related-Bug: #1714237
    Change-Id: I3bf0032f8cecf098fd941e5e5b41c9ff3d8336e4

OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: nobody → Matt Riedemann (mriedem)
status: Confirmed → In Progress
Revision history for this message
Matt Riedemann (mriedem) wrote :

This is the fix: https://review.openstack.org/#/c/507687/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (stable/pike)

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/509925

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/509926

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/507687
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f90c61cd88edce74e3dbfd069beb2c33793d3371
Submitter: Jenkins
Branch: master

commit f90c61cd88edce74e3dbfd069beb2c33793d3371
Author: Matt Riedemann <email address hidden>
Date: Tue Sep 26 17:37:19 2017 -0400

    Remove dest node allocations during live migration rollback

    When a live migration fails or is cancelled, either during
    pre_live_migration on the destination host or during the
    actual live migration itself, we rollback from the failure/abort
    by doing things like removing volume connections from the
    destination host and re-setup the network on the source host.

    As part of the rollback from a failed or cancelled live migration,
    we also need to remove the allocations created in Placement for the
    destination node, since the instance is not on the destination
    node.

    Change-Id: I7b70cf8d5233bd25bf865a1b2789640758493c2b
    Closes-Bug: #1715182
    Closes-Bug: #1714237

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (stable/pike)

Reviewed: https://review.openstack.org/509925
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=56914621952811edddf882dc64a167cc6924142b
Submitter: Zuul
Branch: stable/pike

commit 56914621952811edddf882dc64a167cc6924142b
Author: Lajos Katona <email address hidden>
Date: Mon Aug 28 14:10:46 2017 +0200

    Add functional for live migrate delete

    Related-Bug: #1714237
    Change-Id: I3bf0032f8cecf098fd941e5e5b41c9ff3d8336e4
    (cherry picked from commit 143fe79c9e4daf9ab0b10402caea444080d3bf1f)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.0.0b1

This issue was fixed in the openstack/nova 17.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/pike)

Reviewed: https://review.openstack.org/509926
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=76a3465271bdf48ebf579df77bb93739f39745c0
Submitter: Zuul
Branch: stable/pike

commit 76a3465271bdf48ebf579df77bb93739f39745c0
Author: Matt Riedemann <email address hidden>
Date: Tue Sep 26 17:37:19 2017 -0400

    Remove dest node allocations during live migration rollback

    When a live migration fails or is cancelled, either during
    pre_live_migration on the destination host or during the
    actual live migration itself, we rollback from the failure/abort
    by doing things like removing volume connections from the
    destination host and re-setup the network on the source host.

    As part of the rollback from a failed or cancelled live migration,
    we also need to remove the allocations created in Placement for the
    destination node, since the instance is not on the destination
    node.

    Change-Id: I7b70cf8d5233bd25bf865a1b2789640758493c2b
    Closes-Bug: #1715182
    Closes-Bug: #1714237
    (cherry picked from commit f90c61cd88edce74e3dbfd069beb2c33793d3371)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.3

This issue was fixed in the openstack/nova 16.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.