Comment 18 for bug 1547142

Reviewed: https://review.openstack.org/504273
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=286fa12ad128ad22d2e9c5002c54dfdb54faac16
Submitter: Zuul
Branch: stable/ocata

commit 286fa12ad128ad22d2e9c5002c54dfdb54faac16
Author: Andrea Rosa <email address hidden>
Date: Thu Sep 14 13:47:06 2017 -0400

    Call terminate_connection when shelve_offloading

    When nova performs a shelve offload for an instance, it needs to terminate
    all the volume connections for that instance as with the shelve offload
    it is not guaranteed that the instance will be placed on the same host once
    it gets unshelved.
    This change adds the call to the terminate_volume_connections on the
    _shelve_offload_instance method in the compute manager.

    Closes-Bug: #1547142

    Conflicts:
          nova/tests/unit/compute/test_shelve.py

    NOTE(mriedem): The conflicts in the test are just due to not having
    resource allocation cleanup for placement in shelve offload in Ocata.

    Change-Id: I8849ae0f54605e003d5b294ca3d66dcef89d7d27
    (cherry picked from commit e89e1bdc60211622440c964f8be8563da89341ac)
    (cherry picked from commit 8365eb6cb987c834b1f35c04be13aa97db36a4a1)