OpenStack Compute (nova)

ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa is running on non-code changes

  1. Series ocata
  2. Bug #1776981
Bug #1776981 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Matt Riedemann
Ocata
Fix Committed
Medium
Matt Riedemann
Pike
Fix Committed
Medium
Matt Riedemann
Queens
Fix Released
Medium
Matt Riedemann

Bug Description

Due to a change in zuul:

http://lists.openstack.org/pipermail/openstack-dev/2018-June/131304.html

ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa is now running on non-code changes in nova because of how it's defined on nova in project-config:

http://git.openstack.org/cgit/openstack-infra/project-config/tree/zuul.d/projects.yaml#n10496

- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa:
            voting: false
            irrelevant-files:
              - ^(placement-)?api-.*$
              - ^.git.*$
              - ^nova/hacking/.*$
              - ^nova/locale/.*$
              - ^nova/tests/.*$
              - ^tests-py3.txt$

We should move that in-tree to .zuul.yaml and fix the irrelevant-files for nova.

Revision history for this message
Matt Riedemann (mriedem) wrote :

Since project-config is branchless, and there are no branch restrictions on the ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa job definition itself, if we move this in-tree to nova and out of project-config we'll also need to backport it to the stable branches for nova to continue running that job on nova's stable branches. That's easy, but just FYI.

tags: added: low-hanging-fruit testing
Matt Riedemann (mriedem)
Changed in nova:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/578878

Changed in nova:
assignee: nobody → Matt Riedemann (mriedem)
status: Triaged → In Progress
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/578878
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=17b3bae64ca7aa4c1a6d296860cce6c0bfbb38a1
Submitter: Zuul
Branch: master

commit 17b3bae64ca7aa4c1a6d296860cce6c0bfbb38a1
Author: Matt Riedemann <email address hidden>
Date: Thu Jun 28 12:12:53 2018 -0400

    Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree

    ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa is
    defined in the ironic repo but nova uses it because it's defined
    in the project-config repo with it's own irrelevant-files list.
    Due to a recent change in zuul [1], the definition from project-config
    overrides the irrelevant-files from the job definition in ironic and
    results in us running this job on things like docs-only changes in
    nova, which is not awesome.

    This change moves the job usage in-tree from project-config and updates
    the irrelevant-files list to match nova-dsvm-base.

    Since project-config is branchless, we'll have to backport this in-tree
    change to nova's stable branches to continue running this job on nova
    stable branches once the override is removed from project-config.

    [1] http://lists.openstack.org/pipermail/openstack-dev/2018-June/131304.html

    Change-Id: I9435fe84c8dc8a6f35ffb195ddbf71ca34edb242
    Closes-Bug: #1776981

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/579862

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/queens)

Reviewed: https://review.openstack.org/579862
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1e16b5f9f341cd0d086065e8b513937f7cd56f5a
Submitter: Zuul
Branch: stable/queens

commit 1e16b5f9f341cd0d086065e8b513937f7cd56f5a
Author: Matt Riedemann <email address hidden>
Date: Thu Jun 28 12:12:53 2018 -0400

    Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree

    ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa is
    defined in the ironic repo but nova uses it because it's defined
    in the project-config repo with it's own irrelevant-files list.
    Due to a recent change in zuul [1], the definition from project-config
    overrides the irrelevant-files from the job definition in ironic and
    results in us running this job on things like docs-only changes in
    nova, which is not awesome.

    This change moves the job usage in-tree from project-config and updates
    the irrelevant-files list to match nova-dsvm-base.

    Since project-config is branchless, we'll have to backport this in-tree
    change to nova's stable branches to continue running this job on nova
    stable branches once the override is removed from project-config.

    [1] http://lists.openstack.org/pipermail/openstack-dev/2018-June/131304.html

    Change-Id: I9435fe84c8dc8a6f35ffb195ddbf71ca34edb242
    Closes-Bug: #1776981
    (cherry picked from commit 17b3bae64ca7aa4c1a6d296860cce6c0bfbb38a1)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/581444

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/581445

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.0.0.0b3

This issue was fixed in the openstack/nova 18.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.6

This issue was fixed in the openstack/nova 17.0.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/pike)

Reviewed: https://review.openstack.org/581444
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=039a61f95301b57b1a98bae7f7b5582bb6d8999f
Submitter: Zuul
Branch: stable/pike

commit 039a61f95301b57b1a98bae7f7b5582bb6d8999f
Author: Matt Riedemann <email address hidden>
Date: Thu Jun 28 12:12:53 2018 -0400

    Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree

    ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa is
    defined in the ironic repo but nova uses it because it's defined
    in the project-config repo with it's own irrelevant-files list.
    Due to a recent change in zuul [1], the definition from project-config
    overrides the irrelevant-files from the job definition in ironic and
    results in us running this job on things like docs-only changes in
    nova, which is not awesome.

    This change moves the job usage in-tree from project-config and updates
    the irrelevant-files list to match nova-dsvm-base.

    Since project-config is branchless, we'll have to backport this in-tree
    change to nova's stable branches to continue running this job on nova
    stable branches once the override is removed from project-config.

    [1] http://lists.openstack.org/pipermail/openstack-dev/2018-June/131304.html

    Conflicts:
          .zuul.yaml

    NOTE(mriedem): The conflict is due to not running the nova-cells-v1
    job in stable/pike because of bug 1745838.

    Change-Id: I9435fe84c8dc8a6f35ffb195ddbf71ca34edb242
    Closes-Bug: #1776981
    (cherry picked from commit 17b3bae64ca7aa4c1a6d296860cce6c0bfbb38a1)
    (cherry picked from commit 1e16b5f9f341cd0d086065e8b513937f7cd56f5a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ocata)

Reviewed: https://review.openstack.org/581445
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4858514cef9f350c3d636c9a2b49a9bd2232fb9a
Submitter: Zuul
Branch: stable/ocata

commit 4858514cef9f350c3d636c9a2b49a9bd2232fb9a
Author: Matt Riedemann <email address hidden>
Date: Thu Jun 28 12:12:53 2018 -0400

    Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree

    ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa is
    defined in the ironic repo but nova uses it because it's defined
    in the project-config repo with it's own irrelevant-files list.
    Due to a recent change in zuul [1], the definition from project-config
    overrides the irrelevant-files from the job definition in ironic and
    results in us running this job on things like docs-only changes in
    nova, which is not awesome.

    This change moves the job usage in-tree from project-config and updates
    the irrelevant-files list to match nova-dsvm-base.

    Since project-config is branchless, we'll have to backport this in-tree
    change to nova's stable branches to continue running this job on nova
    stable branches once the override is removed from project-config.

    [1] http://lists.openstack.org/pipermail/openstack-dev/2018-June/131304.html

    Change-Id: I9435fe84c8dc8a6f35ffb195ddbf71ca34edb242
    Closes-Bug: #1776981
    (cherry picked from commit 17b3bae64ca7aa4c1a6d296860cce6c0bfbb38a1)
    (cherry picked from commit 1e16b5f9f341cd0d086065e8b513937f7cd56f5a)
    (cherry picked from commit 039a61f95301b57b1a98bae7f7b5582bb6d8999f)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.1.6

This issue was fixed in the openstack/nova 16.1.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 15.1.5

This issue was fixed in the openstack/nova 15.1.5 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.