OpenStack Compute (nova)

Config option api_class erroneously overriden in init.py

Series ocata
Bug #1704875

Bug #1704875 reported by Derek on 2017-07-17

This bug affects 2 people

	Status	Importance	Assigned to
Cinder	Fix Released	Undecided	Kaitlin Farr
OpenStack Compute (nova)	Fix Released	Medium	Matt Riedemann
Newton	Incomplete	Medium	Unassigned
Ocata	Confirmed	Medium	Unassigned

Bug Description

When adding api_class = <barbican manager> in the nova.conf file for Newton, the nova/keymgr/__init__.py file has code that re-sets the value of api_class to default. This makes it impossible to use barbican with nova without hacking some workaround

release: Newton

to reproduce:

1. set api_class in nova.conf
2. restart nova with debug
3. see that api_class is still default

Workaround: commenting out lines 29 and 30 in __init__.py fixes the issue.

Tags:

Matt Riedemann (mriedem) on 2017-07-17

tags:

added: barbican

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-07-17: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/484501

Changed in nova:
assignee:	nobody → Matt Riedemann (mriedem)
status:	New → In Progress

Matt Riedemann (mriedem) on 2017-07-17

Changed in nova:
importance:	Undecided → Medium

Kaitlin Farr (kaitlin-farr) on 2017-07-19

summary:

- Nova option api_class erroneously overriden in __init__.py
+ Config option api_class erroneously overriden in __init__.py

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-07-19: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/485322

Changed in cinder:
assignee:	nobody → Kaitlin Farr (kaitlin-farr)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-07-20: Fix merged to nova (master)

Reviewed: https://review.openstack.org/484501
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=47528cd5c264870c059dfe85bfeb22548d6cb618
Submitter: Jenkins
Branch: master

commit 47528cd5c264870c059dfe85bfeb22548d6cb618
Author: Matt Riedemann <email address hidden>
Date: Mon Jul 17 17:49:08 2017 -0400

Remove key_manager.api_class hack

    We can remove the hack associated with this TODO since devstack
    is setting the config option value in change
    I733279864ee1a4aaffc9c8eed81b5e12f8d8821b.

Depends-On: I733279864ee1a4aaffc9c8eed81b5e12f8d8821b

Change-Id: I89972b96ce2e1d06e24992d66026554b9a56d4dc
Closes-Bug: #1704875

Changed in nova:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-07-24: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/485322
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=229e660e30d4efd2c47d29c2eccb0c2282a98b0e
Submitter: Jenkins
Branch: master

commit 229e660e30d4efd2c47d29c2eccb0c2282a98b0e
Author: Kaitlin Farr <email address hidden>
Date: Wed Jul 19 14:40:24 2017 -0400

Remove key_manager.api_class hack

    We can remove the hack associated with this TODO since devstack
    is setting the config option value in change
    I733279864ee1a4aaffc9c8eed81b5e12f8d8821b.

Depends-On: I733279864ee1a4aaffc9c8eed81b5e12f8d8821b

Closes-Bug: #1704875
Change-Id: I4461b8fa4e626afd8b94e942d4ad17726f307fbf