error message not clear for shared live migration with block storage

Bug #1690890 reported by Chris Friesen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Chris Friesen
Ocata
Fix Committed
Medium
Lee Yarwood

Bug Description

When using an older microversion (2.25 or earlier) with boot-from-image, and the user forgets to specify block-migration, the error message returned is this:

"Live migration can not be used without shared storage except a booted from volume VM which does not have a local disk."

This has a couple things wrong with it. First, the triple-negative is a bit confusing, especially for non-native-english speakers. Second, it implies that you cannot do a block migration, which is obviously false.

I think a more clear error message would be something like:

"Shared storage migration requires either shared storage or boot-from-volume with no local disks."

Tags: compute
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/464726

Changed in nova:
assignee: nobody → Chris Friesen (cbf123)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/464726
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=902b7bf6f5425824a0661b8e4beac4a894749c03
Submitter: Jenkins
Branch: master

commit 902b7bf6f5425824a0661b8e4beac4a894749c03
Author: Chris Friesen <email address hidden>
Date: Mon May 15 12:48:37 2017 -0600

    fix InvalidSharedStorage exception message

    The exception message for InvalidSharedStorage is grammatically
    complex and ignores the possibility of block migration, which
    results in a misleading and confusing message for the user.

    Change it to something simpler and more accurate.

    Change-Id: Icfc8e151a4ea36ec303f0b8c2e1dc9e6f0bd5925
    Closes-Bug: #1690890

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/465024

Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b2

This issue was fixed in the openstack/nova 16.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ocata)

Reviewed: https://review.openstack.org/465024
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f2c5ee22610d13e00a1f1f54e8764009f4801c3f
Submitter: Jenkins
Branch: stable/ocata

commit f2c5ee22610d13e00a1f1f54e8764009f4801c3f
Author: Chris Friesen <email address hidden>
Date: Mon May 15 12:48:37 2017 -0600

    fix InvalidSharedStorage exception message

    The exception message for InvalidSharedStorage is grammatically
    complex and ignores the possibility of block migration, which
    results in a misleading and confusing message for the user.

    Change it to something simpler and more accurate.

    Change-Id: Icfc8e151a4ea36ec303f0b8c2e1dc9e6f0bd5925
    Closes-Bug: #1690890
    (cherry picked from commit 902b7bf6f5425824a0661b8e4beac4a894749c03)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 15.0.6

This issue was fixed in the openstack/nova 15.0.6 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.