OpenStack Compute (nova)

Incorrect set deprecated flag for notify_on_state_change

Series ocata
Bug #1671847

Bug #1671847 reported by Ionuț Bîru on 2017-03-10

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	High	Ionuț Bîru
	Ocata	Fix Committed	High	Matt Riedemann

Bug Description

grep notify_on_state_change /var/log/nova/nova-api-os-compute.log
2017-03-10 16:26:51.974 13421 DEBUG oslo_service.service [req-f7d5880a-5c31-491b-b821-45666eddc10a - - - - -] notifications.notify_on_state_change = None log_opt_values /openstack/venvs/nova-15.0.0/lib/python2.7/site-packages/oslo_config/cfg.py:2744
2017-03-10 16:30:19.035 13435 DEBUG oslo_service.service [req-8c2f196d-5cac-430c-8194-1cc560e73636 - - - - -] notifications.notify_on_state_change = None log_opt_values /openstack/venvs/nova-15.0.0/lib/python2.7/site-packages/oslo_config/cfg.py:2744
2017-03-10 16:34:34.418 13510 DEBUG oslo_service.service [req-310dc3b3-db07-4290-acec-f758d246452b - - - - -] notifications.notify_on_state_change = vm_and_task_state log_opt_values /openstack/venvs/nova-15.0.0/lib/python2.7/site-packages/oslo_config/cfg.py:2744

No warning return. The 3rd line has the correct value after setting in [notifications] section.

I'll submit the patch

Tags:

Revision history for this message

Matt Riedemann (mriedem) wrote on 2017-03-10:

Yeah we confirmed that the code is setting deprecated_group='default' which doesn't error but doesn't do the passthrough for DEFAULT. This is a bug on a few options that were moved between groups in ocata, so we should fix all of them in the same patch.

summary:	- Incorect set deprecated flag for notify_on_state_change + Incorrect set deprecated flag for notify_on_state_change
Changed in nova:
status:	New → Confirmed
importance:	Undecided → High
tags:	added: config
Changed in nova:
assignee:	nobody → Ionuț Bîru (ionut-3)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-10: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/444350

Changed in nova:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-10:

Fix proposed to branch: master
Review: https://review.openstack.org/444357

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-10: Change abandoned on nova (master)

Change abandoned by Ionuț Bîru (<email address hidden>) on branch: master
Review: https://review.openstack.org/444350

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-10: Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/444374

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-13: Fix merged to nova (master)

Reviewed: https://review.openstack.org/444357
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=abd18a12e3e6b571d35499857a005a7bfd7237a4
Submitter: Jenkins
Branch: master

commit abd18a12e3e6b571d35499857a005a7bfd7237a4
Author: Ionuț Bîru <email address hidden>
Date: Fri Mar 10 17:22:22 2017 +0200

Correctly set up deprecation warning

    In the current state, no warning was output in the logs.
    With this fix, a warning is output in the logs and the value from
    [DEFAULT] is used correctly.

Change-Id: I6a7f856e583aed31a3316c0b174a5559cd09e34b
Closes-Bug: #1671847

Changed in nova:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-14: Fix merged to nova (stable/ocata)

Reviewed: https://review.openstack.org/444374
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=59123a18767567438d8388730750f9c8eb377d1f
Submitter: Jenkins
Branch: stable/ocata

commit 59123a18767567438d8388730750f9c8eb377d1f
Author: Ionuț Bîru <email address hidden>
Date: Fri Mar 10 17:22:22 2017 +0200

Correctly set up deprecation warning

    In the current state, no warning was output in the logs.
    With this fix, a warning is output in the logs and the value from
    [DEFAULT] is used correctly.

    Change-Id: I6a7f856e583aed31a3316c0b174a5559cd09e34b
    Closes-Bug: #1671847
    (cherry picked from commit abd18a12e3e6b571d35499857a005a7bfd7237a4)