PCI device migration cannot continue with old deleted service records

Fix proposed to branch: master
Review: https://review.openstack.org/438578

I was able to workaround the problem like this:

delete from services where deleted != 0 ;
delete from aggregate_hosts where deleted !=0;
delete from aggregate_metadata where deleted !=0;
delete from aggregates where deleted !=0;

and then I also need nova to be at least at commit edbd3135f8087ea73dc73b06962bf8b869ee6f43

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/438628

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/438630

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/438632

Reviewed: https://review.openstack.org/438578
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c79770e615799cd4457ac603dcad4fb3452fe2bc
Submitter: Jenkins
Branch: master

commit c79770e615799cd4457ac603dcad4fb3452fe2bc
Author: Dan Smith <email address hidden>
Date: Mon Feb 27 07:52:29 2017 -0800

    Ignore deleted services in minimum version calculation

    When we go to detect the minimum version for a given service, we
    should ignore any deleted services. Without this, we will return
    the minimum version of all records, including those that have been
    deleted with "nova service-delete". This patch filters deleted
    services from the query.

    Closes-Bug: #1668310
    Change-Id: Ic96a5eb3728f97a3c35d2c5121e6fdcd4fd1c70b

Reviewed: https://review.openstack.org/438630
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1ad5c7305c37079ced24bf623810e63d5eac2661
Submitter: Jenkins
Branch: stable/newton

commit 1ad5c7305c37079ced24bf623810e63d5eac2661
Author: Dan Smith <email address hidden>
Date: Mon Feb 27 07:52:29 2017 -0800

    Ignore deleted services in minimum version calculation

    When we go to detect the minimum version for a given service, we
    should ignore any deleted services. Without this, we will return
    the minimum version of all records, including those that have been
    deleted with "nova service-delete". This patch filters deleted
    services from the query.

    Closes-Bug: #1668310
    Change-Id: Ic96a5eb3728f97a3c35d2c5121e6fdcd4fd1c70b
    (cherry picked from commit c79770e615799cd4457ac603dcad4fb3452fe2bc)
    (cherry picked from commit a1dd547d3ba7d9cf5b73da1ce9668e412501ace1)

Reviewed: https://review.openstack.org/438632
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2e05c82b807624b8420df4c94d68b75563b230d2
Submitter: Jenkins
Branch: stable/mitaka

commit 2e05c82b807624b8420df4c94d68b75563b230d2
Author: Dan Smith <email address hidden>
Date: Mon Feb 27 07:52:29 2017 -0800

    Ignore deleted services in minimum version calculation

    When we go to detect the minimum version for a given service, we
    should ignore any deleted services. Without this, we will return
    the minimum version of all records, including those that have been
    deleted with "nova service-delete". This patch filters deleted
    services from the query.

    Conflicts:
            nova/db/sqlalchemy/api.py
            nova/tests/unit/db/test_db_api.py

    NOTE(mriedem): The conflicts are due to not having change
    11cb56a2243faa9f2614a8f9a9a84603bc91d6b1 in Mitaka.

    Closes-Bug: #1668310
    Change-Id: Ic96a5eb3728f97a3c35d2c5121e6fdcd4fd1c70b
    (cherry picked from commit c79770e615799cd4457ac603dcad4fb3452fe2bc)
    (cherry picked from commit a1dd547d3ba7d9cf5b73da1ce9668e412501ace1)
    (cherry picked from commit 1ad5c7305c37079ced24bf623810e63d5eac2661)

Reviewed: https://review.openstack.org/438628
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a1dd547d3ba7d9cf5b73da1ce9668e412501ace1
Submitter: Jenkins
Branch: stable/ocata

commit a1dd547d3ba7d9cf5b73da1ce9668e412501ace1
Author: Dan Smith <email address hidden>
Date: Mon Feb 27 07:52:29 2017 -0800

    Ignore deleted services in minimum version calculation

    When we go to detect the minimum version for a given service, we
    should ignore any deleted services. Without this, we will return
    the minimum version of all records, including those that have been
    deleted with "nova service-delete". This patch filters deleted
    services from the query.

    Closes-Bug: #1668310
    Change-Id: Ic96a5eb3728f97a3c35d2c5121e6fdcd4fd1c70b
    (cherry picked from commit c79770e615799cd4457ac603dcad4fb3452fe2bc)

This issue was fixed in the openstack/nova 13.1.3 release.

This issue was fixed in the openstack/nova 15.0.1 release.

This issue was fixed in the openstack/nova 14.0.5 release.

This issue was fixed in the openstack/nova 16.0.0.0b1 development milestone.