vf interface isn't assigned the correct mac address

Bug #1622292 reported by edan david
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Moshe Levi
Newton
Fix Committed
Undecided
Moshe Levi
Ocata
Fix Committed
Undecided
Moshe Levi

Bug Description

Due to a libvirt change in version libvirt-1.2.18.3-1.fc23.x86_64
Bug ticket for libvirt:
https://bugzilla.redhat.com/show_bug.cgi?id=1372944

the vf interface mac address is not synced with the assigned vf mac address.
when creating a guest with macvtap-passthrough the guest will not get DHCP because the the VF's netdev name is not set.

Tags: libvirt
edan david (edand)
description: updated
Revision history for this message
Praveen N (praveenn) wrote :

Please share more details.

Changed in nova:
status: New → Incomplete
Revision history for this message
Augustina Ragwitz (auggy) wrote :

Looks like this bug didn't get linked - https://review.openstack.org/#/c/364121/

Changed in nova:
status: Incomplete → In Progress
assignee: nobody → edan david (edand)
tags: added: libvirt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/364121
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/424639

Changed in nova:
assignee: edan david (edand) → Moshe Levi (moshele)
Changed in nova:
assignee: Moshe Levi (moshele) → Stephen Finucane (stephenfinucane)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/424639
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d79e3afc4c566f439e182f7866969b3392b8a37a
Submitter: Jenkins
Branch: master

commit d79e3afc4c566f439e182f7866969b3392b8a37a
Author: Edan David <email address hidden>
Date: Thu Sep 1 03:46:17 2016 -0400

    Assign mac address to vf netdevice when using macvtap port

    This is a workaround to libvirt issue described here:
    https://bugzilla.redhat.com/show_bug.cgi?id=1372944. The problem is that
    libvirt dosn't update the mac address of the netdevice, instead it uses
    netlink to configure the mac address of the VF. For macvtap to work
    libvirt should set the mac address on the VF net device and using
    netlink. Until this is fixed we should set both of them in nova.

    Change-Id: If32828840b552a73400df052fc12a8b5a24f202d
    Closes-Bug: #1622292

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.0.0b1

This issue was fixed in the openstack/nova 16.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/490404

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/490405

Matt Riedemann (mriedem)
Changed in nova:
assignee: Stephen Finucane (stephenfinucane) → Moshe Levi (moshele)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ocata)

Reviewed: https://review.openstack.org/490404
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b6c1bd6a5b34e59200bcff371a30ed02566b15fb
Submitter: Jenkins
Branch: stable/ocata

commit b6c1bd6a5b34e59200bcff371a30ed02566b15fb
Author: Edan David <email address hidden>
Date: Thu Sep 1 03:46:17 2016 -0400

    Assign mac address to vf netdevice when using macvtap port

    This is a workaround to libvirt issue described here:
    https://bugzilla.redhat.com/show_bug.cgi?id=1372944. The problem is that
    libvirt dosn't update the mac address of the netdevice, instead it uses
    netlink to configure the mac address of the VF. For macvtap to work
    libvirt should set the mac address on the VF net device and using
    netlink. Until this is fixed we should set both of them in nova.

    Change-Id: If32828840b552a73400df052fc12a8b5a24f202d
    Closes-Bug: #1622292
    (cherry picked from commit d79e3afc4c566f439e182f7866969b3392b8a37a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/newton)

Reviewed: https://review.openstack.org/490405
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=08bda20e981ac7449b8813c8a09cabc5982a71d7
Submitter: Jenkins
Branch: stable/newton

commit 08bda20e981ac7449b8813c8a09cabc5982a71d7
Author: Edan David <email address hidden>
Date: Thu Sep 1 03:46:17 2016 -0400

    Assign mac address to vf netdevice when using macvtap port

    This is a workaround to libvirt issue described here:
    https://bugzilla.redhat.com/show_bug.cgi?id=1372944. The problem is that
    libvirt dosn't update the mac address of the netdevice, instead it uses
    netlink to configure the mac address of the VF. For macvtap to work
    libvirt should set the mac address on the VF net device and using
    netlink. Until this is fixed we should set both of them in nova.

    Change-Id: If32828840b552a73400df052fc12a8b5a24f202d
    Closes-Bug: #1622292
    (cherry picked from commit d79e3afc4c566f439e182f7866969b3392b8a37a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 15.0.7

This issue was fixed in the openstack/nova 15.0.7 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 14.0.8

This issue was fixed in the openstack/nova 14.0.8 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.