OpenStack Compute (nova)

Time is not synced for resumed from suspend instances

  1. Series newton
  2. Bug #1636565
Bug #1636565 reported by Vladik Romanovsky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Vladik Romanovsky
Newton
Fix Committed
Medium
Lee Yarwood

Bug Description

Time is not being synchronized for resumed from suspend instances
as guest.resume() method is not being called on resume operations.

Tags: libvirt
Vladik Romanovsky (vladik-romanovsky)
Changed in nova:
assignee: nobody → Vladik Romanovsky (vladik-romanovsky)
Revision history for this message
Matt Riedemann (mriedem) wrote :

I feel like there was a related / similar fix for something like this in newton, but I'm at a loss to find it right now.

Revision history for this message
Matt Riedemann (mriedem) wrote :

Yeah, so you added this in newton: https://review.openstack.org/#/c/316116/

So how is this bug different? Or does ^ not work?

Revision history for this message
Matt Riedemann (mriedem) wrote :

Oh I see, guest.resume() isn't called from resume() in the libvirt driver...I guess that was totally missed in that fix made in newton.

Changed in nova:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/390947

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/390947
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cd1af7abdd09852feb985974bdfb1f7dd4d6bcc9
Submitter: Jenkins
Branch: master

commit cd1af7abdd09852feb985974bdfb1f7dd4d6bcc9
Author: Vladik Romanovsky <email address hidden>
Date: Wed Oct 19 12:21:40 2016 -0400

    libvirt: sync time on resumed from suspend instances

    Time is not being synchronized for migrated or resumed from suspend instances
    as guest.resume() method is not being called on these operations.

    Calling sync_guest_time directly in the resume method as well as in
    finish_migration.

    Resolves-Bug: #1636565

    Change-Id: Ie140bc0912e6b312d3fcbee7e9650a81076eda4d

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/393699

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/newton)

Reviewed: https://review.openstack.org/393699
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=af90e824e375fd61af1af230ab101e752cead8b6
Submitter: Jenkins
Branch: stable/newton

commit af90e824e375fd61af1af230ab101e752cead8b6
Author: Vladik Romanovsky <email address hidden>
Date: Wed Oct 19 12:21:40 2016 -0400

    libvirt: sync time on resumed from suspend instances

    Time is not being synchronized for migrated or resumed from suspend instances
    as guest.resume() method is not being called on these operations.

    Calling sync_guest_time directly in the resume method as well as in
    finish_migration.

    Resolves-Bug: #1636565

    Change-Id: Ie140bc0912e6b312d3fcbee7e9650a81076eda4d
    (cherry picked from commit cd1af7abdd09852feb985974bdfb1f7dd4d6bcc9)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.