OpenStack Compute (nova)

get_function_by_ifname does not return true for physical function

Series newton
Bug #1625220

Bug #1625220 reported by edan david on 2016-09-19

This bug affects 1 person

	Status	Importance	Assigned to
OpenStack Compute (nova)	Fix Released	Medium	edan david
Mitaka	Fix Released	Undecided	Unassigned
Newton	Fix Committed	Medium	Moshe Levi

Bug Description

Due to a missing slash ('/') in the 'get_function_by_ifname' method (pci/utils),
an incorrect path was passed to read the number of VFs and determine if the device is a PF or not.

See original description

Tags:

Revision history for this message

Praveen N (praveenn) wrote on 2016-09-19:

Hi Edan,
Can you please share more details !! ??
Thanks

Changed in nova:
assignee:	nobody → Praveen N (praveenn)

Praveen N (praveenn) on 2016-09-20

Changed in nova:
status:	New → Incomplete

Revision history for this message

edan david (edand) wrote on 2016-09-20:

Hi Praveen,
I've committed a fix, it's under review.
Have a look:
https://review.openstack.org/#/c/372558/2

Changed in nova:
assignee:	Praveen N (praveenn) → edan david (edand)
status:	Incomplete → In Progress
description:	updated
description:	updated

Revision history for this message

Praveen N (praveenn) wrote on 2016-09-20:

Yup :)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-22: Fix merged to nova (master)

Reviewed: https://review.openstack.org/372558
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=859de9c9971a3dd13f245d2245686fb3d19a832d
Submitter: Jenkins
Branch: master

commit 859de9c9971a3dd13f245d2245686fb3d19a832d
Author: Edan David <email address hidden>
Date: Mon Sep 19 10:48:55 2016 -0400

Add missing slash to dir path

    When validating a PF in the method 'get_function_by_ifname'
    the number of VFs are read from a file,
    the path to that file was missing a slash ('/').

Change-Id: I7bf4bb96f1f769bff247f5af2c81dd96b08e2f04
Closes-Bug: #1625220

Changed in nova:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-24: Fix proposed to nova (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/375872

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-24: Fix proposed to nova (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/375873

Revision history for this message

Matt Riedemann (mriedem) wrote on 2016-09-26:

Was this a regression in newton?

Revision history for this message

Matt Riedemann (mriedem) wrote on 2016-09-26:

No, this isn't a regression, it looks like it's been this way since it was introduced in mitaka:

https://github.com/openstack/nova/commit/2ba4644f91aa523c2a14e32a168b853cf0b8c4e1

So we won't hold newton-rc2 for this.

tags:	added: pci
Changed in nova:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-10: Fix merged to nova (stable/newton)

Reviewed: https://review.openstack.org/375872
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=464d3b8322b147ba51eac238b6498914b0b69985
Submitter: Jenkins
Branch: stable/newton

commit 464d3b8322b147ba51eac238b6498914b0b69985
Author: Edan David <email address hidden>
Date: Mon Sep 19 10:48:55 2016 -0400

Add missing slash to dir path

    When validating a PF in the method 'get_function_by_ifname'
    the number of VFs are read from a file,
    the path to that file was missing a slash ('/').

    Change-Id: I7bf4bb96f1f769bff247f5af2c81dd96b08e2f04
    Closes-Bug: #1625220
    (cherry picked from commit 859de9c9971a3dd13f245d2245686fb3d19a832d)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-12: Fix included in openstack/nova 14.0.1

#10

This issue was fixed in the openstack/nova 14.0.1 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-14: Fix merged to nova (stable/mitaka)

#11

Reviewed: https://review.openstack.org/375873
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3cd8d23a3a16b55dca3f8e8c552ea936f684d100
Submitter: Jenkins
Branch: stable/mitaka

commit 3cd8d23a3a16b55dca3f8e8c552ea936f684d100
Author: Edan David <email address hidden>
Date: Mon Sep 19 10:48:55 2016 -0400

Add missing slash to dir path

    When validating a PF in the method 'get_function_by_ifname'
    the number of VFs are read from a file,
    the path to that file was missing a slash ('/').

    Change-Id: I7bf4bb96f1f769bff247f5af2c81dd96b08e2f04
    Closes-Bug: #1625220
    (cherry picked from commit 859de9c9971a3dd13f245d2245686fb3d19a832d)