OpenStack Compute (nova)

Use latest pep8 in pip-requires

Bug #721867 reported by Rick Harris
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
Lorin Hochstein
OpenStack Compute (nova) 2011.3 "diablo"

Bug Description

We're currently pinning to an old version of pep8. We should probably be using the latest, or at the very least, 0.6.

Related branches

lp://staging/~usc-isi/nova/instance_type_extra_specs
Brian Waldon (community): Approve
Vish Ishaya (community): Approve
Nova Core security contacts: Pending requested
Diff: 986 lines (+775/-9)
12 files modified
nova/api/openstack/contrib/flavorextraspecs.py (+126/-0)
nova/db/api.py (+21/-0)
nova/db/sqlalchemy/api.py (+114/-4)
nova/db/sqlalchemy/migrate_repo/versions/028_add_instance_type_extra_specs.py (+67/-0)
nova/db/sqlalchemy/models.py (+16/-1)
nova/exception.py (+5/-0)
nova/scheduler/host_filter.py (+25/-1)
nova/tests/api/openstack/extensions/test_flavors_extra_specs.py (+198/-0)
nova/tests/scheduler/test_host_filter.py (+35/-1)
nova/tests/test_host_filter.py (+2/-1)
nova/tests/test_instance_types_extra_specs.py (+165/-0)
tools/pip-requires (+1/-1)
Revision history for this message
Jay Pipes (jaypipes) wrote :

Yet another reason why putting:

dependency==specific-version

in pip-requires is generally not a good thing.

-jay

Revision history for this message
Thierry Carrez (ttx) wrote :

Our Hudson setup being Ubuntu-based and Ubuntu having pep8 0.5.0 in Maverick and Natty, I suspect the automated tests on trunk are using 0.5.0... hence the pinning for those using pip-requires ?

Any reason why we would *want* to use pep8 0.6 ?

Changed in nova:
status: New → Incomplete
Revision history for this message
Soren Hansen (soren) wrote : Re: [Bug 721867] Re: Use latest pep8 in pip-requires

We've used 0.6.1 on the Jenkins box for months and months. Why it's
not in Natty is a mystery to me.

2011/2/21 Thierry Carrez <email address hidden>:
> Our Hudson setup being Ubuntu-based and Ubuntu having pep8 0.5.0 in
> Maverick and Natty, I suspect the automated tests on trunk are using
> 0.5.0... hence the pinning for those using pip-requires ?
>
> Any reason why we would *want* to use pep8 0.6 ?
>
> ** Changed in: nova
>       Status: New => Incomplete
>
> --
> You received this bug notification because you are subscribed to
> OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/721867
>
> Title:
>  Use latest pep8 in pip-requires
>

--
Soren Hansen        | http://linux2go.dk/
Ubuntu Developer    | http://www.ubuntu.com/
OpenStack Developer | http://www.openstack.org/

Revision history for this message
Soren Hansen (soren) wrote :

Ah, apparantly 0.6.1 isn't even in Debian yet; Monty just packaged it
for us. Maybe he has some insight.

Revision history for this message
Thierry Carrez (ttx) wrote :

@Monty: any chance you could comment on this ?

Revision history for this message
Lorin Hochstein (lorinh) wrote :

I just ran into some problems due to this issue. These checks fail with the old pep8 but succeed with the new one:

nova/api/openstack/__init__.py:116:51: E202 whitespace before '}'
                                    'boot': 'POST'
                                                  ^

nova/api/openstack/create_instance_helper.py:124:37: E202 whitespace before '}'
                'password': password
                                    ^

nova/api/openstack/create_instance_helper.py:141:64: E202 whitespace before ')'
                                  reservation_id=reservation_id
                                                               ^

Revision history for this message
Sandy Walsh (sandy-walsh) wrote :

Correct, I'm using the new pep8.

Thierry Carrez (ttx)
Changed in nova:
status: Incomplete → Fix Committed
Revision history for this message
Lorin Hochstein (lorinh) wrote :

I don't think lp:~rackspace-titan/nova/old-version-pep8 actually fixes this bug.

Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Incomplete
Thierry Carrez (ttx)
Changed in nova:
assignee: nobody → Lorin Hochstein (lorinh)
importance: Undecided → Wishlist
status: Incomplete → In Progress
Thierry Carrez (ttx)
Changed in nova:
status: In Progress → Fix Committed
milestone: none → diablo-2
Thierry Carrez (ttx)
Changed in nova:
milestone: diablo-2 → 2011.3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.