OpenStack Compute (nova)

Request to list REST API versions doesn't return the request id

Bug #1960021 reported by Gorka Eguileor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Gorka Eguileor
OpenStack Compute (nova)
Confirmed
Low
Unassigned

Bug Description

When we do a GET on the root of the REST API service to get available versions we don't get any of the expected request id headers.

These headers are "x-openstack-request-id" and "x-compute-request-id" for both Cinder and Nova.

Tags: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/827860

OpenStack Infra (hudson-openstack)
Changed in cinder:
status: New → In Progress
Sylvain Bauza (sylvain-bauza)
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/827860
Committed: https://opendev.org/openstack/cinder/commit/18b8033b6bd1945bd27b03b779a32a883df5fb10
Submitter: "Zuul (22348)"
Branch: master

commit 18b8033b6bd1945bd27b03b779a32a883df5fb10
Author: Gorka Eguileor <email address hidden>
Date: Fri Feb 4 12:42:25 2022 +0100

    Fix request id mess on Cinder-API

    This patch fixes multiple issues related to request ids:

    - Duplicated request ID in logs
    - Missing request id header in response
    - Wrong request ID in response header when using noauth

    The source of these issues is the fact that the request ID and the
    request context are set too late, or not at all, in the paste filter
    chain.

    And the last bug is fixed as a freebie when the code in auth.py is
    refactored to reduce code duplication on setting the cinder.context key
    in the request's environment.

    The patch fixes these issue by changing the filter chains to have the
    request_id filter as the first filter, and using our own filter for it,
    to ensure that the context is correctly set.

    Not sure if values now defined in ENV_OVERWRITES are still necessary,
    so the patch preserves current behavior.

    Closes-Bug: #1960019
    Closes-Bug: #1960020
    Closes-Bug: #1960021
    Closes-Bug: #1960329
    Change-Id: Ide831a221a7561bbb7da193f0edb011f1989420e

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 20.0.0.0rc1

This issue was fixed in the openstack/cinder 20.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.