| 2020-08-21 08:03:54 |
Rikimaru Honjo |
bug |
|
|
added bug |
| 2020-08-21 08:04:17 |
Rikimaru Honjo |
description |
[Issue]
[compute]consecutive_build_service_disable_threshold option was added in the following patch.
https://review.opendev.org/#/c/463597/
The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
At that time consecutive_build_service_disable_threshold was used as threshold.
But, the following patch deleted the feature to automatically disable the service record.
https://review.opendev.org/#/c/572195/
This option's behavior after merging the above patch is this:
* Any positive integer enables reporting build failures.
* Zero to disable reporting build failures.
consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
Therefore, I think that consecutive_build_service_disable_threshold is an an inappropriate name in current nova.
[Improvement plan]
Update the option name.
e.g.
[compute]enable_reporting_of_build_failures |
[Issue]
[compute]consecutive_build_service_disable_threshold option was added by the following patch.
https://review.opendev.org/#/c/463597/
The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
At that time consecutive_build_service_disable_threshold was used as threshold.
But, the following patch deleted the feature to automatically disable the service record.
https://review.opendev.org/#/c/572195/
This option's behavior after merging the above patch is this:
* Any positive integer enables reporting build failures.
* Zero to disable reporting build failures.
consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
Therefore, I think that consecutive_build_service_disable_threshold is an an inappropriate name in current nova.
[Improvement plan]
Update the option name.
e.g.
[compute]enable_reporting_of_build_failures |
|
| 2020-08-21 08:05:28 |
Rikimaru Honjo |
description |
[Issue]
[compute]consecutive_build_service_disable_threshold option was added by the following patch.
https://review.opendev.org/#/c/463597/
The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
At that time consecutive_build_service_disable_threshold was used as threshold.
But, the following patch deleted the feature to automatically disable the service record.
https://review.opendev.org/#/c/572195/
This option's behavior after merging the above patch is this:
* Any positive integer enables reporting build failures.
* Zero to disable reporting build failures.
consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
Therefore, I think that consecutive_build_service_disable_threshold is an an inappropriate name in current nova.
[Improvement plan]
Update the option name.
e.g.
[compute]enable_reporting_of_build_failures |
[Issue]
[compute]consecutive_build_service_disable_threshold option was added by the following patch.
https://review.opendev.org/#/c/463597/
The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
At that time consecutive_build_service_disable_threshold was used as threshold.
But, the following patch deleted the feature to automatically disable the service record.
https://review.opendev.org/#/c/572195/
This option's behavior after merging the above patch is this:
* Any positive integer enables reporting build failures.
* Zero to disable reporting build failures.
consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
Therefore, I think that consecutive_build_service_disable_"threshold" is an inappropriate name in current nova.
[Improvement plan]
Update the option name.
e.g.
[compute]enable_reporting_of_build_failures |
|
| 2020-08-21 08:36:13 |
Rikimaru Honjo |
description |
[Issue]
[compute]consecutive_build_service_disable_threshold option was added by the following patch.
https://review.opendev.org/#/c/463597/
The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
At that time consecutive_build_service_disable_threshold was used as threshold.
But, the following patch deleted the feature to automatically disable the service record.
https://review.opendev.org/#/c/572195/
This option's behavior after merging the above patch is this:
* Any positive integer enables reporting build failures.
* Zero to disable reporting build failures.
consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
Therefore, I think that consecutive_build_service_disable_"threshold" is an inappropriate name in current nova.
[Improvement plan]
Update the option name.
e.g.
[compute]enable_reporting_of_build_failures |
[Issue]
[compute]consecutive_build_service_disable_threshold option was added by the following patch.
https://review.opendev.org/#/c/463597/
The nova-compute's service record was automatically disabled if we consecutively failed to build a certain number of instances after metging the patch.
At that time consecutive_build_service_disable_threshold was used as threshold.
But, the following patch deleted the feature to automatically disable the service record.
https://review.opendev.org/#/c/572195/
This option's behavior after merging the above patch is this:
* Any positive integer enables reporting build failures.
* Zero to disable reporting build failures.
consecutive_build_service_disable_threshold is used as a boolean value now. There is no difference of behavior between 1 and higher value.
Therefore, I think that consecutive_build_service_disable_"threshold" is an inappropriate name in current nova.
[Improvement idea]
Update the option name.
e.g.
[compute]enable_reporting_of_build_failures |
|
| 2020-08-27 08:42:04 |
Balazs Gibizer |
nova: importance |
Undecided |
Wishlist |
|
| 2020-09-03 08:32:19 |
Balazs Gibizer |
nova: status |
New |
Confirmed |
|
