Nova ignores delete requests while instance is in deleting state

Bug #1862394 reported by Vladyslav Drok
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Confirmed
Low
Rajesh Tailor

Bug Description

Right now the code in compute.api delete methods ignores delete requests if the instance is already in deleting state (https://github.com/openstack/nova/blob/69ce0f01b60dfe0f020ac57eb82a42e5935064c4/nova/compute/api.py#L2257-L2262). It was result of discussion in https://bugs.launchpad.net/nova/+bug/1248563 and mailing list thread referenced there. Though right now, after python 2 EOL, it is possible to allow multiple delete requests, without having to worry about delete requests piling up waiting on the instance uuid lock, if the lock will be acquired with timeout. Python 3 supports passing timeout argument to lock.acquire, so it'll have to be a pretty easy change to oslo.concurrency to allow passing that timeout through (for example using acquire call with timeout in https://github.com/openstack/oslo.concurrency/blob/c08159119e605dea76580032ca85834d1de21d3e/oslo_concurrency/lockutils.py#L156-L162). The instance deletion flow could then use such way of lock acquisition, and if it was not acquired, to allow user to retry later.

Tags: api
Revision history for this message
Balazs Gibizer (balazs-gibizer) wrote :

What is not clear to me what leads to a second DELETE request if the instance is already in DELETING state? Is the instance stuck in DELETING state? If yes, then I think we should fix that bug. If no, then I guess instance will eventually be deleted and no need for the second DELETE request.

I put this bug to incomplete but feel free to but back in New when you provide the answer of the above question.

Changed in nova:
status: New → Incomplete
Revision history for this message
Vladyslav Drok (vdrok) wrote :

After rabbit outage some instances might remain stuck in DELETING state as messages to delete them will be lost (and it was the case when this issue was reported).

Changed in nova:
status: Incomplete → New
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
tags: added: api
Rajesh Tailor (ratailor)
Changed in nova:
assignee: nobody → Rajesh Tailor (ratailor)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.