_check_can_migrate_pci in the LiveMigrationTask has host agnostic validation that is redundant/expensive

Bug #1842087 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Triaged
Low
Unassigned

Bug Description

This PCI validation code in the live migration task in conductor is run per possible dest host for the migration:

https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L212-L228

But is host agnostic, meaning if I have 100 possible dest hosts for the live migration and an instance with a flavor-defined pci request, it's going to fail that validation the same way 100 times.

That validation should be pulled up to a point before we even start asking the scheduler for hosts, e.g. like the numa live migration support:

https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L85

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.