libvirt: hard reboot incorrectly create nova/instances/<uuid>/<uuid>_disk with lvm backend

Bug #1623703 reported by vu tran
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)

Bug Description

Configure Nova compute to use lvm backend, spawn an instance based on glance image, under folder nova/instances/<uuid> we don't see any <uuid>_disk file and this is correct. Next, if we do a hard reboot on this instance then libvirt incorrectly creates file nova/instances/<uuid>/<uuid>_disk.

Steps to reproduce under devstack:

* On compute node, create LVM volume group "image-lvm-local"
* On compute node, modify nova config file under [libvirt] to enable lvm backend with
  images_type = "lvm" and images_volume_group = "image-lvm-local"
* Start an instance no file nova/instances/<uuid>/<uuid>_disk exists
* Do hard reboot on the instance and nova/instances/<uuid>/<uuid>_disk is incorrectly created.

vu tran (vu-tran)
Changed in nova:
assignee: nobody → vu tran (vu-tran)
tags: added: libvirt
Revision history for this message
Sylvain Bauza (sylvain-bauza) wrote :

I just checked the path of hard_reboot in the libvirt driver, and it shares the same logic with pre-live-migration for creating the images.

By looking at _create_images_and_backing() helper method, I think the logic is wrong by verifying the backing file and not using the imagebackend.

So, I think the problem is for both API actions (live-migrate and hard reboot).

Changed in nova:
importance: Undecided → Critical
importance: Critical → Medium
status: New → Confirmed
tags: added: live-migration reboot
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Michael Still (<email address hidden>) on branch: master
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the nova review queue sane. Please feel free to restore the change if you're still working on it.

Sean Dague (sdague)
Changed in nova:
assignee: vu tran (vu-tran) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.