Tautology in libvirt driver cleanup method
Bug #1544103 reported by
Timofey Durakov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Confirmed
|
Low
|
Unassigned | ||
Bug Description
for clean up phase in driver destroy_disks parameter is calculated in compute manager https:/
destroy_disks = not is_shared_
Then in libvirt driver cleanup method there is expression
https:/
if destroy_disks or is_shared_
which doesn't make sense as its tautology and always evaluated to True.
| Changed in nova: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in nova: | |
| assignee: | nobody → Sana Khan (sana.khan) |
| Changed in nova: | |
| assignee: | Sana Khan (sana.khan) → Timofey Durakov (tdurakov) |
| status: | Confirmed → In Progress |
Revision history for this message
| Sana Khan (sanakhanlibre) wrote | #1 |
| Changed in nova: | |
| status: | In Progress → Confirmed |
Revision history for this message
| Timofey Durakov (tdurakov) wrote | #2 |
| Changed in nova: | |
| status: | Confirmed → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix proposed to nova (master) | #3 |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Change abandoned on nova (master) | #4 |
Revision history for this message
| Sean Dague (sdague) wrote | #5 |
| Changed in nova: | |
| status: | In Progress → Confirmed |
| assignee: | Timofey Durakov (tdurakov) → nobody |
To post a comment you must log in.
The expression 'if destroy_disks or is_shared_
will be a Tautology only when both the ifs are evaluated as true:
https:/
https:/
For other cases, it won't be a Tautology.