Nova flavor extra_spec is case sensitive

Bug #1484753 reported by Tan Lin
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)

Bug Description

flavor extra_spec is case sensitive, we should make it insensitive which is more robust and improve user experience, like `Trusted` should be accepted as well as `trusted`

Tan Lin (tan-lin-good)
Changed in nova:
assignee: nobody → Tan Lin (tan-lin-good)
tags: added: flavors
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

Confirmed: The "trusted_filter" for example uses a case sensitive comparison [1]:

    def is_trusted(self, host, trust):
        level = self.caches.get_host_attestation(host)
        return trust == level


Changed in nova:
status: New → Confirmed
importance: Undecided → Low
status: Confirmed → In Progress
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

In Progress: Tan Lin is set as assignee.

Revision history for this message
Rui Chen (kiwik-chenrui) wrote :
Matt Riedemann (mriedem)
tags: added: scheduler
Changed in nova:
importance: Low → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Michael Still (<email address hidden>) on branch: master
Reason: This patch has been stalled for quite a while, so I am going to abandon it to keep the code review queue sane. Please restore the change when it is ready for review.

Changed in nova:
assignee: Tan Lin (tan-lin-good) → nobody
status: In Progress → Confirmed
Changed in nova:
assignee: nobody → Gregory Hooks (gregoryhooksjr)
Changed in nova:
assignee: Gregory Hooks (gregoryhooksjr) → nobody
Revision history for this message
Dave Johnston (dave-johnston) wrote :

Should this be progressed? Can we get agreement on whether filters should be case sensitive or not?

I've seen particular situation where different users are responsible for creating flavors and extra_specs on a host aggregate. In that situation case sensitivity can be more of a pain.

User one creates flavors to support CPU pinning

nova flavor-key compute-optimized.small set aggregate_instance_extra_specs:pinned"="false";

User two who racks the hardware and configures it in Openstack, specifies which machines can be used for dedicated CPU pinning

nova aggregate-set-metadata 2 pinned=False

In this scenario the operators would want false == False.

Are there any scenarios where case insensitivity would be undesirable?

Changed in nova:
assignee: nobody → Dave Johnston (dave-johnston)
Sean Dague (sdague)
Changed in nova:
assignee: Dave Johnston (dave-johnston) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.