OpenStack Compute (nova)

live migration doesn't work for VMs in rescued state

Bug #1305062 reported by Loganathan Parthipan on 2014-04-09

This bug affects 5 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Confirmed	Medium	Unassigned

Bug Description

I'd expect live-migration to migrate instances in rescued state as they're online VMs anyway, as opposed to those that are shutoff or suspended. However, I see that it's currently disabled in the compute API.

nova live-migration --block-migrate b32b0eb4-b8aa-4204-b104-61e733839227 overcloud-novacompute0-aipxwbabgq7a
ERROR: Cannot 'os-migrateLive' while instance is in vm_state rescued (HTTP 409) (Request-ID: req-5eea8f1c-5602-4d48-9690-929baff3b560)

This is stopped by this decorator:

@check_instance_state(vm_state=[vm_states.ACTIVE])
def live_migrate(self, context, instance, block_migration,

However, there are more to it than fixing the decorator.

Should we treat this as a feature or bugfix?

See original description

Tags:

Loganathan Parthipan (parthipan) on 2014-04-09

Changed in nova:
assignee:	nobody → Loganathan Parthipan (parthipan)

Revision history for this message

Daniel Berrange (berrange) wrote on 2014-04-09:

For paused VMs this is certainly a bug - there's no reason to restrict this for paused VMs.

For rescued VMs, it is a little more complicated, but again the VM is "active" from the POV of the user so I'd expect migrate to be allowe & o succeed.

Tracy Jones (tjones-i) on 2014-04-09

tags:

added: compute

Loganathan Parthipan (parthipan) on 2014-04-12

Changed in nova:
status:	New → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-06-04: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/97797

Changed in nova:
status:	Confirmed → In Progress

Revision history for this message

Loganathan Parthipan (parthipan) wrote on 2014-06-12: Re: live migration doesn't work for VMs in paused or rescued states

Could someone please review this patch to fix paused live-migrations?
https://review.openstack.org/#/c/97797/

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-09-17: Change abandoned on nova (master)

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/97797
Reason: this has not addressed comments in over 1.5 months, abandoning

Revision history for this message

Sean Dague (sdague) wrote on 2014-09-17: Re: live migration doesn't work for VMs in paused or rescued states

Upstream patch stalled

Changed in nova:
status:	In Progress → Confirmed
importance:	Undecided → Medium
assignee:	Loganathan Parthipan (parthipan) → nobody

Matthew Gilliard (matthew-gilliard-u) on 2014-12-12

Changed in nova:
assignee:	nobody → Matthew Gilliard (matthew-gilliard-u)

Revision history for this message

Matthew Gilliard (matthew-gilliard-u) wrote on 2014-12-12:

I have agreed with Parthipan that I will continue his fix. I would like to confirm with Dan Berrange and others whether the approach taken there is still correct. Thanks.

OpenStack Infra (hudson-openstack) on 2014-12-15

Changed in nova:
status:	Confirmed → In Progress

Revision history for this message

Davanum Srinivas (DIMS) (dims-v) wrote on 2015-02-12:

Fix proposed again.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-19: Fix merged to nova (master)

Reviewed: https://review.openstack.org/97797
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=22dde6e56b2d93d9aa3776952eb7fc0792e220dc
Submitter: Jenkins
Branch: master

commit 22dde6e56b2d93d9aa3776952eb7fc0792e220dc
Author: Loganathan Parthipan <email address hidden>
Date: Mon Dec 15 14:23:18 2014 +0000

Support live-migrate of instances in PAUSED state

Live migration enables one to migrate an active VM that consumes
system resources such as memory and CPU.

    Nova currently allows only those in ACTIVE vm_state to migrate. This
    patch adds support for PAUSED vm_state. Essentially a paused state is
    identical to a running state except the stopped CPUs.

Co-Author: "Matthew Gilliard <email address hidden>"

Partial-Bug: #1305062
Change-Id: Ib38eaf412cb51a9cbfc443c5ec15c5797265ddae

Revision history for this message

Bartosz Fic (bartosz-fic) wrote on 2015-03-11: Re: live migration doesn't work for VMs in paused or rescued states

Here is doc related to vm states and transitions:
http://docs.openstack.org/developer/nova/devref/vmstates.html

Do you think, that this change has impact on this doc ?

Pawel Koniszewski (pawel-koniszewski) on 2015-03-19

tags:

added: live-migrate

Revision history for this message

Pawel Koniszewski (pawel-koniszewski) wrote on 2015-04-02:

#10

Matthew, do you also work on LM of VMs in rescued state?

Revision history for this message

Matthew Gilliard (matthew-gilliard-u) wrote on 2015-04-02: Re: [Bug 1305062] Re: live migration doesn't work for VMs in paused or rescued states

#11

Hi Pawel

Yes, I expect to have a patch up for this soon (next couple of
weeks). It's a more complicated case though, sadly.

Matthew

On 02/04/15 13:46, Pawel Koniszewski wrote:
> Matthew, do you also work on LM of VMs in rescued state?
>

Pawel Koniszewski (pawel-koniszewski) on 2015-10-20

summary:	- live migration doesn't work for VMs in paused or rescued states + live migration doesn't work for VMs in rescued state
description:	updated
Changed in nova:
assignee:	Matthew Gilliard (matthew-gilliard-u) → nobody

Pawel Koniszewski (pawel-koniszewski) on 2015-11-05

Changed in nova:
status:	In Progress → Confirmed

Paul Murray (pmurray) on 2015-11-06

tags:

added: live-migration
removed: live-migrate

lvmxh (shaohef) on 2015-11-17

Changed in nova:
assignee:	nobody → lvmxh (shaohef)

lvmxh (shaohef) on 2015-12-03

Changed in nova:
assignee:	lvmxh (shaohef) → nobody

Sujitha (sujitha-neti) on 2016-01-21

Changed in nova:
assignee:	nobody → Sujitha (sujitha-neti)

Revision history for this message

Sujitha (sujitha-neti) wrote on 2016-01-21:

#12

Allowing live migration for rescue state would come under feature enhancement. So I think it has to be moved to Wishlist.

Changed in nova:
assignee:	Sujitha (sujitha-neti) → nobody

Revision history for this message

John Garbutt (johngarbutt) wrote on 2016-02-02:

#13

This feels like a bug fix.

Changed in nova:
importance:	Medium → Wishlist

stgleb (gstepanov) on 2016-03-14

Changed in nova:
assignee:	nobody → stgleb (gstepanov)

Revision history for this message

Markus Zoeller (markus_z) (mzoeller) wrote on 2016-04-18:

#14

After double-checking with danpb this is still a valid bug report and
it should be fixed for rescued instances.

Dear assignee, please provide a (WIP) patch in the next weeks. If you
stop working on this report, please remove yourself as assignee and
switch the status back. If you need assistance, reach out on the
IRC channel #openstack-nova or use the mailing list.

Changed in nova:
importance:	Wishlist → Medium
status:	Confirmed → In Progress

Revision history for this message

Sean Dague (sdague) wrote on 2017-06-23:

#15

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.