OpenStack Compute (nova)

force_config_drive=True don't go to db

Bug #1303714 reported by Nikolay Starodubtsev
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
In Progress
Wishlist
sean mooney

Bug Description

If we use --config-drive=True via client we'll have filled config_drive column in db. In the other hand if we use force_config_drive=True in nova.conf the column will be empty. Also, in both cases config drive will be attached to vm, and I can't find any problems with live-migration or evacuation. In my deployment I use shared storage.

Tags: db
Tracy Jones (tjones-i)
tags: added: db
Revision history for this message
Thang Pham (thang-pham) wrote :

Are you saying --config-drive=True via client and force_config_drive=True via nova.conf should both set the config_drive db column? I believe it maybe intended to work that way because if force_config_drive=False in nova.conf, setting --config-drive=True via client is a way to override the nova.conf setting.

Revision history for this message
Nikolay Starodubtsev (starodubcevna) wrote :

I think that if we have force_config_drive = True in nova.conf the column in db should be filled with True. Isn't it obvious?

Revision history for this message
Thang Pham (thang-pham) wrote :

I see the db column more as a way to override the default behavior found in nova.conf, but I see your point.

Revision history for this message
Thang Pham (thang-pham) wrote :

This is related to bug #1193438. One comment from Michael Still on bug #1193438 is:
    I've reviewed the code review for this one, and I think changing this is a bad idea.

Revision history for this message
Michael Still (mikal) wrote :

That's not really true -- what I was saying in that review is that I think changing the type of the DB column is a bad idea. I think having the right data in that column (this bug) is a good idea though.

Changed in nova:
status: New → Triaged
importance: Undecided → Low
Michael Still (mikal)
Changed in nova:
assignee: nobody → Michael Still (mikalstill)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/92899

Changed in nova:
status: Triaged → In Progress
Revision history for this message
Sean Dague (sdague) wrote :

Patch dead

Changed in nova:
importance: Low → Wishlist
status: In Progress → Confirmed
assignee: Michael Still (mikalstill) → nobody
Revision history for this message
Michael Still (mikal) wrote :

Actually not dead. I was rebasing it yesterday.

(Although I admit its sat around for a long time).

Changed in nova:
assignee: nobody → Michael Still (mikalstill)
OpenStack Infra (hudson-openstack)
Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/92899
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Removing "In Progress" status and assignee as change is abandoned.

Changed in nova:
status: In Progress → Confirmed
assignee: Michael Still (mikalstill) → nobody
Zhenzan Zhou (zhenzan-zhou)
Changed in nova:
assignee: nobody → Zhenzan Zhou (zhenzan-zhou)
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Zhenzan Zhou (zhenzan-zhou) → Stephen Finucane (sfinucan)
status: Confirmed → In Progress
Davanum Srinivas (DIMS) (dims-v)
Changed in nova:
assignee: Stephen Finucane (sfinucan) → nobody
status: In Progress → Confirmed
Stephen Finucane (stephenfinucane)
Changed in nova:
assignee: nobody → Stephen Finucane (sfinucan)
OpenStack Infra (hudson-openstack)
Changed in nova:
status: Confirmed → In Progress
Revision history for this message
stgleb (gstepanov) wrote :

Stepghe, are you still working on this patch?

Revision history for this message
Stephen Finucane (stephenfinucane) wrote :

@stgleb: Yes, I have a patch waiting for review.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/92899

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/364814

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/376452
Reason: not actual

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/364814
Reason: This review is > 4 weeks without comment, and is not mergable in it's current state. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in nova:
status: In Progress → Confirmed
assignee: Stephen Finucane (stephenfinucane) → nobody
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: nobody → yuanyue (yyuanyuee)
status: Confirmed → In Progress
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: yuanyue (yyuanyuee) → Matthew Booth (mbooth-9)
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Matthew Booth (mbooth-9) → sean mooney (sean-k-mooney)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.