OpenStack Compute (nova)

Settings the availability zone deletes all attached metadata

Bug #1274924 reported by Thomas Bechtold
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Santiago Baldassin
OpenStack Compute (nova) 2014.2 "juno"
python-novaclient
Invalid
Wishlist
Santiago Baldassin

Bug Description

I'm using latest git with devstack on Ubuntu 12.04.

When I update the availability zone the attached metadata gets deleted. Steps to reproduce the problem:

 1) nova aggregate-create testagg #assuming that this creates a new metadata entry with the Id 26
 2) nova aggregate-set-metadata 26 x=y
 3) nova aggregate-update 26 testagg zone1

Now the availability zone is set, but the x=y metadata is lost.

Revision history for this message
John Garbutt (johngarbutt) wrote :

I think that is as expected, it updates all the metadata to that supplied, however, its a bit confusing.

tags: added: api
Changed in nova:
status: New → Triaged
tags: added: nova-client
tags: added: novaclient
removed: nova-client
Revision history for this message
Joe Gordon (jogo) wrote :

This is working as expected.

We can update this behavior in the V3 API or make the python-novaclient more intelligent to handle this

Santiago Baldassin (santiago-b-baldassin)
Changed in python-novaclient:
assignee: nobody → Santiago Baldassin (santiago-b-baldassin)
Revision history for this message
Santiago Baldassin (santiago-b-baldassin) wrote :

hi guys, even when this is working as expected I don't think it's working ok. We have two api calls to do the same thing both set-metadata and update will manipulate the aggregate metadata.

Adding/updating availability zone ends up setting metadata then we should use update_aggregate_metadata instead of update_aggregate. I guess we are just replacing the existing metadata to enforce the uniqueness of availability zone for an aggregate.

Set metadata for aggregates will be added to the dashboard so I think before exposing the functionality to the end users we should figure this out

Changed in nova:
assignee: nobody → Santiago Baldassin (santiago-b-baldassin)
Revision history for this message
melanie witt (melwitt) wrote :

Novaclient could be updated to not pass on an empty metadata update (or pass the same/current metadata) if the user omits the argument on the command line.

Changed in python-novaclient:
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Santiago Baldassin (santiago-b-baldassin) wrote :

Won't be fixed in nova as it will introduce backward incompatibility. See review: https://review.openstack.org/#/c/81356/

Changed in python-novaclient:
status: Triaged → In Progress
Revision history for this message
Santiago Baldassin (santiago-b-baldassin) wrote :

Please disregard my previous comment. Got confused with another bug

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/84202

Dan Smith (danms)
tags: added: icehouse-backport-potential
Revision history for this message
Santiago Baldassin (santiago-b-baldassin) wrote :

Fixed in nova. No need to fix in python-nova-cllient

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/84202
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=328beb0433c04a0888d38cbc2927248fdd963318
Submitter: Jenkins
Branch: master

commit 328beb0433c04a0888d38cbc2927248fdd963318
Author: Santiago Baldassin <email address hidden>
Date: Mon Mar 31 14:12:28 2014 -0300

    Do not replace the aggregate metadata when updating az

    When the aggregate availability zone is updated, the
    existing metadata should not be replaced

    Change-Id: Ife856af9e7dca836ebe8a1ec050effaad421e17d
    Closes-Bug: #1274924

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Santiago Baldassin (santiago-b-baldassin)
Changed in python-novaclient:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/99453

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/99454

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/icehouse)

Change abandoned by Santiago Baldassin (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/99453

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Santiago Baldassin (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/99454

Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/133643

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/icehouse)

Change abandoned by David Geng (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/133643

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.