nova-lxd

debug logs are not enough

Bug #1657339 reported by makocchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nova-lxd
Fix Committed
Medium
Unassigned

Bug Description

Debug log is not enough because log format is not correct.

for example,

LOG.debug('container_init called for instance', instance=instance)

should be

LOG.debug('container_init called for %(instance)s', {'instance': instance})

makocchi (makocchi)
Changed in nova-lxd:
assignee: nobody → makocchi (makocchi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova-lxd (master)

Fix proposed to branch: master
Review: https://review.openstack.org/421679

Changed in nova-lxd:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova-lxd (master)

Change abandoned by Paul Hummer (<email address hidden>) on branch: master
Review: https://review.openstack.org/421679

James Page (james-page)
Changed in nova-lxd:
status: In Progress → Triaged
importance: Undecided → Medium
Alex Kavanagh (ajkavanagh)
Changed in nova-lxd:
assignee: makocchi (makocchi) → nobody
assignee: nobody → Alex Kavanagh (ajkavanagh)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova-lxd (master)

Fix proposed to branch: master
Review: https://review.openstack.org/571748

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova-lxd (master)

Reviewed: https://review.openstack.org/571748
Committed: https://git.openstack.org/cgit/openstack/nova-lxd/commit/?id=84a7945bca43205ce2c92cdd34b27da12749d24f
Submitter: Zuul
Branch: master

commit 84a7945bca43205ce2c92cdd34b27da12749d24f
Author: Alex Kavanagh <email address hidden>
Date: Fri Jun 1 15:40:14 2018 +0100

    Fix broken debug logs and modernise string interpolation

    Some of the debug logs were not actually outputing the instance;
    it was just tagged in the LOF.<type>(...) command.

    Also took the opportunity to modernise to '.format()' the string
    interpolation to meet current guidelines.

    Change-Id: I99c56ff738713140b2af16199e9e58b39bb4e396
    Closes-Bug: #1657339

Changed in nova-lxd:
status: In Progress → Fix Committed
Alex Kavanagh (ajkavanagh)
Changed in nova-lxd:
assignee: Alex Kavanagh (ajkavanagh) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.