wrong param name passed to make request

Bug #1359048 reported by Aaron Rosen
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
nova-docker
Fix Committed
Undecided
Aaron Rosen

Bug Description

2014-08-19 22:50:52.422 3284 AUDIT nova.compute.claims [req-1b53f7f1-5684-4d1a-be3e-716583dc8823 6852d653f9414ce0a629ef58655f811b 86efbfd96c504bb0879ee5550878b114] [instance: 6277bff7-2930-4fd8-b5b1-537bca5ea297] Claim successful
2014-08-19 22:50:53.196 3284 ERROR novadocker.virt.docker.driver [req-1b53f7f1-5684-4d1a-be3e-716583dc8823 6852d653f9414ce0a629ef58655f811b 86efbfd96c504bb0879ee5550878b114] YOOOO
2014-08-19 22:50:53.196 3284 TRACE novadocker.virt.docker.driver Traceback (most recent call last):
2014-08-19 22:50:53.196 3284 TRACE novadocker.virt.docker.driver File "/usr/local/lib/python2.7/dist-packages/novadocker/virt/docker/driver.py", line 252, in _pull_missing_image
2014-08-19 22:50:53.196 3284 TRACE novadocker.virt.docker.driver self.docker.load_repository_file(image_meta['name'], out_path)
2014-08-19 22:50:53.196 3284 TRACE novadocker.virt.docker.driver File "/usr/local/lib/python2.7/dist-packages/novadocker/virt/docker/client.py", line 252, in load_repository_file
2014-08-19 22:50:53.196 3284 TRACE novadocker.virt.docker.driver self.load_repository(unicode(name).encode('utf-8'), fh)
2014-08-19 22:50:53.196 3284 TRACE novadocker.virt.docker.driver File "/usr/local/lib/python2.7/dist-packages/novadocker/virt/docker/client.py", line 248, in load_repository
2014-08-19 22:50:53.196 3284 TRACE novadocker.virt.docker.driver self.make_request('POST', url, data=data)
2014-08-19 22:50:53.196 3284 TRACE novadocker.virt.docker.driver File "/usr/local/lib/python2.7/dist-packages/novadocker/virt/docker/client.py", line 125, in make_request
2014-08-19 22:50:53.196 3284 TRACE novadocker.virt.docker.driver conn.request(*encoded_args, **kwargs)
2014-08-19 22:50:53.196 3284 TRACE novadocker.virt.docker.driver TypeError: request() got an unexpected keyword argument 'data'

Aaron Rosen (arosen)
Changed in nova-docker:
assignee: nobody → Aaron Rosen (arosen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova-docker (master)

Fix proposed to branch: master
Review: https://review.openstack.org/115507

Changed in nova-docker:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova-docker (master)

Reviewed: https://review.openstack.org/115507
Committed: https://git.openstack.org/cgit/stackforge/nova-docker/commit/?id=f984cde06baca5622ea0b0bbda8e1affc5e7773a
Submitter: Jenkins
Branch: master

commit f984cde06baca5622ea0b0bbda8e1affc5e7773a
Author: Aaron Rosen <email address hidden>
Date: Tue Aug 19 23:03:52 2014 -0700

    Fix wrong param name passed to make request

    request(), expects body not data:
    httplib.HTTPConnection.request(self, method, url, body=None, headers={})

    Change-Id: I82963ea0294d3bbdf109f42a9087a0208c353624
    Closes-bug: 1359048

Changed in nova-docker:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.