"Hide window when a song is being played" doesn't make sense
Bug #1289724 reported by
Cassidy James Blaede
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Noise |
Fix Released
|
Low
|
Corentin Noël | ||
Bug Description
That label is confusing and doesn't really describe what the setting is. Instead, it should read, "Continue playing when closed" or something similar. Maybe even as simple as "Background playback".
Related branches
lp://staging/~tintou/noise/fix-interface
- Danielle Foré: Approve
- Victor Martinez (community): Needs Information
-
Diff: 473 lines (+77/-104)7 files modifiedCMakeLists.txt (+5/-5)
plugins/LastFM/PreferencesSection.vala (+3/-3)
src/Dialogs/MediaEditor.vala (+25/-46)
src/Dialogs/PreferencesWindow.vala (+20/-20)
src/Dialogs/SmartPlaylistEditor.vala (+22/-22)
src/LibraryWindow.vala (+2/-2)
src/Widgets/StatusBar.vala (+0/-6)
Revision history for this message
| Danielle Foré (danrabbit) wrote | #1 |
| Changed in noise: | |
| importance: | Undecided → Low |
| Changed in noise: | |
| status: | New → Confirmed |
| Changed in noise: | |
| assignee: | nobody → Corentin Noël (tintou) |
| milestone: | none → isis-beta1 |
| status: | Confirmed → In Progress |
| Changed in noise: | |
| status: | In Progress → Fix Committed |
| Changed in noise: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Yeah I agree that it's a bit long winded. I'm a fan of "Continue playback when closed" because it's really explicit. "Background playback" makes sense to me, but I think only because I already know what it does.