neutron

L3 agent: traceback is suppressed on floating ip setup failure

  1. Series kilo
  2. Bug #1545695
Bug #1545695 reported by Oleg Bondarev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Oleg Bondarev
Kilo
New
Undecided
Unassigned

Bug Description

Following traceback says nothing about actual exception and makes it hard to debug issues:

2016-02-10 05:26:54.025 682 ERROR neutron.agent.l3.router_info [-] L3 agent failure to setup floating IPs
2016-02-10 05:26:54.025 682 TRACE neutron.agent.l3.router_info Traceback (most recent call last):
2016-02-10 05:26:54.025 682 TRACE neutron.agent.l3.router_info File "/usr/lib/python2.7/dist-packages/neutron/agent/l3/router_info.py", line 604, in process_external
2016-02-10 05:26:54.025 682 TRACE neutron.agent.l3.router_info fip_statuses = self.configure_fip_addresses(interface_name)
2016-02-10 05:26:54.025 682 TRACE neutron.agent.l3.router_info File "/usr/lib/python2.7/dist-packages/neutron/agent/l3/router_info.py", line 268, in configure_fip_addresses
2016-02-10 05:26:54.025 682 TRACE neutron.agent.l3.router_info raise n_exc.FloatingIpSetupException('L3 agent failure to setup '
2016-02-10 05:26:54.025 682 TRACE neutron.agent.l3.router_info FloatingIpSetupException: L3 agent failure to setup floating IPs

Need to log actual exception with traceback before reraising.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/280194

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/280194
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3188b458fd29bbd7711277bc337c0dacbaab4b9e
Submitter: Jenkins
Branch: master

commit 3188b458fd29bbd7711277bc337c0dacbaab4b9e
Author: Oleg Bondarev <email address hidden>
Date: Mon Feb 15 15:39:59 2016 +0300

    L3 agent: log traceback on floating ip setup failure

    Currently l3 agent suppresses exception traceback and just
    raises new FloatingIpSetupException so it's impossible to see
    actual issue from logs.
    The patch adds LOG.exception() to the exception handler before
    reraising.

    Closes-Bug: #1545695
    Change-Id: Ia4557473c7e362f98a564475527b97ee6d0178f9

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b3

This issue was fixed in the openstack/neutron 8.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/297050

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/297051

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/297050
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=92d58fc1fbea424374f690fe4ce4fd04a097c306
Submitter: Jenkins
Branch: stable/liberty

commit 92d58fc1fbea424374f690fe4ce4fd04a097c306
Author: Oleg Bondarev <email address hidden>
Date: Mon Feb 15 15:39:59 2016 +0300

    L3 agent: log traceback on floating ip setup failure

    Currently l3 agent suppresses exception traceback and just
    raises new FloatingIpSetupException so it's impossible to see
    actual issue from logs.
    The patch adds LOG.exception() to the exception handler before
    reraising.

    Conflicts:
     neutron/agent/l3/router_info.py

    Closes-Bug: #1545695
    Change-Id: Ia4557473c7e362f98a564475527b97ee6d0178f9
    (cherry picked from commit 3188b458fd29bbd7711277bc337c0dacbaab4b9e)

tags: added: in-stable-liberty
tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/297051
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=40ac9216f7e67e547c4a4d06aa46382d68115dc9
Submitter: Jenkins
Branch: stable/kilo

commit 40ac9216f7e67e547c4a4d06aa46382d68115dc9
Author: Oleg Bondarev <email address hidden>
Date: Mon Feb 15 15:39:59 2016 +0300

    L3 agent: log traceback on floating ip setup failure

    Currently l3 agent suppresses exception traceback and just
    raises new FloatingIpSetupException so it's impossible to see
    actual issue from logs.
    The patch adds LOG.exception() to the exception handler before
    reraising.

    Conflicts:
     neutron/agent/l3/router_info.py

    Closes-Bug: #1545695
    Change-Id: Ia4557473c7e362f98a564475527b97ee6d0178f9
    (cherry picked from commit 3188b458fd29bbd7711277bc337c0dacbaab4b9e)
    (cherry picked from commit 92d58fc1fbea424374f690fe4ce4fd04a097c306)

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 2015.1.4

This issue was fixed in the openstack/neutron 2015.1.4 release.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 7.1.0

This issue was fixed in the openstack/neutron 7.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 2015.1.4

This issue was fixed in the openstack/neutron 2015.1.4 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.